diff mbox series

[v4,6/7] dt-bindings: regulator: qcom-labibb: Document SCP/OCP interrupts

Message ID 20210119174421.226541-7-angelogioacchino.delregno@somainline.org
State Accepted
Commit 9499200484669fe33c20c735a3d5a29a0dc0e9d4
Headers show
Series Really implement Qualcomm LAB/IBB regulators | expand

Commit Message

AngeloGioacchino Del Regno Jan. 19, 2021, 5:44 p.m. UTC
Short-Circuit Protection (SCP) and Over-Current Protection (OCP) are
now implemented in the driver: document the interrupts.
This also fixes wrong documentation about the SCP interrupt for LAB.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 .../regulator/qcom-labibb-regulator.yaml      | 20 +++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

Comments

Rob Herring (Arm) Jan. 22, 2021, 5:09 p.m. UTC | #1
On Tue, Jan 19, 2021 at 06:44:20PM +0100, AngeloGioacchino Del Regno wrote:
> Short-Circuit Protection (SCP) and Over-Current Protection (OCP) are

> now implemented in the driver: document the interrupts.

> This also fixes wrong documentation about the SCP interrupt for LAB.

> 

> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>

> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> ---

>  .../regulator/qcom-labibb-regulator.yaml      | 20 +++++++++++--------

>  1 file changed, 12 insertions(+), 8 deletions(-)

> 

> diff --git a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml

> index 7a507692f1ba..cf784bd1f5e5 100644

> --- a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml

> +++ b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml

> @@ -29,9 +29,10 @@ properties:

>          default: 200

>  

>        interrupts:

> -        maxItems: 1

> +        minItems: 1

> +        maxItems: 2

>          description:

> -          Short-circuit interrupt for lab.

> +          Short-circuit and over-current interrupts for lab.


minItems: 1
items:
  - description: Short-circuit interrupt
  - description: over-current interrupt

>  

>      required:

>        - interrupts

> @@ -47,9 +48,10 @@ properties:

>          default: 300

>  

>        interrupts:

> -        maxItems: 1

> +        minItems: 1

> +        maxItems: 2

>          description:

> -          Short-circuit interrupt for lab.

> +          Short-circuit and over-current interrupts for ibb.

>  

>      required:

>        - interrupts

> @@ -67,13 +69,15 @@ examples:

>        compatible = "qcom,pmi8998-lab-ibb";

>  

>        lab {

> -        interrupts = <0x3 0x0 IRQ_TYPE_EDGE_RISING>;

> -        interrupt-names = "sc-err";

> +        interrupts = <0x3 0xde 0x1 IRQ_TYPE_EDGE_RISING>,

> +                     <0x3 0xde 0x0 IRQ_TYPE_LEVEL_LOW>;

> +        interrupt-names = "sc-err", "ocp";

>        };

>  

>        ibb {

> -        interrupts = <0x3 0x2 IRQ_TYPE_EDGE_RISING>;

> -        interrupt-names = "sc-err";

> +        interrupts = <0x3 0xdc 0x2 IRQ_TYPE_EDGE_RISING>,

> +                     <0x3 0xdc 0x0 IRQ_TYPE_LEVEL_LOW>;

> +        interrupt-names = "sc-err", "ocp";

>        };

>      };

>  

> -- 

> 2.30.0

>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
index 7a507692f1ba..cf784bd1f5e5 100644
--- a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
@@ -29,9 +29,10 @@  properties:
         default: 200
 
       interrupts:
-        maxItems: 1
+        minItems: 1
+        maxItems: 2
         description:
-          Short-circuit interrupt for lab.
+          Short-circuit and over-current interrupts for lab.
 
     required:
       - interrupts
@@ -47,9 +48,10 @@  properties:
         default: 300
 
       interrupts:
-        maxItems: 1
+        minItems: 1
+        maxItems: 2
         description:
-          Short-circuit interrupt for lab.
+          Short-circuit and over-current interrupts for ibb.
 
     required:
       - interrupts
@@ -67,13 +69,15 @@  examples:
       compatible = "qcom,pmi8998-lab-ibb";
 
       lab {
-        interrupts = <0x3 0x0 IRQ_TYPE_EDGE_RISING>;
-        interrupt-names = "sc-err";
+        interrupts = <0x3 0xde 0x1 IRQ_TYPE_EDGE_RISING>,
+                     <0x3 0xde 0x0 IRQ_TYPE_LEVEL_LOW>;
+        interrupt-names = "sc-err", "ocp";
       };
 
       ibb {
-        interrupts = <0x3 0x2 IRQ_TYPE_EDGE_RISING>;
-        interrupt-names = "sc-err";
+        interrupts = <0x3 0xdc 0x2 IRQ_TYPE_EDGE_RISING>,
+                     <0x3 0xdc 0x0 IRQ_TYPE_LEVEL_LOW>;
+        interrupt-names = "sc-err", "ocp";
       };
     };