diff mbox series

[3/4] drm/msm/dp: Initialize the INTF_CONFIG register

Message ID 20210511042043.592802-4-bjorn.andersson@linaro.org
State Superseded
Headers show
Series drm/msm/dp: Add support for SC8180x eDP controller | expand

Commit Message

Bjorn Andersson May 11, 2021, 4:20 a.m. UTC
Some bootloaders set the widebus enable bit in the INTF_CONFIG register,
but configuration of widebus isn't yet supported ensure that the
register has a known value, with widebus disabled.

Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support")
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

---
 drivers/gpu/drm/msm/dp/dp_catalog.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.29.2

Comments

Abhinav Kumar May 28, 2021, 11:28 p.m. UTC | #1
On 2021-05-10 21:20, Bjorn Andersson wrote:
> Some bootloaders set the widebus enable bit in the INTF_CONFIG 

> register,

> but configuration of widebus isn't yet supported ensure that the

> register has a known value, with widebus disabled.

> 

> Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support")

> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>

> ---

>  drivers/gpu/drm/msm/dp/dp_catalog.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.c

> b/drivers/gpu/drm/msm/dp/dp_catalog.c

> index a0449a2867e4..e3996eef5518 100644

> --- a/drivers/gpu/drm/msm/dp/dp_catalog.c

> +++ b/drivers/gpu/drm/msm/dp/dp_catalog.c

> @@ -707,6 +707,7 @@ int dp_catalog_panel_timing_cfg(struct dp_catalog

> *dp_catalog)

>  	dp_write_link(catalog, REG_DP_HSYNC_VSYNC_WIDTH_POLARITY,

>  				dp_catalog->width_blanking);

>  	dp_write_link(catalog, REG_DP_ACTIVE_HOR_VER, dp_catalog->dp_active);

> +	dp_write_p0(catalog, MMSS_DP_INTF_CONFIG, 0);

>  	return 0;

>  }
diff mbox series

Patch

diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.c b/drivers/gpu/drm/msm/dp/dp_catalog.c
index a0449a2867e4..e3996eef5518 100644
--- a/drivers/gpu/drm/msm/dp/dp_catalog.c
+++ b/drivers/gpu/drm/msm/dp/dp_catalog.c
@@ -707,6 +707,7 @@  int dp_catalog_panel_timing_cfg(struct dp_catalog *dp_catalog)
 	dp_write_link(catalog, REG_DP_HSYNC_VSYNC_WIDTH_POLARITY,
 				dp_catalog->width_blanking);
 	dp_write_link(catalog, REG_DP_ACTIVE_HOR_VER, dp_catalog->dp_active);
+	dp_write_p0(catalog, MMSS_DP_INTF_CONFIG, 0);
 	return 0;
 }