From patchwork Mon Aug 2 05:12:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 490308 Delivered-To: patch@linaro.org Received: by 2002:a05:6638:1185:0:0:0:0 with SMTP id f5csp1600612jas; Sun, 1 Aug 2021 22:14:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw7OlUQ14y8TYKfbWMiUrt0DMc7uX/u3Iz/WjGK+h5F3AEueZoh9TwyOX3yhDOoSieOYE4G X-Received: by 2002:a6b:dd02:: with SMTP id f2mr3880072ioc.11.1627881243570; Sun, 01 Aug 2021 22:14:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627881243; cv=none; d=google.com; s=arc-20160816; b=N/eb0923pA/i+hq+rU+jZRasDJwUvvGgme7if2PdAQ095vyhB+dVS90zBRrugG/9F1 rUqCPIvrlTzhW+AWb5pyUbYth7YJ/SCHrScRohvjvmoY3dvnQFuTsjlK3Vvc6GKopjfJ w1853JcBDx3v/0M7vXSH8biOdAGRAKHnlOqp9+LnzrCuCHn02LHTVVmxSSTX7aZ2ybpe YEssMjJp7Rc7KkIIgML405j/lL96cFeDL1loUKYx2KiqEYadOdvYArwW0DcQ8HzavYiT 7gPgPGDr1SeicWuyFOGVi+8RoElNSLZFGvbp5HOJZBTrEf8K2hpPV1Rx+z/6b995I9oG sYqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=y3jqjblyF+bNujjzoE4Dt1sYtyoNDw930jBhejpyDsQ=; b=cjvqFCiAtUrXmYeId1dMxDWy2mwlxfkV6YKJyhZSqxVPNxGyk0wugLosv3JBiomg9Q qKaPVYd5iNxXA5NYXwRIH1Biyt8JhFH6rWz+8bCYr0W7fbstnXi0MYZd5TQM5LJEL66l 3YoYR7ovF74Uuzz2kkEZuyW9npsf0aQRK/sy8+XPv3oDd0o6NnBSn+uS1vxwF7nW6NkO xJWnO/IwkEhc9kr+QNYSaziAANvIfu4neZa9ambuxmYSsnKiA5BqNV8Q3leijxhliWj8 EvyFhiadCuBqBHcf55AE89z6i5G3F4Bsmo8CAeqbp8jSE9Egg5uS3ICBMVLj/YzDRVoF ECFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MHi+EK7a; spf=pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w21si3730678ior.60.2021.08.01.22.14.03; Sun, 01 Aug 2021 22:14:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MHi+EK7a; spf=pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232240AbhHBFOL (ORCPT + 17 others); Mon, 2 Aug 2021 01:14:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232211AbhHBFOK (ORCPT ); Mon, 2 Aug 2021 01:14:10 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57C67C06175F for ; Sun, 1 Aug 2021 22:14:01 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id u9-20020a17090a1f09b029017554809f35so29793540pja.5 for ; Sun, 01 Aug 2021 22:14:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=y3jqjblyF+bNujjzoE4Dt1sYtyoNDw930jBhejpyDsQ=; b=MHi+EK7adrpO/F23uzLcoFSgWDsz4wjsWR5IPfheS7GzkIfS/CEtozyCFzE7GjSZrE wYpqO99ar3MIgEnVHUsdAc2hARx4ciq/oHBs4q0Q8kSr4GoeXWoNuoNqExSOWG2+ywn+ hEcUFQjkQTpitrcK0O7Jh6EasK6Qkq57lzvpiYL4cQUJ0k5HEr5JQlLliHdoJ815pSet E2x0Vv1PD/iHoGTPfLtChceDmTXaJRFidxuJG4dgDCzyjLk/zh01CDh7QhzmM5QSnuHj ol1bNFY6JdyKqVtVK6ttsN8DBTxixwq48IEnS0oHyi3g/43mmRb7cIVcoiX3C2TxMfqh 3WBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y3jqjblyF+bNujjzoE4Dt1sYtyoNDw930jBhejpyDsQ=; b=EIbuMHhIh4SyuTdsRYvekqoxEk5sH8tWOYrW3CewOWXDMLk4moGxnSvXx370DLcThV 7YBwmB3RdD8bilIIpsJCFM0bKUSOT+gwnSMqk2gClxrtAY3z3bh5S6XVMo9X0nrZfYuF ds/+8F4t5P4efDl0/auQ+jUdKr+2Evstr3Vf2FeDxYBcZz6XNo5eLt4GFVa/PNw7vx1r QRci+4WqhKIcRPlmgi8yOwbRFck+5U/Jxp/j7fHsu3CAx2FDjj+7PseRfYoVqpo2GfHG O3QvrVfTxRYzO+n0W+YZNCMy+km1x1mNg2FFtPPemBM3+6H6e0ZbQbf8CKNR1C19gak4 faRA== X-Gm-Message-State: AOAM530JPa7AwoiedghPFN2AD7LeD6cre5UybDYb7Wd8y9zfTFJlJUKI AXhLpCAtypPG+DMYoze0DJ8b X-Received: by 2002:a17:902:b116:b029:12b:84fa:8c70 with SMTP id q22-20020a170902b116b029012b84fa8c70mr12736550plr.40.1627881240898; Sun, 01 Aug 2021 22:14:00 -0700 (PDT) Received: from localhost.localdomain ([2409:4072:6e99:242f:6391:b1b4:1ad8:fbdf]) by smtp.gmail.com with ESMTPSA id x26sm9947000pfm.77.2021.08.01.22.13.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Aug 2021 22:14:00 -0700 (PDT) From: Manivannan Sadhasivam To: gregkh@linuxfoundation.org Cc: hemantk@codeaurora.org, bbhatt@codeaurora.org, linux-arm-msm@vger.kernel.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org, loic.poulain@linaro.org, Jeffrey Hugo , Manivannan Sadhasivam Subject: [PATCH 10/10] bus: mhi: core: Improve debug messages for power up Date: Mon, 2 Aug 2021 10:42:55 +0530 Message-Id: <20210802051255.5771-11-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210802051255.5771-1-manivannan.sadhasivam@linaro.org> References: <20210802051255.5771-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org From: Bhaumik Bhatt Improve error message to be more descriptive if a failure occurs with an invalid power up execution environment. Additionally, add a debug log to print the execution environment and MHI state before a power up is attempted to confirm if the device is in an expected state. This helps clarify reasons for power up failures such as the device being found in a PBL or Emergency Download Mode execution environment and the host expected a full power up with Pass-Through and no image loading involved. Signed-off-by: Bhaumik Bhatt Reviewed-by: Hemant Kumar Reviewed-by: Jeffrey Hugo Reviewed-by: Manivannan Sadhasivam Link: https://lore.kernel.org/r/1620072038-36160-1-git-send-email-bbhatt@codeaurora.org Signed-off-by: Manivannan Sadhasivam --- drivers/bus/mhi/core/pm.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c index ff7cdc8653ef..fb99e3727155 100644 --- a/drivers/bus/mhi/core/pm.c +++ b/drivers/bus/mhi/core/pm.c @@ -1069,12 +1069,16 @@ int mhi_async_power_up(struct mhi_controller *mhi_cntrl) /* Confirm that the device is in valid exec env */ if (!MHI_IN_PBL(current_ee) && current_ee != MHI_EE_AMSS) { - dev_err(dev, "Not a valid EE for power on\n"); + dev_err(dev, "%s is not a valid EE for power on\n", + TO_MHI_EXEC_STR(current_ee)); ret = -EIO; goto error_async_power_up; } state = mhi_get_mhi_state(mhi_cntrl); + dev_dbg(dev, "Attempting power on with EE: %s, state: %s\n", + TO_MHI_EXEC_STR(current_ee), TO_MHI_STATE_STR(state)); + if (state == MHI_STATE_SYS_ERR) { mhi_set_mhi_state(mhi_cntrl, MHI_STATE_RESET); ret = wait_event_timeout(mhi_cntrl->state_event,