diff mbox series

[2/6] bus: mhi: ep: Check if the channel is supported by the controller

Message ID 20221228161704.255268-3-manivannan.sadhasivam@linaro.org
State Accepted
Commit 6de4941c0215ac1ea54918ace695a28f4a5ca89b
Headers show
Series MHI EP fixes and improvements | expand

Commit Message

Manivannan Sadhasivam Dec. 28, 2022, 4:17 p.m. UTC 
Before processing the command ring for the channel, check if the channel is
supported by the controller or not.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 drivers/bus/mhi/ep/main.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Jeffrey Hugo Jan. 5, 2023, 4:11 a.m. UTC | #1 
On 12/28/2022 9:17 AM, Manivannan Sadhasivam wrote:
> Before processing the command ring for the channel, check if the channel is
> supported by the controller or not.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
diff mbox series

Patch

diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c
index 55209d42a995..8b065a3cc848 100644
--- a/drivers/bus/mhi/ep/main.c
+++ b/drivers/bus/mhi/ep/main.c
@@ -123,6 +123,13 @@  static int mhi_ep_process_cmd_ring(struct mhi_ep_ring *ring, struct mhi_ring_ele
 	int ret;
 
 	ch_id = MHI_TRE_GET_CMD_CHID(el);
+
+	/* Check if the channel is supported by the controller */
+	if ((ch_id > mhi_cntrl->max_chan) || !mhi_cntrl->mhi_chan[ch_id].name) {
+		dev_err(dev, "Channel (%u) not supported!\n", ch_id);
+		return -ENODEV;
+	}
+
 	mhi_chan = &mhi_cntrl->mhi_chan[ch_id];
 	ch_ring = &mhi_cntrl->mhi_chan[ch_id].ring;