From patchwork Thu Aug 10 08:09:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 712407 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63BBDC41513 for ; Thu, 10 Aug 2023 08:09:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233991AbjHJIJZ (ORCPT ); Thu, 10 Aug 2023 04:09:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233360AbjHJIJX (ORCPT ); Thu, 10 Aug 2023 04:09:23 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 400E8212E for ; Thu, 10 Aug 2023 01:09:19 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id 5b1f17b1804b1-3fe4b95c371so3196975e9.1 for ; Thu, 10 Aug 2023 01:09:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20221208.gappssmtp.com; s=20221208; t=1691654958; x=1692259758; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eZfHcD5iKH92nMGOtJsjwO8F6ScspW6SHo1XJSm0hk0=; b=GnussyPTIou8eprNZioYl3UmyJGVZQP8PfyJOLOPBK1CNKetnRc0vmVqo5N0gamois mDlyOKYcXpldli1Uf0D+1d6QD1Bjkvn+t29P7/IKGJ5ETzI9dkVfatfMJOps9XPx0jFn ufMMCcxwL6cyG5Y5/4YEBlV3p+OMOxSUoYvboqVTi8r8pYTZT7mQ3aY8B0bzTAbZNYLF Sr6yp7zjNz83J09XXwaAp7Yvu60uZHInHTD8H7p8+rcwtLwhX0n+xvsqnq3tRxvfGGGV cIATdwKoJP0CyLQTkmM3WrCBWEpFGFYMz7yGqYCxAdF9d5deCSgf7oZCn7n9x03K8Fu5 WGSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691654958; x=1692259758; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eZfHcD5iKH92nMGOtJsjwO8F6ScspW6SHo1XJSm0hk0=; b=Jbsg14lrIRZoyVqs1eldW2DAoVgoVYvP6yNmQKQbwwVNg8xTxzU3rxY4rdWZZpxaib eHXOnZ0t7Z2cM/uhRVqcXlnwVzRkQ2j7VJCN+SZd89KXMPw1YrfYz9+W9D/f2cZ+NOcS 7Q3vwUu9+Lm8cM7qDb3c/SnMWTL2T+EV0yTv3Twf9UNlctyoy1aVhy+f0NzkLkvAOHs9 nBQA3NEv71a0PIKSeVP6ONJ1kLXz/X4gRPybVdMADp0NY2N3O3Ah5llOEhhB/fGqImPf E29InYzM1NAnZeuLz1w8QotDp8kUxsPyuK/Yzg5Em1Ftf1CZWGKXLVYLLU5YXEVHQbfO bizA== X-Gm-Message-State: AOJu0YzULKfYGGgmNUkxchXwNAa8lcDrsov1NsJosAiC+Td8jopOezUH rVZ0rjweY7IO6AKrhkXnIP5jaQ== X-Google-Smtp-Source: AGHT+IGIa8oSvb3iGBVIroJMvJcCqmcdtRG4qeQaivBsqa9/Ce15p1oaQ2VrL0P69NEdqF95toUoaQ== X-Received: by 2002:a05:600c:285:b0:3fb:af9a:bf30 with SMTP id 5-20020a05600c028500b003fbaf9abf30mr968467wmk.2.1691654957797; Thu, 10 Aug 2023 01:09:17 -0700 (PDT) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:74d3:226a:31b3:454c]) by smtp.gmail.com with ESMTPSA id y10-20020a1c4b0a000000b003fe2f3a89d4sm1321790wma.7.2023.08.10.01.09.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 01:09:17 -0700 (PDT) From: Bartosz Golaszewski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alex Elder , Srini Kandagatla , Andrew Halaney Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v3 4/9] arm64: dts: qcom: sa8775p-ride: move the reset-gpios property of the PHY Date: Thu, 10 Aug 2023 10:09:04 +0200 Message-Id: <20230810080909.6259-5-brgl@bgdev.pl> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230810080909.6259-1-brgl@bgdev.pl> References: <20230810080909.6259-1-brgl@bgdev.pl> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org From: Bartosz Golaszewski Device-tree bindings for MDIO define per-PHY reset-gpios as well as a global reset-gpios property at the MDIO node level which controls all devices on the bus. The latter is most likely a workaround for the chicken-and-egg problem where we cannot read the ID of the PHY before bringing it out of reset but we cannot bring it out of reset until we've read its ID. I have proposed a comprehensive solution for this problem in 2020 but it never got upstream. We do however have workaround in place which allows us to hard-code the PHY id in the compatible property, thus skipping the ID scanning. Let's make the device-tree for sa8775p-ride slightly more correct by moving the reset-gpios property to the PHY node with its ID put into the PHY node's compatible. Link: https://lore.kernel.org/all/20200622093744.13685-1-brgl@bgdev.pl/ Signed-off-by: Bartosz Golaszewski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts index 09ae6e153282..a03a4c17c8f0 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts @@ -279,13 +279,13 @@ mdio { #address-cells = <1>; #size-cells = <0>; - reset-gpios = <&pmm8654au_2_gpios 8 GPIO_ACTIVE_LOW>; - reset-delay-us = <11000>; - reset-post-delay-us = <70000>; - sgmii_phy: phy@8 { + compatible = "ethernet-phy-id0141.0dd4"; reg = <0x8>; device_type = "ethernet-phy"; + reset-gpios = <&pmm8654au_2_gpios 8 GPIO_ACTIVE_LOW>; + reset-assert-us = <11000>; + reset-deassert-us = <70000>; }; };