| Message ID | 20250415-msm8916-console-pinctrl-v1-4-a1d33ea994b9@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: msm8916/39: Cleanup/fix UART console pinctrl | expand |
On 4/15/25 3:52 PM, Stephan Gerhold wrote: > The Motorola MSM8916-based smartphones all use UART1 with 2 pins (TX, RX) > as debug UART console, so make use of the new &blsp_uart1_console_default > template. This applies the needed bias-pull-up to avoid garbage input, > bootph-all for U-Boot and avoids having to override the UART pins. > > Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org> > --- > arch/arm64/boot/dts/qcom/msm8916-motorola-common.dtsi | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916-motorola-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-motorola-common.dtsi > index 48134e5ff524fd5708db7b9c3a567ec3f751868c..4e202e7ed7db1921f347ca8b4a01ccec593a8d8e 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916-motorola-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916-motorola-common.dtsi > @@ -69,8 +69,8 @@ rmi4-f11@11 { > }; > > &blsp_uart1 { > - pinctrl-0 = <&blsp_uart1_default>; > - pinctrl-1 = <&blsp_uart1_sleep>; > + pinctrl-0 = <&blsp_uart1_console_default>; > + pinctrl-1 = <&blsp_uart1_console_sleep>; > pinctrl-names = "default", "sleep"; > status = "okay"; > }; > @@ -132,14 +132,6 @@ &wcnss_mem { > status = "okay"; > }; > > -/* CTS/RTX are not used */ Yeah, no raytracing here Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Konrad
diff --git a/arch/arm64/boot/dts/qcom/msm8916-motorola-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-motorola-common.dtsi index 48134e5ff524fd5708db7b9c3a567ec3f751868c..4e202e7ed7db1921f347ca8b4a01ccec593a8d8e 100644 --- a/arch/arm64/boot/dts/qcom/msm8916-motorola-common.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8916-motorola-common.dtsi @@ -69,8 +69,8 @@ rmi4-f11@11 { }; &blsp_uart1 { - pinctrl-0 = <&blsp_uart1_default>; - pinctrl-1 = <&blsp_uart1_sleep>; + pinctrl-0 = <&blsp_uart1_console_default>; + pinctrl-1 = <&blsp_uart1_console_sleep>; pinctrl-names = "default", "sleep"; status = "okay"; }; @@ -132,14 +132,6 @@ &wcnss_mem { status = "okay"; }; -/* CTS/RTX are not used */ -&blsp_uart1_default { - pins = "gpio0", "gpio1"; -}; -&blsp_uart1_sleep { - pins = "gpio0", "gpio1"; -}; - &tlmm { gpio_keys_default: gpio-keys-default-state { pins = "gpio107";
The Motorola MSM8916-based smartphones all use UART1 with 2 pins (TX, RX) as debug UART console, so make use of the new &blsp_uart1_console_default template. This applies the needed bias-pull-up to avoid garbage input, bootph-all for U-Boot and avoids having to override the UART pins. Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org> --- arch/arm64/boot/dts/qcom/msm8916-motorola-common.dtsi | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)