| Message ID | 20240331-module-owner-virtio-v2-0-98f04bfaf46a@linaro.org |
|---|---|
| Headers | show |
| Series | virtio: store owner from modules with register_virtio_driver() | expand |
Hi Krzysztof, On 31.03.2024 10:44, Krzysztof Kozlowski wrote: > virtio core already sets the .owner, so driver does not need to. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-by: Anton Yakovlev <anton.yakovlev@opensynergy.com> > --- > > Depends on the first patch. > --- > sound/virtio/virtio_card.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sound/virtio/virtio_card.c b/sound/virtio/virtio_card.c > index 2da20c625247..7805daea0102 100644 > --- a/sound/virtio/virtio_card.c > +++ b/sound/virtio/virtio_card.c > @@ -438,7 +438,6 @@ static unsigned int features[] = { > > static struct virtio_driver virtsnd_driver = { > .driver.name = KBUILD_MODNAME, > - .driver.owner = THIS_MODULE, > .id_table = id_table, > .feature_table = features, > .feature_table_size = ARRAY_SIZE(features), >
On Sun, Mar 31, 2024 at 10:44:06AM +0200, Krzysztof Kozlowski wrote: > virtio core already sets the .owner, so driver does not need to. > > Acked-by: Stefano Garzarella <sgarzare@redhat.com> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > > Depends on the first patch. > --- > net/vmw_vsock/virtio_transport.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
On Sun, Mar 31, 2024 at 10:44:10AM +0200, Krzysztof Kozlowski wrote: > virtio core already sets the .owner, so driver does not need to. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Depends on the first patch. > --- > drivers/scsi/virtio_scsi.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
On 31/03/2024 10:43, Krzysztof Kozlowski wrote: > Changes in v2: > - Three new patches: virtio mem+input+balloon > - Minor commit msg adjustments > - Add tags > - Link to v1: https://lore.kernel.org/r/20240327-module-owner-virtio-v1-0-0feffab77d99@linaro.org > > Merging > ======= > All further patches depend on the first virtio patch, therefore please ack > and this should go via one tree: maybe virtio? Michael, Jason, Xuan, Will you be able to take the entire patchset through virtio? Best regards, Krzysztof
On Wed, Apr 10, 2024 at 09:41:57AM +0200, Krzysztof Kozlowski wrote: > On 31/03/2024 10:43, Krzysztof Kozlowski wrote: > > Changes in v2: > > - Three new patches: virtio mem+input+balloon > > - Minor commit msg adjustments > > - Add tags > > - Link to v1: https://lore.kernel.org/r/20240327-module-owner-virtio-v1-0-0feffab77d99@linaro.org > > > > Merging > > ======= > > All further patches depend on the first virtio patch, therefore please ack > > and this should go via one tree: maybe virtio? > > Michael, Jason, Xuan, > > Will you be able to take the entire patchset through virtio? > > Best regards, > Krzysztof Hello! Yes I intend to take it for the next merge window. I am also merging the 1st patch for this release (it's a bugfix).
Changes in v2: - Three new patches: virtio mem+input+balloon - Minor commit msg adjustments - Add tags - Link to v1: https://lore.kernel.org/r/20240327-module-owner-virtio-v1-0-0feffab77d99@linaro.org Merging ======= All further patches depend on the first virtio patch, therefore please ack and this should go via one tree: maybe virtio? Description =========== Modules registering driver with register_virtio_driver() often forget to set .owner field. Solve the problem by moving this task away from the drivers to the core virtio code, just like we did for platform_driver in commit 9447057eaff8 ("platform_device: use a macro instead of platform_driver_register"). Best regards, Krzysztof --- Krzysztof Kozlowski (25): virtio: store owner from modules with register_virtio_driver() virtio: balloon: drop owner assignment virtio: input: drop owner assignment virtio: mem: drop owner assignment um: virt-pci: drop owner assignment virtio_blk: drop owner assignment bluetooth: virtio: drop owner assignment hwrng: virtio: drop owner assignment virtio_console: drop owner assignment crypto: virtio - drop owner assignment firmware: arm_scmi: virtio: drop owner assignment gpio: virtio: drop owner assignment drm/virtio: drop owner assignment iommu: virtio: drop owner assignment misc: nsm: drop owner assignment net: caif: virtio: drop owner assignment net: virtio: drop owner assignment net: 9p: virtio: drop owner assignment vsock/virtio: drop owner assignment wifi: mac80211_hwsim: drop owner assignment nvdimm: virtio_pmem: drop owner assignment rpmsg: virtio: drop owner assignment scsi: virtio: drop owner assignment fuse: virtio: drop owner assignment sound: virtio: drop owner assignment Documentation/driver-api/virtio/writing_virtio_drivers.rst | 1 - arch/um/drivers/virt-pci.c | 1 - drivers/block/virtio_blk.c | 1 - drivers/bluetooth/virtio_bt.c | 1 - drivers/char/hw_random/virtio-rng.c | 1 - drivers/char/virtio_console.c | 2 -- drivers/crypto/virtio/virtio_crypto_core.c | 1 - drivers/firmware/arm_scmi/virtio.c | 1 - drivers/gpio/gpio-virtio.c | 1 - drivers/gpu/drm/virtio/virtgpu_drv.c | 1 - drivers/iommu/virtio-iommu.c | 1 - drivers/misc/nsm.c | 1 - drivers/net/caif/caif_virtio.c | 1 - drivers/net/virtio_net.c | 1 - drivers/net/wireless/virtual/mac80211_hwsim.c | 1 - drivers/nvdimm/virtio_pmem.c | 1 - drivers/rpmsg/virtio_rpmsg_bus.c | 1 - drivers/scsi/virtio_scsi.c | 1 - drivers/virtio/virtio.c | 6 ++++-- drivers/virtio/virtio_balloon.c | 1 - drivers/virtio/virtio_input.c | 1 - drivers/virtio/virtio_mem.c | 1 - fs/fuse/virtio_fs.c | 1 - include/linux/virtio.h | 7 +++++-- net/9p/trans_virtio.c | 1 - net/vmw_vsock/virtio_transport.c | 1 - sound/virtio/virtio_card.c | 1 - 27 files changed, 9 insertions(+), 30 deletions(-) --- base-commit: 7fdcff3312e16ba8d1419f8a18f465c5cc235ecf change-id: 20240327-module-owner-virtio-546763b3ca22 Best regards,