mbox series

[BlueZ,v9,0/3] ASHA plugin

Message ID 20240610223601.378127-1-arun@asymptotic.io
Headers show
Series ASHA plugin | expand

Message

Arun Raghavan June 10, 2024, 10:35 p.m. UTC
Hello again,
Here's v9 of the ASHA plugin patchset. Changes include:

  * Switch to btio API to connect socket -- this makes the connection
    async, so we don't tie up the mainloop for longer/erroneous
    connections
  * Minor fixups based on CI/lint
  * Trivial gitignore changes are already merged

Cheers,
Arun

Arun Raghavan (3):
  src/shared: Add initial implementation for an ASHA profile
  profiles/audio: Add an ASHA plugin
  test: Add a script to test ASHA

 Makefile.am                |   3 +-
 Makefile.plugins           |   5 +
 configure.ac               |   4 +
 lib/uuid.h                 |   3 +
 profiles/audio/asha.c      | 524 +++++++++++++++++++++++++++++++++++++
 profiles/audio/asha.h      |  38 +++
 profiles/audio/media.c     |  30 +++
 profiles/audio/media.h     |   2 +
 profiles/audio/transport.c | 201 +++++++++++++-
 src/shared/asha.c          | 360 +++++++++++++++++++++++++
 src/shared/asha.h          |  63 +++++
 test/simple-asha           | 166 ++++++++++++
 12 files changed, 1396 insertions(+), 3 deletions(-)
 create mode 100644 profiles/audio/asha.c
 create mode 100644 profiles/audio/asha.h
 create mode 100644 src/shared/asha.c
 create mode 100644 src/shared/asha.h
 create mode 100755 test/simple-asha

Comments

Paul Menzel June 11, 2024, 5:44 a.m. UTC | #1
Dear Arun,


Thank you very much for working on this.


Am 11.06.24 um 00:35 schrieb Arun Raghavan:
> Hello again,
> Here's v9 of the ASHA plugin patchset. Changes include:
> 
>    * Switch to btio API to connect socket -- this makes the connection
>      async, so we don't tie up the mainloop for longer/erroneous
>      connections
>    * Minor fixups based on CI/lint
>    * Trivial gitignore changes are already merged

Could you add a tag

Resolves: https://github.com/bluez/bluez/issues/481

and maybe elaborate, where the spec can be found, how this can be 
tested, and with what devices you tested this?


Thank you again and kind regards,

Paul
Arun Raghavan June 12, 2024, 4:23 p.m. UTC | #2
Hi Paul!

On Tue, 11 Jun 2024 at 01:45, Paul Menzel <pmenzel@molgen.mpg.de> wrote:
[...]
>
> Could you add a tag
>
> Resolves: https://github.com/bluez/bluez/issues/481

Done.

> and maybe elaborate, where the spec can be found, how this can be
> tested, and with what devices you tested this?

Also done, v10 is en route now with these details in the cover letter.

Thanks for the feedback!
Arun