mbox series

[v2,0/3] crypto: scompress - defer allocation of percpu scratch buffers

Message ID 20170721154238.21697-1-ard.biesheuvel@linaro.org
Headers show
Series crypto: scompress - defer allocation of percpu scratch buffers | expand

Message

Ard Biesheuvel July 21, 2017, 3:42 p.m. UTC
This is a followup to 'crypto: scompress - eliminate percpu scratch buffers',
which attempted to replace the scompress per-CPU buffer entirely, but as
Herbert pointed out, this is not going to fly in the targeted use cases.

Instead, move the alloc/free of the buffers into the tfm init/exit hooks,
so that we only have the per-CPU buffers allocated if their are any
acomp ciphers of the right kind (i.e, ones that encapsulate a synchronous
implementation) in use (#3)

Patches #1 and #2 are fixes for issues I spotted when working on this code.

Ard Biesheuvel (3):
  crypto: scompress - don't sleep with preemption disabled
  crypto: scompress - free partially allocated scratch buffers on
    failure
  crypto: scompress - defer allocation of scratch buffer to first use

 crypto/scompress.c | 55 ++++++++------------
 1 file changed, 22 insertions(+), 33 deletions(-)

-- 
2.11.0

Comments

Herbert Xu Aug. 3, 2017, 6:24 a.m. UTC | #1
On Fri, Jul 21, 2017 at 04:42:35PM +0100, Ard Biesheuvel wrote:
> This is a followup to 'crypto: scompress - eliminate percpu scratch buffers',

> which attempted to replace the scompress per-CPU buffer entirely, but as

> Herbert pointed out, this is not going to fly in the targeted use cases.

> 

> Instead, move the alloc/free of the buffers into the tfm init/exit hooks,

> so that we only have the per-CPU buffers allocated if their are any

> acomp ciphers of the right kind (i.e, ones that encapsulate a synchronous

> implementation) in use (#3)

> 

> Patches #1 and #2 are fixes for issues I spotted when working on this code.

> 

> Ard Biesheuvel (3):

>   crypto: scompress - don't sleep with preemption disabled

>   crypto: scompress - free partially allocated scratch buffers on

>     failure

>   crypto: scompress - defer allocation of scratch buffer to first use


All patches applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt