| Message ID | 20190125084915.25411-1-ard.biesheuvel@linaro.org |
|---|---|
| Headers | show |
| Series | crypto: fix crct10dif for ARM and arm64 | expand |
On Fri, Jan 25, 2019 at 09:49:11AM +0100, Ard Biesheuvel wrote: > Fix the issues in both NEON implementations of the CRC-T10DIF routines, > that were reported by Eric's new testing code. > > v2: > - keep alignment specifiers where possible (#1) > - clarify/fix commit log (#2) > - add fixes/cc-stable/etc tags > - add patches that drop the now unreacheable code (#3 - #4) > > Ard Biesheuvel (4): > crypto: arm/crct10dif - revert to C code for short inputs > crypto: arm64/crct10dif - revert to C code for short inputs > crypto: arm/crct10dif - remove dead code > crypto: arm64/crct10dif - remove dead code > > arch/arm/crypto/crct10dif-ce-core.S | 27 +++++--------------- > arch/arm/crypto/crct10dif-ce-glue.c | 23 +++++------------ > arch/arm64/crypto/crct10dif-ce-core.S | 11 -------- > arch/arm64/crypto/crct10dif-ce-glue.c | 25 +++++------------- > 4 files changed, 19 insertions(+), 67 deletions(-) > In the commit message of patches 1-2, "more than 16 bytes" should be "at least 16 bytes". Otherwise for all 4 patches: Reviewed-by: Eric Biggers <ebiggers@kernel.org> - Eric
On Sun, 27 Jan 2019 at 01:07, Eric Biggers <ebiggers@kernel.org> wrote: > > On Fri, Jan 25, 2019 at 09:49:11AM +0100, Ard Biesheuvel wrote: > > Fix the issues in both NEON implementations of the CRC-T10DIF routines, > > that were reported by Eric's new testing code. > > > > v2: > > - keep alignment specifiers where possible (#1) > > - clarify/fix commit log (#2) > > - add fixes/cc-stable/etc tags > > - add patches that drop the now unreacheable code (#3 - #4) > > > > Ard Biesheuvel (4): > > crypto: arm/crct10dif - revert to C code for short inputs > > crypto: arm64/crct10dif - revert to C code for short inputs > > crypto: arm/crct10dif - remove dead code > > crypto: arm64/crct10dif - remove dead code > > > > arch/arm/crypto/crct10dif-ce-core.S | 27 +++++--------------- > > arch/arm/crypto/crct10dif-ce-glue.c | 23 +++++------------ > > arch/arm64/crypto/crct10dif-ce-core.S | 11 -------- > > arch/arm64/crypto/crct10dif-ce-glue.c | 25 +++++------------- > > 4 files changed, 19 insertions(+), 67 deletions(-) > > > > In the commit message of patches 1-2, "more than 16 bytes" should be > "at least 16 bytes". > > Otherwise for all 4 patches: > > Reviewed-by: Eric Biggers <ebiggers@kernel.org> > Thanks Eric. I'll update and resend.