| Message ID | 20220709211849.210850-1-ebiggers@kernel.org |
|---|---|
| Headers | show |
| Series | crypto: make the sha1 library optional | expand |
On Sat, Jul 09, 2022 at 02:18:48PM -0700, Eric Biggers wrote: > From: Eric Biggers <ebiggers@google.com> > > SHA-1 is a crypto algorithm (or at least was intended to be -- it's not > considered secure anymore), so move it out of the top-level library > directory and into lib/crypto/. > > Signed-off-by: Eric Biggers <ebiggers@google.com> Thanks for this. Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>
Eric Biggers <ebiggers@kernel.org> wrote: > This series makes it possible to build the kernel without SHA-1 support, > although for now this is only possible in minimal configurations, due to > the uses of SHA-1 in the networking subsystem. > > Eric Biggers (2): > crypto: move lib/sha1.c into lib/crypto/ > crypto: make the sha1 library optional > > crypto/Kconfig | 1 + > init/Kconfig | 1 + > lib/Makefile | 2 +- > lib/crypto/Kconfig | 3 +++ > lib/crypto/Makefile | 3 +++ > lib/{ => crypto}/sha1.c | 0 > net/ipv6/Kconfig | 1 + > 7 files changed, 10 insertions(+), 1 deletion(-) > rename lib/{ => crypto}/sha1.c (100%) > > > base-commit: 79e6e2f3f3ff345947075341781e900e4f70db81 All applied. Thanks.
On 7/15/22 01:50, Herbert Xu wrote: > Eric Biggers <ebiggers@kernel.org> wrote: >> This series makes it possible to build the kernel without SHA-1 support, >> although for now this is only possible in minimal configurations, due to >> the uses of SHA-1 in the networking subsystem. >> >> Eric Biggers (2): >> crypto: move lib/sha1.c into lib/crypto/ >> crypto: make the sha1 library optional >> >> crypto/Kconfig | 1 + >> init/Kconfig | 1 + >> lib/Makefile | 2 +- >> lib/crypto/Kconfig | 3 +++ >> lib/crypto/Makefile | 3 +++ >> lib/{ => crypto}/sha1.c | 0 >> net/ipv6/Kconfig | 1 + >> 7 files changed, 10 insertions(+), 1 deletion(-) >> rename lib/{ => crypto}/sha1.c (100%) >> >> >> base-commit: 79e6e2f3f3ff345947075341781e900e4f70db81 > > All applied. Thanks. Eric, linux-next-20220718 has a build error: ERROR: modpost: missing MODULE_LICENSE() in lib/crypto/libsha1.o
On Mon, Jul 18, 2022 at 10:49:07AM -0700, Randy Dunlap wrote: > > > On 7/15/22 01:50, Herbert Xu wrote: > > Eric Biggers <ebiggers@kernel.org> wrote: > >> This series makes it possible to build the kernel without SHA-1 support, > >> although for now this is only possible in minimal configurations, due to > >> the uses of SHA-1 in the networking subsystem. > >> > >> Eric Biggers (2): > >> crypto: move lib/sha1.c into lib/crypto/ > >> crypto: make the sha1 library optional > >> > >> crypto/Kconfig | 1 + > >> init/Kconfig | 1 + > >> lib/Makefile | 2 +- > >> lib/crypto/Kconfig | 3 +++ > >> lib/crypto/Makefile | 3 +++ > >> lib/{ => crypto}/sha1.c | 0 > >> net/ipv6/Kconfig | 1 + > >> 7 files changed, 10 insertions(+), 1 deletion(-) > >> rename lib/{ => crypto}/sha1.c (100%) > >> > >> > >> base-commit: 79e6e2f3f3ff345947075341781e900e4f70db81 > > > > All applied. Thanks. > > Eric, > linux-next-20220718 has a build error: > > ERROR: modpost: missing MODULE_LICENSE() in lib/crypto/libsha1.o Thanks, https://lore.kernel.org/r/20220719030415.32113-1-ebiggers@kernel.org fixes this. - Eric
This series makes it possible to build the kernel without SHA-1 support, although for now this is only possible in minimal configurations, due to the uses of SHA-1 in the networking subsystem. Eric Biggers (2): crypto: move lib/sha1.c into lib/crypto/ crypto: make the sha1 library optional crypto/Kconfig | 1 + init/Kconfig | 1 + lib/Makefile | 2 +- lib/crypto/Kconfig | 3 +++ lib/crypto/Makefile | 3 +++ lib/{ => crypto}/sha1.c | 0 net/ipv6/Kconfig | 1 + 7 files changed, 10 insertions(+), 1 deletion(-) rename lib/{ => crypto}/sha1.c (100%) base-commit: 79e6e2f3f3ff345947075341781e900e4f70db81