mbox series

[RESEND,0/2] crypto: qat - unmap buffers before free

Message ID 20230605210607.7185-1-giovanni.cabiddu@intel.com
Headers show
Series crypto: qat - unmap buffers before free | expand

Message

Giovanni Cabiddu June 5, 2023, 9:06 p.m. UTC 
The callbacks functions for RSA and DH free the memory allocated for the
source and destination buffers before unmapping it.
This sequence is not correct.

Change the cleanup sequence to unmap the buffers before freeing them.

Resending adding Reviewed-by Andy got from an internal review.

Hareshx Sankar Raj (2):
  crypto: qat - unmap buffer before free for DH
  crypto: qat - unmap buffers before free for RSA

 .../crypto/intel/qat/qat_common/qat_asym_algs.c    | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

Comments

Herbert Xu June 16, 2023, 12:32 p.m. UTC | #1 
On Mon, Jun 05, 2023 at 10:06:05PM +0100, Giovanni Cabiddu wrote:
> The callbacks functions for RSA and DH free the memory allocated for the
> source and destination buffers before unmapping it.
> This sequence is not correct.
> 
> Change the cleanup sequence to unmap the buffers before freeing them.
> 
> Resending adding Reviewed-by Andy got from an internal review.
> 
> Hareshx Sankar Raj (2):
>   crypto: qat - unmap buffer before free for DH
>   crypto: qat - unmap buffers before free for RSA
> 
>  .../crypto/intel/qat/qat_common/qat_asym_algs.c    | 14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)
> 
> -- 
> 2.40.1

All applied.  Thanks.