Message ID | 20240110201216.18016-1-avromanov@salutedevices.com |
---|---|
Headers | show |
Series | Support more Amlogic SoC families in crypto driver | expand |
On 10/01/2024 21:11, Alexey Romanov wrote: > This patch adds a crypto node declaration. With the > Amlogic crypto driver we can use HW implementation > of SHA1/224/256 and AES algo. > > Signed-off-by: Alexey Romanov <avromanov@salutedevices.com> > --- > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > index cf150f568335..879e0ce0b2ea 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > @@ -653,6 +653,14 @@ sd_emmc: sd@10000 { > power-domains = <&pwrc PWRC_SD_EMMC_ID>; > status = "disabled"; > }; > + > + crypto: crypto@6000 { > + compatible = "amlogic,g12a-crypto"; > + reg = <0x0 0x6000 0x0 0x48>; > + interrupts = <GIC_SPI 120 IRQ_TYPE_EDGE_RISING>; > + power-domains = <&pwrc PWRC_DMA_ID>; > + status = "disabled"; Why disabled ? Usually we always leave the embedded HW enabled by default. The comment is valid for the other dtsi changes, Neil > + }; > }; > > usb: usb@fe004400 {
Hello! On Wed, Jan 10, 2024 at 10:08:15PM +0100, Corentin Labbe wrote: > Le Wed, Jan 10, 2024 at 11:11:16PM +0300, Alexey Romanov a 'ecrit : > > Hello! > > > > This patchset expand the funcionality of the Amlogic > > crypto driver by adding support for more SoC families: > > AXG, G12A, G12B, SM1, A1, S4. > > > > Also specify and enable crypto node in device tree > > for reference Amlogic devices. > > > > Tested on AXG, G12A/B, SM1, A1 and S4 devices via > > custom tests and trcypt module. > > Hello > > Thanks for your patch series. > Unfortunatly, I fail to apply it for testing on top of linux-next. > On top of which tree did you have tested ? We use 6.5-rc3. > According to patch 01, you used a tree based before "crypto: amlogic - Use new crypto_engine_op interface" so too old. Will rebase over linux-next in v2. > > Regards
On 11/01/2024 10:29, Krzysztof Kozlowski wrote: > On 11/01/2024 10:18, Alexey Romanov wrote: >> Hello! >> >> On Wed, Jan 10, 2024 at 10:08:15PM +0100, Corentin Labbe wrote: >>> Le Wed, Jan 10, 2024 at 11:11:16PM +0300, Alexey Romanov a 'ecrit : >>>> Hello! >>>> >>>> This patchset expand the funcionality of the Amlogic >>>> crypto driver by adding support for more SoC families: >>>> AXG, G12A, G12B, SM1, A1, S4. >>>> >>>> Also specify and enable crypto node in device tree >>>> for reference Amlogic devices. >>>> >>>> Tested on AXG, G12A/B, SM1, A1 and S4 devices via >>>> custom tests and trcypt module. >>> >>> Hello >>> >>> Thanks for your patch series. >>> Unfortunatly, I fail to apply it for testing on top of linux-next. >>> On top of which tree did you have tested ? >> >> We use 6.5-rc3. > > Don't develop on old trees... I mean, internally you can do whatever you > wish, but don't work upstream on such trees. Number of email bounces also prove the point: you did not Cc right people due to work on some ancient files. Best regards, Krzysztof