From patchwork Tue Sep 3 16:43:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 172863 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp98964ily; Tue, 3 Sep 2019 09:43:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqxkvHT7eR5GxfjYxtBuZQRwk0/VJq7uYE6GvaePTCZnvu07e3JH0xkNM2ccWopxULdsR5rf X-Received: by 2002:a17:90a:b108:: with SMTP id z8mr224767pjq.108.1567529030798; Tue, 03 Sep 2019 09:43:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567529030; cv=none; d=google.com; s=arc-20160816; b=qnwA+u+2RwN07VJsjKDfcD3NHoavWUXL+ejtEor+jMJqBCBVeqqcO45mKPlOesgNMw eEYX6/Yv1uOOXdCL3xl1XXyu+WH9un1TJzobp7PGKXfJ8KIFdkRsel6Ph12Uqo/6+Pza dgqGzHMaMtjMpavRTIPA1n5fysNDpJXA2hjG3x+VAsnPqNmViVQ09SCTdnacPMyZlq9y JbKZydlzHEKNO4U5S0mZDKyARMU0mhLUAEM46V+aNBMz0HUF7HrqYMjx7cVhjteQdUX2 YYOfXmn00IxhtM2RAoGGt/dJUVYyNKIUtNAbe7Xq/WEHy6kRBmZXAerkiVRsx4i79p3W HYhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=aI11eOfvUHWceFRi+8iF4u67GyVnjyFicxzOIJeHmqs=; b=Oib1jwdc2ho7Q/Z3xmY3pTehnXNSZlYcGz01oRhdWEV0dMDZI/IVvPUw85wFzv70ci tUXXxzCdZlfjP6hnuEk7xuFVjDKPzMl//0d/Sq5vv0MKYXHGjIm/cTvLCXOQDtZ5bEg4 uUS6mknpUslcFPySaf89G6Z13bLQ2XmZl5EJUGdGvD5URs1ZVtk+mZcTQq//ewnImOMx wJQfQ+lwZtQ6vc6puIfyrq9iz3M3X5Mc6t8ISJE09hRD+wxx295/vvFWkggix2B3f4uq adVjhFDYx8ip5+KtAMjShahnK6OEgn0SlNWQdWNyHlx4PI2dIUlIarlGIgJaPphiTE8O bGIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Seh3SnO7; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i8si14716735pgs.87.2019.09.03.09.43.50; Tue, 03 Sep 2019 09:43:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Seh3SnO7; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730087AbfICQnu (ORCPT + 3 others); Tue, 3 Sep 2019 12:43:50 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:40400 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730080AbfICQnt (ORCPT ); Tue, 3 Sep 2019 12:43:49 -0400 Received: by mail-pl1-f195.google.com with SMTP id y10so2212266pll.7 for ; Tue, 03 Sep 2019 09:43:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=aI11eOfvUHWceFRi+8iF4u67GyVnjyFicxzOIJeHmqs=; b=Seh3SnO7oiwdT24476RxHEDvAApEq55bf0yH1t/nmi12tYD+r2wdiyZUIw5lLTgxw5 nImaN4v64wqOcsGJjjuJLbYLCiLLd9G+viS+G8F9QVD/cnn9odNSCzhicQwuRbrvCPqN 5Z+mdw1MUcw2+c4AUQcubUfDMAfv2EqqBkhDzKz3Z/q7/GqmJSB2xtkea7HgtvHx5q2R ftc8C5c6EKIFwqyPL+OUD8frAZmld6nc9L7ojMJ6hd0LO0YxTLdaMnrDEQKslwBwZlmB yMYPQ3prX685iew4wa4l4X4PKRsv9vub9L/JHNKTUHd+boTHyYjIFs4VWbejkNf5xSPB jxEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=aI11eOfvUHWceFRi+8iF4u67GyVnjyFicxzOIJeHmqs=; b=H1md8dSpqbeVObkxBI0HoCyd/quSXKMcLd2mPpKBOLovqyJULNM+DtqGNEYNsaYtYB uFH0ZFfKnd1sCukoHgroXXY6GnZiN5NZmMQQJyL/lR3S1aBDRslB/M3gtla0E6atAj8w R9cLwnmXi+wJdw+eSErUyiX3+FBFGik7/cBUljOO7VnD7t/kuZ9AcWh6RjvZxmY9JWMz ewNotF79TENmwz0rz7yWVoxzgQL/WE6SJYWw53A4Ytolg9oMTVQk7fewVWxuiXcShwys UBtRvffq+E85y90vQY4IAMA3ymCXT9V0PeTiHWcxBeGYoIZC5MvzTtU+6jP20mBI605f Za7g== X-Gm-Message-State: APjAAAXQIhfMYcY6/Qh65C7n1wJ7DUouWIRXmJWhwd5COjtVMFlZt3Ek n50VXv3SGKvsu/LwudRj0MdD9ek6H2ifK/pl X-Received: by 2002:a17:902:166:: with SMTP id 93mr19789458plb.320.1567529028847; Tue, 03 Sep 2019 09:43:48 -0700 (PDT) Received: from e111045-lin.nice.arm.com ([104.133.8.102]) by smtp.gmail.com with ESMTPSA id b126sm20311847pfb.110.2019.09.03.09.43.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2019 09:43:48 -0700 (PDT) From: Ard Biesheuvel To: linux-crypto@vger.kernel.org Cc: herbert@gondor.apana.org.au, ebiggers@kernel.org, Ard Biesheuvel Subject: [PATCH v2 04/17] crypto: arm/aes-ce - replace tweak mask literal with composition Date: Tue, 3 Sep 2019 09:43:26 -0700 Message-Id: <20190903164339.27984-5-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190903164339.27984-1-ard.biesheuvel@linaro.org> References: <20190903164339.27984-1-ard.biesheuvel@linaro.org> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Replace the vector load from memory sequence with a simple instruction sequence to compose the tweak vector directly. Signed-off-by: Ard Biesheuvel --- arch/arm/crypto/aes-ce-core.S | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) -- 2.17.1 diff --git a/arch/arm/crypto/aes-ce-core.S b/arch/arm/crypto/aes-ce-core.S index a3ca4ac2d7bb..bb6ec1844370 100644 --- a/arch/arm/crypto/aes-ce-core.S +++ b/arch/arm/crypto/aes-ce-core.S @@ -382,13 +382,10 @@ ENDPROC(ce_aes_ctr_encrypt) veor \out, \out, \tmp .endm - .align 3 -.Lxts_mul_x: - .quad 1, 0x87 - ce_aes_xts_init: - vldr d30, .Lxts_mul_x - vldr d31, .Lxts_mul_x + 8 + vmov.i32 d30, #0x87 @ compose tweak mask vector + vmovl.u32 q15, d30 + vshr.u64 d30, d31, #7 ldrd r4, r5, [sp, #16] @ load args ldr r6, [sp, #28]