diff mbox series

[15/20] crypto: caam: caamalg_qi2: Supply a couple of 'fallback' related descriptions

Message ID 20210204111000.2800436-16-lee.jones@linaro.org
State New
Headers show
Series Rid W=1 warnings in Crypto | expand

Commit Message

Lee Jones Feb. 4, 2021, 11:09 a.m. UTC
Fixes the following W=1 kernel build warning(s):

 drivers/crypto/caam/caamalg_qi2.c:87: warning: Function parameter or member 'xts_key_fallback' not described in 'caam_ctx'
 drivers/crypto/caam/caamalg_qi2.c:87: warning: Function parameter or member 'fallback' not described in 'caam_ctx'

Cc: "Horia Geantă" <horia.geanta@nxp.com>
Cc: Aymen Sghaier <aymen.sghaier@nxp.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/crypto/caam/caamalg_qi2.c | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.25.1

Comments

Horia Geanta Feb. 8, 2021, 7:49 p.m. UTC | #1
On 2/4/2021 1:10 PM, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):

> 

>  drivers/crypto/caam/caamalg_qi2.c:87: warning: Function parameter or member 'xts_key_fallback' not described in 'caam_ctx'

>  drivers/crypto/caam/caamalg_qi2.c:87: warning: Function parameter or member 'fallback' not described in 'caam_ctx'

> 

> Cc: "Horia Geantă" <horia.geanta@nxp.com>

> Cc: Aymen Sghaier <aymen.sghaier@nxp.com>

> Cc: Herbert Xu <herbert@gondor.apana.org.au>

> Cc: "David S. Miller" <davem@davemloft.net>

> Cc: linux-crypto@vger.kernel.org

> Signed-off-by: Lee Jones <lee.jones@linaro.org>

> ---

>  drivers/crypto/caam/caamalg_qi2.c | 2 ++

>  1 file changed, 2 insertions(+)

> 

> diff --git a/drivers/crypto/caam/caamalg_qi2.c b/drivers/crypto/caam/caamalg_qi2.c

> index a780e627838ae..22e45c5bf2023 100644

> --- a/drivers/crypto/caam/caamalg_qi2.c

> +++ b/drivers/crypto/caam/caamalg_qi2.c

> @@ -71,6 +71,8 @@ struct caam_skcipher_alg {

>   * @adata: authentication algorithm details

>   * @cdata: encryption algorithm details

>   * @authsize: authentication tag (a.k.a. ICV / MAC) size

> + * @xts_key_fallback: whether to set the fallback key

true if fallback tfm needs to be used due to unsupported xts key lengths.

> + * @fallback: the fallback key

xts fallback tfm

Horia
diff mbox series

Patch

diff --git a/drivers/crypto/caam/caamalg_qi2.c b/drivers/crypto/caam/caamalg_qi2.c
index a780e627838ae..22e45c5bf2023 100644
--- a/drivers/crypto/caam/caamalg_qi2.c
+++ b/drivers/crypto/caam/caamalg_qi2.c
@@ -71,6 +71,8 @@  struct caam_skcipher_alg {
  * @adata: authentication algorithm details
  * @cdata: encryption algorithm details
  * @authsize: authentication tag (a.k.a. ICV / MAC) size
+ * @xts_key_fallback: whether to set the fallback key
+ * @fallback: the fallback key
  */
 struct caam_ctx {
 	struct caam_flc flc[NUM_OP];