diff mbox series

[05/10] crypto: keembay: ocs-hcu: Fix incorrectly named functions/structs

Message ID 20210303143449.3170813-6-lee.jones@linaro.org
State Superseded
Headers show
Series Rid W=1 warnings in Crypto | expand

Commit Message

Lee Jones March 3, 2021, 2:34 p.m. UTC
Fixes the following W=1 kernel build warning(s):

 drivers/crypto/keembay/ocs-hcu.c:107: warning: expecting prototype for struct ocs_hcu_dma_list. Prototype was for struct ocs_hcu_dma_entry instead
 drivers/crypto/keembay/ocs-hcu.c:127: warning: expecting prototype for struct ocs_dma_list. Prototype was for struct ocs_hcu_dma_list instead
 drivers/crypto/keembay/ocs-hcu.c:610: warning: expecting prototype for ocs_hcu_digest(). Prototype was for ocs_hcu_hash_update() instead
 drivers/crypto/keembay/ocs-hcu.c:648: warning: expecting prototype for ocs_hcu_hash_final(). Prototype was for ocs_hcu_hash_finup() instead

Cc: Daniele Alessandrelli <daniele.alessandrelli@intel.com>
Cc: Declan Murphy <declan.murphy@intel.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/crypto/keembay/ocs-hcu.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.27.0

Comments

Alessandrelli, Daniele March 4, 2021, 12:02 p.m. UTC | #1
Hi Lee,

Thanks for the patch.

On Wed, 2021-03-03 at 14:34 +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):

> 

>  drivers/crypto/keembay/ocs-hcu.c:107: warning: expecting prototype for struct ocs_hcu_dma_list. Prototype was for struct ocs_hcu_dma_entry instead

>  drivers/crypto/keembay/ocs-hcu.c:127: warning: expecting prototype for struct ocs_dma_list. Prototype was for struct ocs_hcu_dma_list instead


I don't see the fix for this in the diff. Am I missing something?

>  drivers/crypto/keembay/ocs-hcu.c:610: warning: expecting prototype for ocs_hcu_digest(). Prototype was for ocs_hcu_hash_update() instead

>  drivers/crypto/keembay/ocs-hcu.c:648: warning: expecting prototype for ocs_hcu_hash_final(). Prototype was for ocs_hcu_hash_finup() instead

> 

> Cc: Daniele Alessandrelli <daniele.alessandrelli@intel.com>

> Cc: Declan Murphy <declan.murphy@intel.com>

> Cc: Herbert Xu <herbert@gondor.apana.org.au>

> Cc: "David S. Miller" <davem@davemloft.net>

> Cc: linux-crypto@vger.kernel.org

> Signed-off-by: Lee Jones <lee.jones@linaro.org>

> ---

>  drivers/crypto/keembay/ocs-hcu.c | 6 +++---

>  1 file changed, 3 insertions(+), 3 deletions(-)

> 

> diff --git a/drivers/crypto/keembay/ocs-hcu.c b/drivers/crypto/keembay/ocs-hcu.c

> index 81eecacf603ad..d522757855fb0 100644

> --- a/drivers/crypto/keembay/ocs-hcu.c

> +++ b/drivers/crypto/keembay/ocs-hcu.c

> @@ -93,7 +93,7 @@

>  #define OCS_HCU_WAIT_BUSY_TIMEOUT_US		1000000

>  

>  /**

> - * struct ocs_hcu_dma_list - An entry in an OCS DMA linked list.

> + * struct ocs_hcu_dma_entry - An entry in an OCS DMA linked list.

>   * @src_addr:  Source address of the data.

>   * @src_len:   Length of data to be fetched.

>   * @nxt_desc:  Next descriptor to fetch.

> @@ -597,7 +597,7 @@ int ocs_hcu_hash_init(struct ocs_hcu_hash_ctx *ctx, enum ocs_hcu_algo algo)

>  }

>  

>  /**

> - * ocs_hcu_digest() - Perform a hashing iteration.

> + * ocs_hcu_hash_update() - Perform a hashing iteration.

>   * @hcu_dev:	The OCS HCU device to use.

>   * @ctx:	The OCS HCU hashing context.

>   * @dma_list:	The OCS DMA list mapping the input data to process.

> @@ -632,7 +632,7 @@ int ocs_hcu_hash_update(struct ocs_hcu_dev *hcu_dev,

>  }

>  

>  /**

> - * ocs_hcu_hash_final() - Update and finalize hash computation.

> + * ocs_hcu_hash_finup() - Update and finalize hash computation.

>   * @hcu_dev:	The OCS HCU device to use.

>   * @ctx:	The OCS HCU hashing context.

>   * @dma_list:	The OCS DMA list mapping the input data to process.
diff mbox series

Patch

diff --git a/drivers/crypto/keembay/ocs-hcu.c b/drivers/crypto/keembay/ocs-hcu.c
index 81eecacf603ad..d522757855fb0 100644
--- a/drivers/crypto/keembay/ocs-hcu.c
+++ b/drivers/crypto/keembay/ocs-hcu.c
@@ -93,7 +93,7 @@ 
 #define OCS_HCU_WAIT_BUSY_TIMEOUT_US		1000000
 
 /**
- * struct ocs_hcu_dma_list - An entry in an OCS DMA linked list.
+ * struct ocs_hcu_dma_entry - An entry in an OCS DMA linked list.
  * @src_addr:  Source address of the data.
  * @src_len:   Length of data to be fetched.
  * @nxt_desc:  Next descriptor to fetch.
@@ -597,7 +597,7 @@  int ocs_hcu_hash_init(struct ocs_hcu_hash_ctx *ctx, enum ocs_hcu_algo algo)
 }
 
 /**
- * ocs_hcu_digest() - Perform a hashing iteration.
+ * ocs_hcu_hash_update() - Perform a hashing iteration.
  * @hcu_dev:	The OCS HCU device to use.
  * @ctx:	The OCS HCU hashing context.
  * @dma_list:	The OCS DMA list mapping the input data to process.
@@ -632,7 +632,7 @@  int ocs_hcu_hash_update(struct ocs_hcu_dev *hcu_dev,
 }
 
 /**
- * ocs_hcu_hash_final() - Update and finalize hash computation.
+ * ocs_hcu_hash_finup() - Update and finalize hash computation.
  * @hcu_dev:	The OCS HCU device to use.
  * @ctx:	The OCS HCU hashing context.
  * @dma_list:	The OCS DMA list mapping the input data to process.