mbox series

[v2,0/4] k3dma: add support to reserved channels

Message ID 20180706035521.13736-1-guodong.xu@linaro.org
Headers show
Series k3dma: add support to reserved channels | expand

Message

Guodong Xu July 6, 2018, 3:55 a.m. UTC 
This patchset fixes bug people found on hikey960 when allocating DMA
channels to peripherals such as SPI. It fails because the channel is
reserved and not accessible by kernel.

Patch 1, 2 and 3 add support to reserved channels for K3 DMA. Patch 4
includes a removal of axi_config who controls DMA secure/non-secure
access permission but is actually set in early stage by bootloader.

Guodong Xu (1):
  arm64: dts: hi3660: update property name hisilicon,dma-min-chan

Li Yu (3):
  dt-bindings: k3dma: add optional property hisilicon,dma-min-chan
  k3dma: add support to reserved minimum channels
  k3dma: delete axi_config

 Documentation/devicetree/bindings/dma/k3dma.txt |  6 ++++++
 arch/arm64/boot/dts/hisilicon/hi3660.dtsi       |  2 +-
 drivers/dma/k3dma.c                             | 16 ++++++++--------
 3 files changed, 15 insertions(+), 9 deletions(-)

-- 
2.17.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Rob Herring July 11, 2018, 4:09 p.m. UTC | #1 
On Mon, Jul 09, 2018 at 04:04:38PM +0530, Vinod wrote:
> On 06-07-18, 11:55, Guodong Xu wrote:

> > From: Li Yu <liyu65@hisilicon.com>

> > 

> > Add optional property hisilicon,dma-min-chan for k3dma.

> > 

> > Signed-off-by: Li Yu <liyu65@hisilicon.com>

> > Signed-off-by: Guodong Xu <guodong.xu@linaro.org>

> > ---

> >  Documentation/devicetree/bindings/dma/k3dma.txt | 6 ++++++

> >  1 file changed, 6 insertions(+)

> > 

> > diff --git a/Documentation/devicetree/bindings/dma/k3dma.txt b/Documentation/devicetree/bindings/dma/k3dma.txt

> > index 4945aeac4dc4..f34202a80f3c 100644

> > --- a/Documentation/devicetree/bindings/dma/k3dma.txt

> > +++ b/Documentation/devicetree/bindings/dma/k3dma.txt

> > @@ -12,6 +12,11 @@ Required properties:

> >  		have specific request line

> >  - clocks: clock required

> >  

> > +Optional properties:

> > +- hisilicon,dma-min-chan: the minimum DMA channel number which is usable

> > +		Default value is 0, but in some platform it is

> > +		configured 1, like in hi3660 platform

> > +

> >  Example:

> >  

> >  Controller:

> > @@ -21,6 +26,7 @@ Controller:

> >  			#dma-cells = <1>;

> >  			dma-channels = <16>;

> >  			dma-requests = <27>;

> > +			hisilicon,dma-min-chan = <1>;

> 

> Am still expecting this to be a mask


If so calling it 'min' doesn't make sense. And a mask should have 'mask' 
in the name.

Rob
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html