mbox series

[v4,0/3] dmaengine: bindings/edma: dma-channel-mask to array

Message ID 20190930114055.29315-1-peter.ujfalusi@ti.com
Headers show
Series dmaengine: bindings/edma: dma-channel-mask to array | expand

Message

Peter Ujfalusi Sept. 30, 2019, 11:40 a.m. UTC
Hi,

Changes since v3:
- Update the dma-common.yaml and edma binding documentation according to Rob's
  suggestion

Changes since v2:
- Fix dma-common.yaml documentation patch and extend the description of the
  dma-channel-mask array
- The edma documentation now includes information on the dma-channel-mask array
  size for EDMAs with 32 or 64 channels

Changes since v1:
- Extend the common dma-channel-mask to uint32-array to be usable for
  controllers with more than 32 channels
- Use the dma-channel-mask instead custom property for available channels for
  EDMA.

The original patch was part of the EDMA multicore usage series.

Rob: I'm not sure if I got the dma-common.yaml update correctly...

EDMAs can have 32 or 64 channels depending on the SoC, the dma-channel-mask
needs to be an array to be usable for the driver.

Regards,
Peter
---
Peter Ujfalusi (3):
  dt-bindings: dmaengine: dma-common: Change dma-channel-mask to
    uint32-array
  dt-bindings: dma: ti-edma: Document dma-channel-mask for EDMA
  dmaengine: ti: edma: Add support for handling reserved channels

 .../devicetree/bindings/dma/dma-common.yaml   |  9 ++-
 .../devicetree/bindings/dma/ti-edma.txt       |  8 +++
 drivers/dma/ti/edma.c                         | 59 +++++++++++++++++--
 3 files changed, 69 insertions(+), 7 deletions(-)

-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Comments

Rob Herring (Arm) Oct. 1, 2019, 1:40 p.m. UTC | #1
On Mon, 30 Sep 2019 14:40:53 +0300, Peter Ujfalusi wrote:
> Make the dma-channel-mask to be usable for controllers with more than 32

> channels.

> 

> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> ---

>  Documentation/devicetree/bindings/dma/dma-common.yaml | 9 ++++++++-

>  1 file changed, 8 insertions(+), 1 deletion(-)

> 


Reviewed-by: Rob Herring <robh@kernel.org>
Rob Herring (Arm) Oct. 1, 2019, 1:40 p.m. UTC | #2
On Mon, 30 Sep 2019 14:40:54 +0300, Peter Ujfalusi wrote:
> Similarly to paRAM slots, channels can be used by other cores.

> 

> The common dma-channel-mask property can be used for specifying the

> available channels.

> 

> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> ---

>  Documentation/devicetree/bindings/dma/ti-edma.txt | 8 ++++++++

>  1 file changed, 8 insertions(+)

> 


Reviewed-by: Rob Herring <robh@kernel.org>
Vinod Koul Nov. 5, 2019, 4:51 p.m. UTC | #3
On 30-09-19, 14:40, Peter Ujfalusi wrote:
> Hi,

> 

> Changes since v3:

> - Update the dma-common.yaml and edma binding documentation according to Rob's

>   suggestion

> 

> Changes since v2:

> - Fix dma-common.yaml documentation patch and extend the description of the

>   dma-channel-mask array

> - The edma documentation now includes information on the dma-channel-mask array

>   size for EDMAs with 32 or 64 channels

> 

> Changes since v1:

> - Extend the common dma-channel-mask to uint32-array to be usable for

>   controllers with more than 32 channels

> - Use the dma-channel-mask instead custom property for available channels for

>   EDMA.

> 

> The original patch was part of the EDMA multicore usage series.

> 

> Rob: I'm not sure if I got the dma-common.yaml update correctly...

> 

> EDMAs can have 32 or 64 channels depending on the SoC, the dma-channel-mask

> needs to be an array to be usable for the driver.


Applied, thanks

There was a conflict on patch3, I have reolved it, please check.

-- 
~Vinod