mbox series

[v2,0/2] arm64: dts: ti: k3-j721e: MMC/SD higher speed modes support

Message ID 20201127201024.64836-1-nsekhar@ti.com
Headers show
Series arm64: dts: ti: k3-j721e: MMC/SD higher speed modes support | expand

Message

Sekhar Nori Nov. 27, 2020, 8:10 p.m. UTC
Hi,

This is repost of Faiz's patches adding higher speed modes
for J721E, originally posted here:'

https://lore.kernel.org/lkml/20201001190541.6364-1-faiz_abbas@ti.com/

Dependencies are resolved now, and patches rebased to latest linux-next.

v2:
- rebased to latest linux-next
- fixed dtbs_check warning caused by improper states property in gpio
  regulator introduced in patch 2/2.

Faiz Abbas (2):
  arm64: dts: ti: k3-j721e-main: Add output tap delay values
  arm64: dts: ti: k3-j721e-common-proc-board: Add support SD card UHS
    modes

 .../dts/ti/k3-j721e-common-proc-board.dts     | 35 ++++++++++++++++++-
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi     | 22 +++++++++---
 2 files changed, 51 insertions(+), 6 deletions(-)

Comments

Nishanth Menon Nov. 28, 2020, 4:41 p.m. UTC | #1
On 01:40-20201128, Sekhar Nori wrote:
[...]

> -	main_usbss0_pins_default: main-usbss0-pins-default {

> +	vdd_sd_dv_alt_pins_default: vdd_sd_dv_alt_pins_default {

> +		pinctrl-single,pins = <

> +			J721E_IOPAD(0x1d8, PIN_INPUT, 7) /* (W4) SPI1_CS1.GPIO0_117 */

> +		>;

> +	};

> +

> +	main_usbss0_pins_default: main_usbss0_pins_default {


Could you not switch the node name to _ ? We just fixed that
bunch. Now, this patch introduces the following with W=2:
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts: /bus@100000/pinctrl@11c000/vdd_sd_dv_alt_pins_default: Character '_' not recommended in node name
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts: /bus@100000/pinctrl@11c000/main_usbss0_pins_default: Character '_' not recommended in node name


-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D