| Message ID | 20220923052828.16581-1-jianguo.zhang@mediatek.com |
|---|---|
| Headers | show |
| Series | Mediatek ethernet patches for mt8188 | expand |
Dear Krzysztof, Thanks for your comment. On Wed, 2022-09-28 at 09:17 +0200, Krzysztof Kozlowski wrote: > On 27/09/2022 12:44, AngeloGioacchino Del Regno wrote: > > > > > OTOH, as Angelo pointed out, handling old and new properties is > > > > quite > > > > easy to achieve, so... :) > > > > > > > > > > So, the conclusion is as following: > > > > > > 1. add new property 'snps,clk-csr' and document it in binding > > > file. > > > 2. parse new property 'snps,clk-csr' firstly, if failed, fall > > > back to > > > old property 'clk_csr' in driver. > > > > > > Is my understanding correct? > > > > Yes, please. > > > > I think that bindings should also get a 'clk_csr' with deprecated: > > true, > > but that's Krzysztof's call. > > The property was never documented, so I think we can skip it as > deprecated. > We will send next version patches according to the conclusion. > Best regards, > Krzysztof > BRS Jianguo
Changes in v5: v5: 1) Rename the property 'clk_csr' as 'snps,clk-csr' in binding file as Krzysztof Kozlowski'comment. 2) Add DTS patch 'arm64: dts: mediatek: mt2712e: Update the name of property 'clk_csr'' as Krzysztof Kozlowski'comment. 3) Add driver patch 'net: stmmac: Update the name of property 'clk_csr'' as Krzysztof Kozlowski'comment. v4: 1) Update the commit message of patch 'dt-bindings: net: snps,dwmac: add clk_csr property' as Krzysztof Kozlowski'comment. v3: 1) List the names of SoCs mt8188 and mt8195 in correct order as AngeloGioacchino Del Regno's comment. 2) Add patch version info as Krzysztof Kozlowski'comment. v2: 1) Delete patch 'stmmac: dwmac-mediatek: add support for mt8188' as Krzysztof Kozlowski's comment. 2) Update patch 'dt-bindings: net: mediatek-dwmac: add support for mt8188' as Krzysztof Kozlowski's comment. 3) Add clk_csr property to fix warning ('clk_csr' was unexpected) when runnig 'make dtbs_check'. v1: 1) Add ethernet driver entry for mt8188. 2) Add binding document for ethernet on mt8188. Jianguo Zhang (4): dt-bindings: net: mediatek-dwmac: add support for mt8188 dt-bindings: net: snps,dwmac: add clk_csr property arm64: dts: mediatek: mt2712e: Update the name of property 'clk_csr' net: stmmac: Update the name of property 'clk_csr' .../devicetree/bindings/net/mediatek-dwmac.yaml | 10 ++++++++-- Documentation/devicetree/bindings/net/snps,dwmac.yaml | 5 +++++ arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 2 +- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +- 4 files changed, 15 insertions(+), 4 deletions(-)