| Message ID | 20230222203847.2664903-1-colin.foster@in-advantage.com |
|---|---|
| Headers | show |
| Series | add support for Phytec PCM-049 and PCM-959 | expand |
On 2/22/23 2:38 PM, Colin Foster wrote: > Add yaml documentation for TI OMAP devices for the Phytec PCM-049 SoM and > the Phytec PCM-959 development kit. > > Signed-off-by: Colin Foster <colin.foster@in-advantage.com> > --- > > v4 > * New patch, based on a WIP from Andrew Davis <afd@ti.com> > > --- > .../devicetree/bindings/arm/ti,omap.yaml | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/ti,omap.yaml How will this work if I add the same file? Why not take my WIP patch, make the suggested changes from Rob, then have it as your first patch in this series? Andrew > > diff --git a/Documentation/devicetree/bindings/arm/ti,omap.yaml b/Documentation/devicetree/bindings/arm/ti,omap.yaml > new file mode 100644 > index 000000000000..9c0e08f74fee > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/ti,omap.yaml > @@ -0,0 +1,29 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/ti,omap.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments OMAP SoC architecture > + > +maintainers: > + - Tony Lindgren <tony@atomide.com> > + > +description: > + Platforms based on Texas Instruments OMAP SoC architecture. > + > +properties: > + $nodename: > + const: '/' > + compatibnle: > + oneOf: > + > + - description: TI OMAP 4460 SoC based platforms > + items: > + - enum: > + - phytec,pcm049 # Phytec OMAP 4460 SoM > + - phytec,pcm959 # Phytec development board for the pcm049 > + - const: ti,omap4460 > + - const: ti,omap4 > + > +additionalProperties: true
On Thu, Feb 23, 2023 at 10:00:50AM -0600, Andrew Davis wrote: > On 2/22/23 2:38 PM, Colin Foster wrote: > > Add yaml documentation for TI OMAP devices for the Phytec PCM-049 SoM and > > the Phytec PCM-959 development kit. > > > > Signed-off-by: Colin Foster <colin.foster@in-advantage.com> > > --- > > > > v4 > > * New patch, based on a WIP from Andrew Davis <afd@ti.com> > > > > --- > > .../devicetree/bindings/arm/ti,omap.yaml | 29 +++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/arm/ti,omap.yaml > > How will this work if I add the same file? Why not take my WIP patch, make > the suggested changes from Rob, then have it as your first patch in this > series? Is your WIP intended to convert all omap.txt to ti,omap.yaml? Or chunk off devices one at a time? If the former, when your patch is done it should be a pretty simple rebase conflict resolution. If the latter (which feels more digestable) this offers that template. This was Rob's / Tony's suggestion, albeit before you sent your patch set. Anyway, I'm happy to do any of the following: 1. Take Andrew's patches, add these references and re-submit. 2. Keep this set as-is (with the typo fix) and when Andrew's WIP is done it should be an easy rebase before submission. 3. Wait for Andrew's WIP to be done, then submit with this update. I'd like to avoid #3 because I don't know where this might fall on your priorities list.
On 2/23/23 10:25 AM, Colin Foster wrote: > On Thu, Feb 23, 2023 at 10:00:50AM -0600, Andrew Davis wrote: >> On 2/22/23 2:38 PM, Colin Foster wrote: >>> Add yaml documentation for TI OMAP devices for the Phytec PCM-049 SoM and >>> the Phytec PCM-959 development kit. >>> >>> Signed-off-by: Colin Foster <colin.foster@in-advantage.com> >>> --- >>> >>> v4 >>> * New patch, based on a WIP from Andrew Davis <afd@ti.com> >>> >>> --- >>> .../devicetree/bindings/arm/ti,omap.yaml | 29 +++++++++++++++++++ >>> 1 file changed, 29 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/arm/ti,omap.yaml >> >> How will this work if I add the same file? Why not take my WIP patch, make >> the suggested changes from Rob, then have it as your first patch in this >> series? > > Is your WIP intended to convert all omap.txt to ti,omap.yaml? Or chunk > off devices one at a time? > > If the former, when your patch is done it should be a pretty simple > rebase conflict resolution. If the latter (which feels more digestable) > this offers that template. This was Rob's / Tony's suggestion, albeit > before you sent your patch set. > > > Anyway, I'm happy to do any of the following: > > 1. Take Andrew's patches, add these references and re-submit. > 2. Keep this set as-is (with the typo fix) and when Andrew's WIP is done > it should be an easy rebase before submission. > 3. Wait for Andrew's WIP to be done, then submit with this update. > > > I'd like to avoid #3 because I don't know where this might fall on your > priorities list. Low priority for me, I'd suggest #1 or they probably will not be converted anytime soon. Andrew
On Thu, Feb 23, 2023 at 08:25:08AM -0800, Colin Foster wrote: > On Thu, Feb 23, 2023 at 10:00:50AM -0600, Andrew Davis wrote: > > On 2/22/23 2:38 PM, Colin Foster wrote: > > > Add yaml documentation for TI OMAP devices for the Phytec PCM-049 SoM and > > > the Phytec PCM-959 development kit. > > > > > > Signed-off-by: Colin Foster <colin.foster@in-advantage.com> > > > --- > > > > > > v4 > > > * New patch, based on a WIP from Andrew Davis <afd@ti.com> > > > > > > --- > > > .../devicetree/bindings/arm/ti,omap.yaml | 29 +++++++++++++++++++ > > > 1 file changed, 29 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/arm/ti,omap.yaml > > > > How will this work if I add the same file? Why not take my WIP patch, make > > the suggested changes from Rob, then have it as your first patch in this > > series? > > Is your WIP intended to convert all omap.txt to ti,omap.yaml? Or chunk > off devices one at a time? > > If the former, when your patch is done it should be a pretty simple > rebase conflict resolution. If the latter (which feels more digestable) > this offers that template. This was Rob's / Tony's suggestion, albeit > before you sent your patch set. > > > Anyway, I'm happy to do any of the following: > > 1. Take Andrew's patches, add these references and re-submit. > 2. Keep this set as-is (with the typo fix) and when Andrew's WIP is done > it should be an easy rebase before submission. > 3. Wait for Andrew's WIP to be done, then submit with this update. > > > I'd like to avoid #3 because I don't know where this might fall on your > priorities list. If you are willing to do #1, that's certainly my preference. Rob
As should be clear for the title and patch title, this is adding initial support for the OMAP 4460 SOM and dev kit for Phytec's PCM959 evaluation kit. The PCM049 is a legacy SOM offered by Phytec: https://www.phytec.com/legacy-soms/ There was a vendor BSP offered by Phytec, but that never entered the Device Tree era. This patch is meant to change that. My development bootloader has moved to U-Boot, but I have verified Barebox works in the past. When booting from SD card, either bootloader should work. When booting from Barebox, the NAND OOB layout is incompatible between the bootloader and the kernel. I haven't had any OOB / ECC errors in the NAND at all, which was my main concern. Due to that, I'm submitting this as a patch instead of an RFC. Hardware ECC correction seems to be fully functional. v3->v4 * Add initial .yaml documentation instead of omap.txt Thanks to Andrew Davis <afd@ti.com> for posting their WIP patch set, which was the basis for patch 1, with Rob's feedback. * Removed Rob's "Acked-by" because the patch is completely different * Removed unnecessary "omap-4430" from compatible in .dts v2->v3 * Acked-by on patch 1 * Code review changes (see patch 2 for details) * Fix intermittent NAND failures (patch 2) v1->v2 * Almost everything moved into the SOM (PCM-049) .dtsi. Only the LED chip is dev-board specific. * Fix pinmux associations (*pmx_core was applying *pmx_wkup entries... I'm surprised that didn't cause more issues) * Documentation added * Updates from review: * Board compatible strings added * Hyphen / underscore changes * Remove unnecessary status="okay" entries * Generic names used (regulator, led-1, etc.) Colin Foster (2): dt-bindings: arm: omap: add phytec pcm-049 som and pcm-959 dev board arm: dts: omap4: pcm959: add initial support for phytec pcm959 .../devicetree/bindings/arm/ti,omap.yaml | 29 ++ arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/omap4-phytec-pcm-049.dtsi | 400 ++++++++++++++++++ arch/arm/boot/dts/omap4-phytec-pcm-959.dts | 48 +++ 4 files changed, 478 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/ti,omap.yaml create mode 100644 arch/arm/boot/dts/omap4-phytec-pcm-049.dtsi create mode 100644 arch/arm/boot/dts/omap4-phytec-pcm-959.dts