mbox series

[0/2] leds: aw2013: Add vdd regulator

Message ID 20230320141638.3378-1-linmengbo0689@protonmail.com
Headers show
Series leds: aw2013: Add vdd regulator | expand

Message

Lin, Meng-Bo March 20, 2023, 2:20 p.m. UTC 
Implement support for a "vdd" that is enabled by the aw2013 driver so that
the regulator gets enabled when needed.

Comments

Lee Jones March 30, 2023, 11:46 a.m. UTC | #1 
On Mon, 20 Mar 2023, Krzysztof Kozlowski wrote:

> On 20/03/2023 15:22, Lin, Meng-Bo wrote:
> > Document vdd-supply, a regulator providing power to the "VDD" pin.
> >
>
> No. This device does not have VDD pin. I checked in datasheet.

I'm confused.  This patch set much do something?

I guess a better commit message would help.  Let me request that.

--
Lee Jones [李琼斯]
Krzysztof Kozlowski March 30, 2023, 1:44 p.m. UTC | #2 
On 30/03/2023 13:46, Lee Jones wrote:
> On Mon, 20 Mar 2023, Krzysztof Kozlowski wrote:
> 
>> On 20/03/2023 15:22, Lin, Meng-Bo wrote:
>>> Document vdd-supply, a regulator providing power to the "VDD" pin.
>>>
>>
>> No. This device does not have VDD pin. I checked in datasheet.
> 
> I'm confused.  This patch set much do something?
> 
> I guess a better commit message would help.  Let me request that.

There was a v2 - with a discussion - so we wait for v3 which clearly
indicates this is supply on controller side. IMHO, this is still wrong
because it is controller's property, not device's, but Rob gave here
green light, so v3 with proper explanation would be fine.

Best regards,
Krzysztof