mbox series

[net-next,v4,00/12] Add EMAC3 support for sa8540p-ride

Message ID 20230411200409.455355-1-ahalaney@redhat.com
Headers show
Series Add EMAC3 support for sa8540p-ride | expand

Message

Andrew Halaney April 11, 2023, 8:03 p.m. UTC
This is a forward port / upstream refactor of code delivered
downstream by Qualcomm over at [0] to enable the DWMAC5 based
implementation called EMAC3 on the sa8540p-ride dev board.

Comments

Brian Masney April 12, 2023, 3:25 p.m. UTC | #1
On Tue, Apr 11, 2023 at 03:03:57PM -0500, Andrew Halaney wrote:
> This is a forward port / upstream refactor of code delivered
> downstream by Qualcomm over at [0] to enable the DWMAC5 based
> implementation called EMAC3 on the sa8540p-ride dev board.
> 
> From what I can tell with the board schematic in hand,
> as well as the code delivered, the main changes needed are:
> 
>     1. A new address space layout for dwmac5/EMAC3 MTL/DMA regs
>     2. A new programming sequence required for the EMAC3 based platforms
> 
> This series makes the changes above as well as other housekeeping items
> such as converting dt-bindings to yaml, etc.
> 
> As requested[1], it has been split up by compilation deps / maintainer tree.
> I will post a link to the associated devicetree changes that together
> with this series get the hardware functioning.
> 
> Patches 1-3 are clean ups of the currently supported dt-bindings and
> IMO could be picked up as is independent of the rest of the series to
> improve the current codebase. They've all been reviewed in prior
> versions of the series.
> 
> Patches 5-7 are also clean ups of the driver and are worth picking up
> independently as well. They don't all have explicit reviews but should
> be good to go (trivial changes on non-reviewed bits).
> 
> The rest of the patches have new changes, lack review, or are specificly
> being made to support the new hardware, so they should wait until the
> series as a whole is deemed ready to go by the community.

Looks good to me!

Tested-by: Brian Masney <bmasney@redhat.com>
patchwork-bot+netdevbpf@kernel.org April 13, 2023, 11:10 a.m. UTC | #2
Hello:

This series was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Tue, 11 Apr 2023 15:03:57 -0500 you wrote:
> This is a forward port / upstream refactor of code delivered
> downstream by Qualcomm over at [0] to enable the DWMAC5 based
> implementation called EMAC3 on the sa8540p-ride dev board.
> 
> From what I can tell with the board schematic in hand,
> as well as the code delivered, the main changes needed are:
> 
> [...]

Here is the summary with links:
  - [net-next,v4,01/12] dt-bindings: net: snps,dwmac: Update interrupt-names
    https://git.kernel.org/netdev/net-next/c/d554ba0ea03c
  - [net-next,v4,02/12] dt-bindings: net: snps,dwmac: Add Qualcomm Ethernet ETHQOS compatibles
    https://git.kernel.org/netdev/net-next/c/d70c215bdd17
  - [net-next,v4,03/12] dt-bindings: net: qcom,ethqos: Convert bindings to yaml
    https://git.kernel.org/netdev/net-next/c/02e98ce3db14
  - [net-next,v4,04/12] dt-bindings: net: qcom,ethqos: Add Qualcomm sc8280xp compatibles
    https://git.kernel.org/netdev/net-next/c/25926a703ec1
  - [net-next,v4,05/12] net: stmmac: Remove unnecessary if statement brackets
    https://git.kernel.org/netdev/net-next/c/7c6b942b81ca
  - [net-next,v4,06/12] net: stmmac: Fix DMA typo
    https://git.kernel.org/netdev/net-next/c/d638dcb52b09
  - [net-next,v4,07/12] net: stmmac: Remove some unnecessary void pointers
    https://git.kernel.org/netdev/net-next/c/0c3f3c4f4b15
  - [net-next,v4,08/12] net: stmmac: Pass stmmac_priv in some callbacks
    https://git.kernel.org/netdev/net-next/c/1d84b487bc2d
  - [net-next,v4,09/12] net: stmmac: dwmac4: Allow platforms to specify some DMA/MTL offsets
    https://git.kernel.org/netdev/net-next/c/33719b57f52e
  - [net-next,v4,10/12] net: stmmac: dwmac-qcom-ethqos: Respect phy-mode and TX delay
    https://git.kernel.org/netdev/net-next/c/164a9ebe9742
  - [net-next,v4,11/12] net: stmmac: dwmac-qcom-ethqos: Use loopback_en for all speeds
    https://git.kernel.org/netdev/net-next/c/030f1d5972aa
  - [net-next,v4,12/12] net: stmmac: dwmac-qcom-ethqos: Add EMAC3 support
    https://git.kernel.org/netdev/net-next/c/b68376191c69

You are awesome, thank you!