mbox series

[v2,0/4] dt-bindings: power: reset: at91: convert to YAML

Message ID 20230524123528.439082-1-claudiu.beznea@microchip.com
Headers show
Series dt-bindings: power: reset: at91: convert to YAML | expand

Message

Claudiu Beznea May 24, 2023, 12:35 p.m. UTC
Hi,

Series convert AT91 shutdown controllers documentation to YAML.
Along with it device trees were updated and also entries to
MAINTAINERS with documentation files.

Thank you,
Claudiu

Changes in v2:
- use minimum, maximum on uint32 enums instead of all possible values
- change commit description for patch 3/4 to explain why there is a
  syscon along with microchip,sama7g5-shdwc
- remove | near description entries

Claudiu Beznea (4):
  ARM: dts: at91: use generic name for shutdown controller
  dt-bindings: power: reset: atmel,at91sam9260-shdwc: convert to yaml
  dt-bindings: power: reset: atmel,sama5d2-shdwc: convert to yaml
  MAINTAINERS: add documentation file for Microchip SAMA5D2 shutdown
    controller

 .../devicetree/bindings/arm/atmel-sysregs.txt |  94 --------------
 .../power/reset/atmel,at91sam9260-shdwc.yaml  |  82 +++++++++++++
 .../power/reset/atmel,sama5d2-shdwc.yaml      | 115 ++++++++++++++++++
 MAINTAINERS                                   |   1 +
 arch/arm/boot/dts/at91-qil_a9260.dts          |   2 +-
 arch/arm/boot/dts/at91-sama5d27_som1_ek.dts   |   2 +-
 arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts     |   2 +-
 arch/arm/boot/dts/at91-sama5d2_xplained.dts   |   2 +-
 arch/arm/boot/dts/at91sam9260.dtsi            |   2 +-
 arch/arm/boot/dts/at91sam9260ek.dts           |   2 +-
 arch/arm/boot/dts/at91sam9261.dtsi            |   2 +-
 arch/arm/boot/dts/at91sam9263.dtsi            |   2 +-
 arch/arm/boot/dts/at91sam9g20ek_common.dtsi   |   2 +-
 arch/arm/boot/dts/at91sam9g45.dtsi            |   2 +-
 arch/arm/boot/dts/at91sam9n12.dtsi            |   2 +-
 arch/arm/boot/dts/at91sam9rl.dtsi             |   2 +-
 arch/arm/boot/dts/at91sam9x5.dtsi             |   2 +-
 arch/arm/boot/dts/sam9x60.dtsi                |   2 +-
 arch/arm/boot/dts/sama5d2.dtsi                |   2 +-
 arch/arm/boot/dts/sama5d3.dtsi                |   2 +-
 arch/arm/boot/dts/sama5d4.dtsi                |   2 +-
 arch/arm/boot/dts/sama7g5.dtsi                |   2 +-
 arch/arm/boot/dts/usb_a9260.dts               |   2 +-
 arch/arm/boot/dts/usb_a9263.dts               |   2 +-
 24 files changed, 218 insertions(+), 114 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/power/reset/atmel,at91sam9260-shdwc.yaml
 create mode 100644 Documentation/devicetree/bindings/power/reset/atmel,sama5d2-shdwc.yaml

Comments

Krzysztof Kozlowski June 2, 2023, 2:56 p.m. UTC | #1
On 24/05/2023 14:35, Claudiu Beznea wrote:
> Convert Atmel shutdown controller to YAML.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---


> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - atmel,at91sam9260-shdwc
> +              - atmel,at91sam9rl-shdwc
> +    then:
> +      properties:
> +        atmel,wakeup-rtt-timer:
> +          description: enable real-time timer wake-up
> +          type: boolean

No, don't define properties in allOf.

> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - atmel,at91sam9rl-shdwc
> +              - atmel,at91sam9x5-shdwc
> +    then:
> +      properties:
> +        atmel,wakeup-rtc-timer:
> +          description: enable real-time clock wake-up
> +          type: boolean

Same problem.

> +
> +unevaluatedProperties: false

This should be additionalProperties: false.
> +
> +examples:
> +  - |
> +    shdwc: poweroff@fffffd10 {
> +        compatible = "atmel,at91sam9260-shdwc";
> +        reg = <0xfffffd10 0x10>;
> +        clocks = <&clk32k>;
> +    };
> +
> +...

Best regards,
Krzysztof