mbox series

[00/12] arm64: dts: qcom: correct UFS pad supply

Message ID 20230905161920.252013-1-krzysztof.kozlowski@linaro.org
Headers show
Series arm64: dts: qcom: correct UFS pad supply | expand

Message

Krzysztof Kozlowski Sept. 5, 2023, 4:19 p.m. UTC 
Hi,

Not tested on hardware.

Best regards,
Krzysztof

Krzysztof Kozlowski (12):
  arm64: dts: qcom: sm6125-sprout: drop incorrect UFS phy max current
  arm64: dts: qcom: sm6125-sprout: correct UFS pad supply
  arm64: dts: qcom: sm6115-pro1x: correct UFS pad supply
  arm64: dts: qcom: sm6115p-j606f: correct UFS pad supply
  arm64: dts: qcom: apq8096-db820c: correct UFS pad supply
  arm64: dts: qcom: msm8996-oneplus: correct UFS pad supply
  arm64: dts: qcom: msm8996-gemini: correct UFS pad supply
  arm64: dts: qcom: msm8998-pro1: correct UFS pad supply
  arm64: dts: qcom: msm8998-mtp: correct UFS pad supply
  arm64: dts: qcom: msm8998-oneplus: correct UFS pad supply
  arm64: dts: qcom: msm8998-sagit: correct UFS pad supply
  arm64: dts: qcom: sm4250-billie2: correct UFS pad supply

 arch/arm64/boot/dts/qcom/apq8096-db820c.dts              | 2 +-
 arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi     | 2 +-
 arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi      | 2 +-
 arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts          | 2 +-
 arch/arm64/boot/dts/qcom/msm8998-mtp.dts                 | 2 +-
 arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi     | 2 +-
 arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts        | 2 +-
 arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts      | 2 +-
 arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts          | 2 +-
 arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts        | 2 +-
 arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts | 4 +---
 11 files changed, 11 insertions(+), 13 deletions(-)

Comments

Konrad Dybcio Sept. 6, 2023, 9:43 a.m. UTC | #1 
On 5.09.2023 18:19, Krzysztof Kozlowski wrote:
> The Qualcomm UFS phy switched from dedicated driver to QMP phy driver.
> Eventually the old driver was removed in commit 02dca8c981b5 ("phy:
> qcom: remove ufs qmp phy driver").  The original driver and its binding
> used vddp-ref-clk regulator supply, but the new one did not and left the
> supply unused.
> 
> The Qualcomm UFS phy bindings were also migrated to newer ones and
> dropped support for vddp-ref-clk regulator in commit dc5cb63592bd
> ("dt-bindings: phy: migrate QMP UFS PHY bindings to
> qcom,sc8280xp-qmp-ufs-phy.yaml").
> 
> It turns out that this regulator, although with inaccurate name
> vddp-ref-clk, is actually needed to provide supply for VDD_PX10 (or
> similar, depending on the SoC) used by UFS controller.
> 
> Bring back handling of this supply by using more appropriate regulator -
> UFS controller host supply.  This also fixes dtbs_check warning:
> 
>   sm6115-fxtec-pro1x.dtb: phy@4807000: 'vddp-ref-clk-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
Konrad Dybcio Sept. 6, 2023, 9:43 a.m. UTC | #2 
On 5.09.2023 18:19, Krzysztof Kozlowski wrote:
> The Qualcomm UFS phy switched from dedicated driver to QMP phy driver.
> Eventually the old driver was removed in commit 02dca8c981b5 ("phy:
> qcom: remove ufs qmp phy driver").  The original driver and its binding
> used vddp-ref-clk regulator supply, but the new one did not and left the
> supply unused.
> 
> The Qualcomm UFS phy bindings were also migrated to newer ones and
> dropped support for vddp-ref-clk regulator in commit dc5cb63592bd
> ("dt-bindings: phy: migrate QMP UFS PHY bindings to
> qcom,sc8280xp-qmp-ufs-phy.yaml").
> 
> It turns out that this regulator, although with inaccurate name
> vddp-ref-clk, is actually needed to provide supply for VDD_PX10 (or
> similar, depending on the SoC) used by UFS controller.
> 
> Bring back handling of this supply by using more appropriate regulator -
> UFS controller host supply.  This also fixes dtbs_check warning:
> 
>   msm8996-xiaomi-gemini.dtb: phy@627000: 'vddp-ref-clk-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
Konrad Dybcio Sept. 6, 2023, 9:44 a.m. UTC | #3 
On 5.09.2023 18:19, Krzysztof Kozlowski wrote:
> The Qualcomm UFS phy switched from dedicated driver to QMP phy driver.
> Eventually the old driver was removed in commit 02dca8c981b5 ("phy:
> qcom: remove ufs qmp phy driver").  The original driver and its binding
> used vddp-ref-clk regulator supply, but the new one did not and left the
> supply unused.
> 
> The Qualcomm UFS phy bindings were also migrated to newer ones and
> dropped support for vddp-ref-clk regulator in commit dc5cb63592bd
> ("dt-bindings: phy: migrate QMP UFS PHY bindings to
> qcom,sc8280xp-qmp-ufs-phy.yaml").
> 
> It turns out that this regulator, although with inaccurate name
> vddp-ref-clk, is actually needed to provide supply for VDD_PX10 (or
> similar, depending on the SoC) used by UFS controller.
> 
> Bring back handling of this supply by using more appropriate regulator -
> UFS controller host supply.  This also fixes dtbs_check warning:
> 
>   msm8998-mtp.dtb: phy@1da7000: 'vddp-ref-clk-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad