mbox series

[v3,0/2] Support byte access in the RTC7301 driver

Message ID 20231010-rtc-7301-regwidth-v3-0-ade586b62794@linaro.org
Headers show
Series Support byte access in the RTC7301 driver | expand

Message

Linus Walleij Oct. 10, 2023, 7:42 p.m. UTC
This augments the Epson RTC7301 driver so that is supports
both 8bit byte and 32bit word access.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Changes in v3:
- Use a default in the binding to encode 32bit (4 bytes) reg width
  as default.
- Collect Rob's ACK.
- Link to v2: https://lore.kernel.org/r/20231007-rtc-7301-regwidth-v2-0-c913aa95f666@linaro.org

Changes in v2:
- Specify that the reg-io-width default is 4 if not specified in the
  device tree.
- Fix spelling in driver comment.
- Print error and exit if an invalid width is specified.
- Link to v1: https://lore.kernel.org/r/20230921-rtc-7301-regwidth-v1-0-1900556181bf@linaro.org

---
Linus Walleij (2):
      rtc: rtc7301: Rewrite bindings in schema
      rtc: rtc7301: Support byte-addressed IO

 .../devicetree/bindings/rtc/epson,rtc7301.txt      | 16 -------
 .../devicetree/bindings/rtc/epson,rtc7301.yaml     | 51 ++++++++++++++++++++++
 drivers/rtc/rtc-r7301.c                            | 35 ++++++++++++++-
 3 files changed, 84 insertions(+), 18 deletions(-)
---
base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d
change-id: 20230921-rtc-7301-regwidth-18ba1e3d0edb

Best regards,

Comments

Akinobu Mita Oct. 15, 2023, 1:55 p.m. UTC | #1
2023年10月11日(水) 4:42 Linus Walleij <linus.walleij@linaro.org>:
>
> This augments the Epson RTC7301 driver so that is supports
> both 8bit byte and 32bit word access.

I don't have access to that device anymore, but I think it's a good change.

Reviewed-by: Akinobu Mita <akinobu.mita@gmail.com>
Alexandre Belloni Oct. 15, 2023, 9:03 p.m. UTC | #2
On Tue, 10 Oct 2023 21:42:10 +0200, Linus Walleij wrote:
> This augments the Epson RTC7301 driver so that is supports
> both 8bit byte and 32bit word access.
> 
> 

Applied, thanks!

[1/2] rtc: rtc7301: Rewrite bindings in schema
      commit: 5ded578a18c9515c2c0e1cd148ca42133bbcf055
[2/2] rtc: rtc7301: Support byte-addressed IO
      commit: 8c767e9c1ef40c9fa73276df801251cef895b569

Best regards,