| Message ID | 20231215191838.1925082-1-nmorrisson@phytec.com |
|---|---|
| Headers | show |
| Series | *** Add fixed-paritions to phyCORE-AM62x and phyCORE-AM64x *** | expand |
On 12/15/23 1:18 PM, Nathan Morrisson wrote: > Add a fixed-partitions node to the NOR flash of the phyCORE-AM62x > and phyCORE-AM64x to enable the bootloader to fixup the partitions > during boot. > Why can't your bootloader add these nodes? Andrew > Nathan Morrisson (2): > arm64: dts: ti: k3-am62-phycore-som: Add fixed-partitions to NOR Flash > arm64: dts: ti: k3-am64-phycore-som: Add fixed-partitions to NOR Flash > > arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi | 6 ++++++ > arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi | 6 ++++++ > 2 files changed, 12 insertions(+) >
Hi Andrew, We are adding the nodes directly to the device tree to match what is done in other device trees, for example: k3-am642-tqma64xxl.dtsi. You are correct that this could be done by the bootloader instead though. Why do you prefer having the bootloader add the nodes? Regards, Nathan On 12/15/23 11:20 AM, Andrew Davis wrote: > On 12/15/23 1:18 PM, Nathan Morrisson wrote: >> Add a fixed-partitions node to the NOR flash of the phyCORE-AM62x >> and phyCORE-AM64x to enable the bootloader to fixup the partitions >> during boot. >> > > Why can't your bootloader add these nodes? > > Andrew > >> Nathan Morrisson (2): >> arm64: dts: ti: k3-am62-phycore-som: Add fixed-partitions to NOR >> Flash >> arm64: dts: ti: k3-am64-phycore-som: Add fixed-partitions to NOR >> Flash >> >> arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi | 6 ++++++ >> arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi | 6 ++++++ >> 2 files changed, 12 insertions(+) >>
On 12/18/23 12:47 PM, Nathan Morrisson wrote: > Hi Andrew, > > We are adding the nodes directly to the device tree to match what is done in other device trees, for example: k3-am642-tqma64xxl.dtsi. You are correct that this could be done by the bootloader instead though. Why do you prefer having the bootloader add the nodes? > k3-am642-tqma64xxl.dtsi should be fixed, it slipped past me and shouldn't be used as a reference. The bootloader might not fill it out at all, what if we start using the new MTD GPT partitions? Then the new bootloaders will have to start *removing* these stale half-nodes. If the bootloader is going to add fixed partitions it should do the whole job. There is no good reason to have a half complete nodes here. Andrew > Regards, > > Nathan > > On 12/15/23 11:20 AM, Andrew Davis wrote: >> On 12/15/23 1:18 PM, Nathan Morrisson wrote: >>> Add a fixed-partitions node to the NOR flash of the phyCORE-AM62x >>> and phyCORE-AM64x to enable the bootloader to fixup the partitions >>> during boot. >>> >> >> Why can't your bootloader add these nodes? >> >> Andrew >> >>> Nathan Morrisson (2): >>> arm64: dts: ti: k3-am62-phycore-som: Add fixed-partitions to NOR Flash >>> arm64: dts: ti: k3-am64-phycore-som: Add fixed-partitions to NOR Flash >>> >>> arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi | 6 ++++++ >>> arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi | 6 ++++++ >>> 2 files changed, 12 insertions(+) >>>