mbox series

[v4,0/2] usb: host: Add ac5 to EHCI Orion

Message ID 20240114172154.2622275-1-enachman@marvell.com
Headers show
Series usb: host: Add ac5 to EHCI Orion | expand

Message

Elad Nachman Jan. 14, 2024, 5:21 p.m. UTC
From: Elad Nachman <enachman@marvell.com>

Add support for ac5 to the EHCI Orion platform driver.
The ac5 SOC has DDR starting at offset 0x2_0000_0000,
Hence it requires a larger than 32-bit DMA mask to operate.
Move the dma mask to be pointed by the OF match data, and
use that match data when initializng the DMA mask.
Add dt bindings compatible string to identify the AC5 SOC,
so the driver will know when to apply this different dma mask.

v4:
   1) Fix kernel test robot error (missing null entry in dt
      compatibility array)

v3:
   1) Combine dt bindings and driver pathces into a single patchset.

v2:
   1) Fix compiler warning

Elad Nachman (2):
  dt-bindings: usb: Add Marvell ac5
  usb: host: Add ac5 to EHCI Orion

 .../devicetree/bindings/usb/generic-ehci.yaml  |  1 +
 drivers/usb/host/ehci-orion.c                  | 18 +++++++++++++++---
 2 files changed, 16 insertions(+), 3 deletions(-)

Comments

Conor Dooley Jan. 15, 2024, 4:32 p.m. UTC | #1
On Mon, Jan 15, 2024 at 08:25:08AM +0100, Krzysztof Kozlowski wrote:
> On 14/01/2024 18:21, Elad Nachman wrote:
> > From: Elad Nachman <enachman@marvell.com>
> > 
> > Add Marvell ac5 device tree bindings to generic EHCI.
> > This compatible enables the Marvell Orion platform code
> > to properly configure the DMA mask for the Marvell AC5 SOC.
> > 
> > Signed-off-by: Elad Nachman <enachman@marvell.com>
> 
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

> 
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions, under or above your Signed-off-by tag. Tag is "received", when
> provided in a message replied to you on the mailing list. Tools like b4
> can help here. However, there's no need to repost patches *only* to add
> the tags. The upstream maintainer will do that for tags received on the
> version they apply.
> 
> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
> 
> If a tag was not added on purpose, please state why and what changed.
> 
> Best regards,
> Krzysztof
>