mbox series

[0/2] dt: thermal: Fix broken cooling-maps

Message ID cover.1530766981.git.viresh.kumar@linaro.org
Headers show
Series dt: thermal: Fix broken cooling-maps | expand

Message

Viresh Kumar July 5, 2018, 5:09 a.m. UTC
Hi,

This is an attempt to fix the broken or partially defined DT bindings
for cooling-maps. We should list every device that participates in
cooling down at a certain trip point, instead of just the first in the
list as that depends on certain ordering of events to work properly.

The first patch extends the binding to allow a list of phandles in
"cooling-device" property and the second patch fixes one of the
platform's DT.

This will be followed up by fixing all platform DT bindings that have
these issues after this set is accepted.

The kernel also requires some changes to handle the phandle list, but
wouldn't break with these changes as it reads the first phandle in the
list for now. We can update that separately.

--
viresh

Viresh Kumar (2):
  dt-bindings: thermal: Allow multiple devices to share cooling map
  arm64: dts: hi6220: Add all CPUs in cooling maps

 Documentation/devicetree/bindings/thermal/thermal.txt | 11 +++--------
 arch/arm64/boot/dts/hisilicon/hi6220.dtsi             |  9 ++++++++-
 2 files changed, 11 insertions(+), 9 deletions(-)

-- 
2.18.0.rc1.242.g61856ae69a2c

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Rob Herring July 16, 2018, 10:02 p.m. UTC | #1
On Thu, Jul 05, 2018 at 10:39:23AM +0530, Viresh Kumar wrote:
> Allow cooling devices sharing same trip point with same contribution

> value to share the cooling map as well. Otherwise the same information

> will be duplicated for each device sharing the trip point.

> 

> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

> ---

>  Documentation/devicetree/bindings/thermal/thermal.txt | 11 +++--------

>  1 file changed, 3 insertions(+), 8 deletions(-)


Reviewed-by: Rob Herring <robh@kernel.org>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Viresh Kumar July 19, 2018, 2:40 a.m. UTC | #2
On 18-07-18, 16:34, Wei Xu wrote:
> Hi Viresh,

> 

> On 2018/7/5 6:09, Viresh Kumar wrote:

> > Hi,

> > 

> > This is an attempt to fix the broken or partially defined DT bindings

> > for cooling-maps. We should list every device that participates in

> > cooling down at a certain trip point, instead of just the first in the

> > list as that depends on certain ordering of events to work properly.

> > 

> > The first patch extends the binding to allow a list of phandles in

> > "cooling-device" property and the second patch fixes one of the

> > platform's DT.

> > 

> > This will be followed up by fixing all platform DT bindings that have

> > these issues after this set is accepted.

> > 

> > The kernel also requires some changes to handle the phandle list, but

> > wouldn't break with these changes as it reads the first phandle in the

> > list for now. We can update that separately.

> > 

> > --

> > viresh

> > 

> > Viresh Kumar (2):

> >   dt-bindings: thermal: Allow multiple devices to share cooling map

> >   arm64: dts: hi6220: Add all CPUs in cooling maps

> > 

> >  Documentation/devicetree/bindings/thermal/thermal.txt | 11 +++--------

> >  arch/arm64/boot/dts/hisilicon/hi6220.dtsi             |  9 ++++++++-

> >  2 files changed, 11 insertions(+), 9 deletions(-)

> > 

> 

> Thanks!

> Applied both to the hisilicon dt tree.


Hi Wei,

I expected the first patch to go via the thermal tree as it is for the
thermal core maintainers. Second patch can very well go from your
tree, but only after the 1st one is applied by thermal maintainers.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Wei Xu July 19, 2018, 9:54 a.m. UTC | #3
Hi Viresh,

On 2018/7/19 3:40, Viresh Kumar wrote:
> On 18-07-18, 16:34, Wei Xu wrote:

>> Hi Viresh,

>>

>> On 2018/7/5 6:09, Viresh Kumar wrote:

>>> Hi,

>>>

>>> This is an attempt to fix the broken or partially defined DT bindings

>>> for cooling-maps. We should list every device that participates in

>>> cooling down at a certain trip point, instead of just the first in the

>>> list as that depends on certain ordering of events to work properly.

>>>

>>> The first patch extends the binding to allow a list of phandles in

>>> "cooling-device" property and the second patch fixes one of the

>>> platform's DT.

>>>

>>> This will be followed up by fixing all platform DT bindings that have

>>> these issues after this set is accepted.

>>>

>>> The kernel also requires some changes to handle the phandle list, but

>>> wouldn't break with these changes as it reads the first phandle in the

>>> list for now. We can update that separately.

>>>

>>> --

>>> viresh

>>>

>>> Viresh Kumar (2):

>>>   dt-bindings: thermal: Allow multiple devices to share cooling map

>>>   arm64: dts: hi6220: Add all CPUs in cooling maps

>>>

>>>  Documentation/devicetree/bindings/thermal/thermal.txt | 11 +++--------

>>>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi             |  9 ++++++++-

>>>  2 files changed, 11 insertions(+), 9 deletions(-)

>>>

>>

>> Thanks!

>> Applied both to the hisilicon dt tree.

> 

> Hi Wei,

> 

> I expected the first patch to go via the thermal tree as it is for the

> thermal core maintainers. Second patch can very well go from your

> tree, but only after the 1st one is applied by thermal maintainers.

> 


OK. I will drop them in the pull request and apply the dts patch later.

Best Regards,
Wei


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Zhang Rui July 31, 2018, 6 a.m. UTC | #4
On 二, 2018-07-31 at 10:21 +0530, Viresh Kumar wrote:
> On 05-07-18, 10:39, Viresh Kumar wrote:

> > 

> > Hi,

> > 

> > This is an attempt to fix the broken or partially defined DT

> > bindings

> > for cooling-maps. We should list every device that participates in

> > cooling down at a certain trip point, instead of just the first in

> > the

> > list as that depends on certain ordering of events to work

> > properly.

> > 

> > The first patch extends the binding to allow a list of phandles in

> > "cooling-device" property and the second patch fixes one of the

> > platform's DT.

> > 

> > This will be followed up by fixing all platform DT bindings that

> > have

> > these issues after this set is accepted.

> > 

> > The kernel also requires some changes to handle the phandle list,

> > but

> > wouldn't break with these changes as it reads the first phandle in

> > the

> > list for now. We can update that separately.

> @Zhang: Are you going to apply this for 4.19-rc1 ? There are lot of

> patches that

> I am holding up until this gets merged,

> 

I suppose this patch should go via Eduardo' tree.
Eduardo, can you please take a look at this patch set?

thanks,
rui
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Viresh Kumar Aug. 3, 2018, 8:40 a.m. UTC | #5
On 31-07-18, 14:00, Zhang Rui wrote:
> I suppose this patch should go via Eduardo' tree.

> Eduardo, can you please take a look at this patch set?


Zhang,

Since Eduardo isn't replying, will it be possible for you to pick it up as I
don't want to miss 4.19-rc1.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Zhang Rui Aug. 6, 2018, 6:29 a.m. UTC | #6
On 五, 2018-08-03 at 14:10 +0530, Viresh Kumar wrote:
> On 31-07-18, 14:00, Zhang Rui wrote:

> > 

> > I suppose this patch should go via Eduardo' tree.

> > Eduardo, can you please take a look at this patch set?

> Zhang,

> 

> Since Eduardo isn't replying, will it be possible for you to pick it

> up as I

> don't want to miss 4.19-rc1.

> 

Okay, I will keep queue it in my tree first.

thanks,
rui
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html