| Message ID | cover.1617110420.git.cristian.ciocaltea@gmail.com |
|---|---|
| Headers | show |
| Series | Add support for Actions Semi Owl socinfo | expand |
On Tue, Mar 30, 2021 at 04:48:15PM +0300, Cristian Ciocaltea wrote: > This patchset adds a socinfo driver which provides information about > Actions Semi Owl SoCs to user space via sysfs: machine, family, soc_id, > serial_number. > > Please note the serial number is currently available only for the S500 > SoC variant. > > This has been tested on the S500 SoC based RoseapplePi SBC. > Is this the soc_id provided by the vendor bootloader (uboot)? If so, under what basis it provides? I don't think the SoC has the provision for soc_id based on HW parameters. Thanks, Mani > Thanks, > Cristi > > Changes in v2: > - Exposed the memory range for reading the SoC serial number under > /reserved-memory DT node, according to Rob's review; as a consequence > added a new binding document (actions,owl-soc-serial.yaml) and updated > owl-socinfo.yaml > > - Replaced the unportable usage of system_serial_{low,high} globals > with a public API to provide external access to SoC serial number > parts (e.g. Owl Ethernet MAC driver will use this to generate a > stable MAC address) > > - Rebased patch series on v5.12-rc5 > > Cristian Ciocaltea (6): > dt-bindings: reserved-memory: Add Owl SoC serial number binding > dt-bindings: soc: actions: Add Actions Semi Owl socinfo binding > soc: actions: Add Actions Semi Owl socinfo driver > arm: dts: owl-s500: Add reserved-memory range for Owl SoC serial > number > arm: dts: owl-s500: Add socinfo support > MAINTAINERS: Add entries for Owl reserved-memory and socinfo bindings > > .../actions,owl-soc-serial.yaml | 53 ++++++ > .../bindings/soc/actions/owl-socinfo.yaml | 57 +++++++ > MAINTAINERS | 2 + > arch/arm/boot/dts/owl-s500.dtsi | 13 +- > drivers/soc/actions/Kconfig | 8 + > drivers/soc/actions/Makefile | 1 + > drivers/soc/actions/owl-socinfo.c | 152 ++++++++++++++++++ > include/linux/soc/actions/owl-serial-number.h | 20 +++ > 8 files changed, 305 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/reserved-memory/actions,owl-soc-serial.yaml > create mode 100644 Documentation/devicetree/bindings/soc/actions/owl-socinfo.yaml > create mode 100644 drivers/soc/actions/owl-socinfo.c > create mode 100644 include/linux/soc/actions/owl-serial-number.h > > -- > 2.31.1 >
Hi Mani, On Thu, Apr 01, 2021 at 10:54:38AM +0530, Manivannan Sadhasivam wrote: > On Tue, Mar 30, 2021 at 04:48:15PM +0300, Cristian Ciocaltea wrote: > > This patchset adds a socinfo driver which provides information about > > Actions Semi Owl SoCs to user space via sysfs: machine, family, soc_id, > > serial_number. > > > > Please note the serial number is currently available only for the S500 > > SoC variant. > > > > This has been tested on the S500 SoC based RoseapplePi SBC. > > > > Is this the soc_id provided by the vendor bootloader (uboot)? If so, under > what basis it provides? I don't think the SoC has the provision for > soc_id based on HW parameters. No, the soc_id is not provided by the bootloader, or at least I couldn't identify any related implementation. Instead, I provided this via the driver itself, since I've encountered this approach in some other soc drivers as well (e.g. imx/soc-imx.c, versatile/soc-integrator.c). Thanks, Cristi > Thanks, > Mani [...]
On Thu, Apr 01, 2021 at 12:40:41PM +0300, Cristian Ciocaltea wrote: > Hi Mani, > > On Thu, Apr 01, 2021 at 10:54:38AM +0530, Manivannan Sadhasivam wrote: > > On Tue, Mar 30, 2021 at 04:48:15PM +0300, Cristian Ciocaltea wrote: > > > This patchset adds a socinfo driver which provides information about > > > Actions Semi Owl SoCs to user space via sysfs: machine, family, soc_id, > > > serial_number. > > > > > > Please note the serial number is currently available only for the S500 > > > SoC variant. > > > > > > This has been tested on the S500 SoC based RoseapplePi SBC. > > > > > > > Is this the soc_id provided by the vendor bootloader (uboot)? If so, under > > what basis it provides? I don't think the SoC has the provision for > > soc_id based on HW parameters. > > No, the soc_id is not provided by the bootloader, or at least I couldn't > identify any related implementation. Instead, I provided this via the > driver itself, since I've encountered this approach in some other soc > drivers as well (e.g. imx/soc-imx.c, versatile/soc-integrator.c). > Sorry, I was referring to serial_number. Since your comment says so, can you point to the corresponding code? Thanks, Mani > Thanks, > Cristi > > > Thanks, > > Mani > > [...]
Hi, On 01.04.21 12:27, Manivannan Sadhasivam wrote: > On Thu, Apr 01, 2021 at 12:40:41PM +0300, Cristian Ciocaltea wrote: >> On Thu, Apr 01, 2021 at 10:54:38AM +0530, Manivannan Sadhasivam wrote: >>> On Tue, Mar 30, 2021 at 04:48:15PM +0300, Cristian Ciocaltea wrote: >>>> This patchset adds a socinfo driver which provides information about >>>> Actions Semi Owl SoCs to user space via sysfs: machine, family, soc_id, >>>> serial_number. >>>> >>>> Please note the serial number is currently available only for the S500 >>>> SoC variant. >>>> >>>> This has been tested on the S500 SoC based RoseapplePi SBC. >>>> >>> >>> Is this the soc_id provided by the vendor bootloader (uboot)? If so, under >>> what basis it provides? I don't think the SoC has the provision for >>> soc_id based on HW parameters. >> >> No, the soc_id is not provided by the bootloader, or at least I couldn't >> identify any related implementation. Instead, I provided this via the >> driver itself, since I've encountered this approach in some other soc >> drivers as well (e.g. imx/soc-imx.c, versatile/soc-integrator.c). >> > > Sorry, I was referring to serial_number. Since your comment says so, can > you point to the corresponding code? Seconded that this needs to be better understood. If this is just a convention of some downstream U-Boot that's not implemented in mainline (and maybe not even for Guitar or Labrador? tested on RoseapplePi only), it might not be worth its own reserved-memory based kernel driver? Implementing a standard interface such as DMI tables or a DT property in mainline U-Boot may be more useful then. Is it still Mani's S900 only? Regards, Andreas -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg)
Hi Mani, Andreas, On Thu, Apr 01, 2021 at 12:49:37PM +0200, Andreas Färber wrote: > Hi, > > On 01.04.21 12:27, Manivannan Sadhasivam wrote: > > On Thu, Apr 01, 2021 at 12:40:41PM +0300, Cristian Ciocaltea wrote: > >> On Thu, Apr 01, 2021 at 10:54:38AM +0530, Manivannan Sadhasivam wrote: > >>> On Tue, Mar 30, 2021 at 04:48:15PM +0300, Cristian Ciocaltea wrote: > >>>> This patchset adds a socinfo driver which provides information about > >>>> Actions Semi Owl SoCs to user space via sysfs: machine, family, soc_id, > >>>> serial_number. > >>>> > >>>> Please note the serial number is currently available only for the S500 > >>>> SoC variant. > >>>> > >>>> This has been tested on the S500 SoC based RoseapplePi SBC. > >>>> > >>> > >>> Is this the soc_id provided by the vendor bootloader (uboot)? If so, under > >>> what basis it provides? I don't think the SoC has the provision for > >>> soc_id based on HW parameters. > >> > >> No, the soc_id is not provided by the bootloader, or at least I couldn't > >> identify any related implementation. Instead, I provided this via the > >> driver itself, since I've encountered this approach in some other soc > >> drivers as well (e.g. imx/soc-imx.c, versatile/soc-integrator.c). > >> > > > > Sorry, I was referring to serial_number. Since your comment says so, can > > you point to the corresponding code? > > Seconded that this needs to be better understood. If this is just a > convention of some downstream U-Boot that's not implemented in mainline > (and maybe not even for Guitar or Labrador? tested on RoseapplePi only), > it might not be worth its own reserved-memory based kernel driver? The serial number is actually provided by the s500-bootloader for which Actions did not provide the source code, at least it is not available in the xapp github repo. I did not find anything related to this in downstream U-Boot. Kind regards, Cristi > Implementing a standard interface such as DMI tables or a DT property in > mainline U-Boot may be more useful then. Is it still Mani's S900 only? > > Regards, > Andreas > > -- > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Felix Imendörffer > HRB 36809 (AG Nürnberg)
+ Matheus On Thu, Apr 01, 2021 at 01:58:05PM +0300, Cristian Ciocaltea wrote: > Hi Mani, Andreas, > > On Thu, Apr 01, 2021 at 12:49:37PM +0200, Andreas Färber wrote: > > Hi, > > > > On 01.04.21 12:27, Manivannan Sadhasivam wrote: > > > On Thu, Apr 01, 2021 at 12:40:41PM +0300, Cristian Ciocaltea wrote: > > >> On Thu, Apr 01, 2021 at 10:54:38AM +0530, Manivannan Sadhasivam wrote: > > >>> On Tue, Mar 30, 2021 at 04:48:15PM +0300, Cristian Ciocaltea wrote: > > >>>> This patchset adds a socinfo driver which provides information about > > >>>> Actions Semi Owl SoCs to user space via sysfs: machine, family, soc_id, > > >>>> serial_number. > > >>>> > > >>>> Please note the serial number is currently available only for the S500 > > >>>> SoC variant. > > >>>> > > >>>> This has been tested on the S500 SoC based RoseapplePi SBC. > > >>>> > > >>> > > >>> Is this the soc_id provided by the vendor bootloader (uboot)? If so, under > > >>> what basis it provides? I don't think the SoC has the provision for > > >>> soc_id based on HW parameters. > > >> > > >> No, the soc_id is not provided by the bootloader, or at least I couldn't > > >> identify any related implementation. Instead, I provided this via the > > >> driver itself, since I've encountered this approach in some other soc > > >> drivers as well (e.g. imx/soc-imx.c, versatile/soc-integrator.c). > > >> > > > > > > Sorry, I was referring to serial_number. Since your comment says so, can > > > you point to the corresponding code? > > > > Seconded that this needs to be better understood. If this is just a > > convention of some downstream U-Boot that's not implemented in mainline > > (and maybe not even for Guitar or Labrador? tested on RoseapplePi only), > > it might not be worth its own reserved-memory based kernel driver? > > The serial number is actually provided by the s500-bootloader for which > Actions did not provide the source code, at least it is not available > in the xapp github repo. I did not find anything related to this in > downstream U-Boot. > Hmm, then we can consider this as the firmware dependent property. But can we get consensus that this is common for all S500 SoCs? Maybe, Matheus can verify it on Labrador? I don't think adding a SOCINFO driver for a single board is a good idea. Thanks, Mani > Kind regards, > Cristi > > > Implementing a standard interface such as DMI tables or a DT property in > > mainline U-Boot may be more useful then. Is it still Mani's S900 only? > > > > Regards, > > Andreas > > > > -- > > SUSE Software Solutions Germany GmbH > > Maxfeldstr. 5, 90409 Nürnberg, Germany > > GF: Felix Imendörffer > > HRB 36809 (AG Nürnberg)
On Thu, Apr 01, 2021 at 04:37:52PM +0530, Manivannan Sadhasivam wrote: > + Matheus > > On Thu, Apr 01, 2021 at 01:58:05PM +0300, Cristian Ciocaltea wrote: > > Hi Mani, Andreas, > > > > On Thu, Apr 01, 2021 at 12:49:37PM +0200, Andreas Färber wrote: > > > Hi, > > > > > > On 01.04.21 12:27, Manivannan Sadhasivam wrote: > > > > On Thu, Apr 01, 2021 at 12:40:41PM +0300, Cristian Ciocaltea wrote: > > > >> On Thu, Apr 01, 2021 at 10:54:38AM +0530, Manivannan Sadhasivam wrote: > > > >>> On Tue, Mar 30, 2021 at 04:48:15PM +0300, Cristian Ciocaltea wrote: > > > >>>> This patchset adds a socinfo driver which provides information about > > > >>>> Actions Semi Owl SoCs to user space via sysfs: machine, family, soc_id, > > > >>>> serial_number. > > > >>>> > > > >>>> Please note the serial number is currently available only for the S500 > > > >>>> SoC variant. > > > >>>> > > > >>>> This has been tested on the S500 SoC based RoseapplePi SBC. > > > >>>> > > > >>> > > > >>> Is this the soc_id provided by the vendor bootloader (uboot)? If so, under > > > >>> what basis it provides? I don't think the SoC has the provision for > > > >>> soc_id based on HW parameters. > > > >> > > > >> No, the soc_id is not provided by the bootloader, or at least I couldn't > > > >> identify any related implementation. Instead, I provided this via the > > > >> driver itself, since I've encountered this approach in some other soc > > > >> drivers as well (e.g. imx/soc-imx.c, versatile/soc-integrator.c). > > > >> > > > > > > > > Sorry, I was referring to serial_number. Since your comment says so, can > > > > you point to the corresponding code? > > > > > > Seconded that this needs to be better understood. If this is just a > > > convention of some downstream U-Boot that's not implemented in mainline > > > (and maybe not even for Guitar or Labrador? tested on RoseapplePi only), > > > it might not be worth its own reserved-memory based kernel driver? > > > > The serial number is actually provided by the s500-bootloader for which > > Actions did not provide the source code, at least it is not available > > in the xapp github repo. I did not find anything related to this in > > downstream U-Boot. > > > > Hmm, then we can consider this as the firmware dependent property. But > can we get consensus that this is common for all S500 SoCs? This should work on all S500 SoCs, as the downstream Linux kernel doesn't use any conditional logic around reading those memory locations. Please see "owl_check_revision()" in arch/arm/mach-owl/board-owl.c, from any of the following repos: * https://github.com/xapp-le/kernel * https://github.com/LeMaker/linux-actions > Maybe, > Matheus can verify it on Labrador? The verification is pretty straightforward: the serial number is dumped on the serial console by the s500 bootloader right before starting U-boot: load uboot: load address is 0x8000000, entry point is 0x8000040 in fourth chip serial no = 9d,4b,f,6d,31,46,e,8, [...] U-Boot 2015.04 (Apr 23 2020 - 23:01:25)Actions-Semi The socinfo driver should provide the equivalent information, but in reversed order (due to integer representation on LE arch): $ cat /sys/devices/soc0/serial_number 080e46316d0f4b9d > I don't think adding a SOCINFO driver for a single board is a good idea. The driver could be used for all Owl SoC variants, including S700 and S900, even though accessing the serial number is currently supported only on S500. Unfortunately I do only have this S500 SoC based SBC to experiment with, therefore I cannot enable new features for the hardware I'm not able to validate. Btw, do you know where I could get an S700 or S900 board from? I couldn't find any so far.. Thanks, Cristi > Thanks, > Mani > > > Kind regards, > > Cristi > > > > > Implementing a standard interface such as DMI tables or a DT property in > > > mainline U-Boot may be more useful then. Is it still Mani's S900 only? > > > > > > Regards, > > > Andreas > > > > > > -- > > > SUSE Software Solutions Germany GmbH > > > Maxfeldstr. 5, 90409 Nürnberg, Germany > > > GF: Felix Imendörffer > > > HRB 36809 (AG Nürnberg)
This patchset adds a socinfo driver which provides information about Actions Semi Owl SoCs to user space via sysfs: machine, family, soc_id, serial_number. Please note the serial number is currently available only for the S500 SoC variant. This has been tested on the S500 SoC based RoseapplePi SBC. Thanks, Cristi Changes in v2: - Exposed the memory range for reading the SoC serial number under /reserved-memory DT node, according to Rob's review; as a consequence added a new binding document (actions,owl-soc-serial.yaml) and updated owl-socinfo.yaml - Replaced the unportable usage of system_serial_{low,high} globals with a public API to provide external access to SoC serial number parts (e.g. Owl Ethernet MAC driver will use this to generate a stable MAC address) - Rebased patch series on v5.12-rc5 Cristian Ciocaltea (6): dt-bindings: reserved-memory: Add Owl SoC serial number binding dt-bindings: soc: actions: Add Actions Semi Owl socinfo binding soc: actions: Add Actions Semi Owl socinfo driver arm: dts: owl-s500: Add reserved-memory range for Owl SoC serial number arm: dts: owl-s500: Add socinfo support MAINTAINERS: Add entries for Owl reserved-memory and socinfo bindings .../actions,owl-soc-serial.yaml | 53 ++++++ .../bindings/soc/actions/owl-socinfo.yaml | 57 +++++++ MAINTAINERS | 2 + arch/arm/boot/dts/owl-s500.dtsi | 13 +- drivers/soc/actions/Kconfig | 8 + drivers/soc/actions/Makefile | 1 + drivers/soc/actions/owl-socinfo.c | 152 ++++++++++++++++++ include/linux/soc/actions/owl-serial-number.h | 20 +++ 8 files changed, 305 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/reserved-memory/actions,owl-soc-serial.yaml create mode 100644 Documentation/devicetree/bindings/soc/actions/owl-socinfo.yaml create mode 100644 drivers/soc/actions/owl-socinfo.c create mode 100644 include/linux/soc/actions/owl-serial-number.h