diff mbox series

[v2,01/13] dt-bindings: usb: mtk-xhci: support property usb2-lpm-disable

Message ID 1616482975-17841-1-git-send-email-chunfeng.yun@mediatek.com
State New
Headers show
Series [v2,01/13] dt-bindings: usb: mtk-xhci: support property usb2-lpm-disable | expand

Commit Message

Chunfeng Yun (云春峰) March 23, 2021, 7:02 a.m. UTC
Add support common property usb2-lpm-disable

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v2: no changes
---
 Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Rob Herring (Arm) March 27, 2021, 5:24 p.m. UTC | #1
On Tue, Mar 23, 2021 at 03:02:43PM +0800, Chunfeng Yun wrote:
> Add support common property usb2-lpm-disable
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> v2: no changes
> ---
>  Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> index 14f40efb3b22..2246d29a5e4e 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> @@ -103,6 +103,10 @@ properties:
>      description: supports USB3.0 LPM
>      type: boolean
>  
> +  usb2-lpm-disable:
> +    description: disable USB2 HW LPM
> +    type: boolean

Already has a type. Don't redefine here. Just 'usb2-lpm-disable: true' 
and make sure usb-xhci.yaml is referenced.

> +
>    imod-interval-ns:
>      description:
>        Interrupt moderation interval value, it is 8 times as much as that
> -- 
> 2.18.0
>
Chunfeng Yun (云春峰) March 29, 2021, 3:10 a.m. UTC | #2
On Sat, 2021-03-27 at 11:24 -0600, Rob Herring wrote:
> On Tue, Mar 23, 2021 at 03:02:43PM +0800, Chunfeng Yun wrote:

> > Add support common property usb2-lpm-disable

> > 

> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

> > ---

> > v2: no changes

> > ---

> >  Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml | 4 ++++

> >  1 file changed, 4 insertions(+)

> > 

> > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml

> > index 14f40efb3b22..2246d29a5e4e 100644

> > --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml

> > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml

> > @@ -103,6 +103,10 @@ properties:

> >      description: supports USB3.0 LPM

> >      type: boolean

> >  

> > +  usb2-lpm-disable:

> > +    description: disable USB2 HW LPM

> > +    type: boolean

> 

> Already has a type. Don't redefine here. Just 'usb2-lpm-disable: true' 

> and make sure usb-xhci.yaml is referenced.

Ok, thanks
> 

> > +

> >    imod-interval-ns:

> >      description:

> >        Interrupt moderation interval value, it is 8 times as much as that

> > -- 

> > 2.18.0

> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
index 14f40efb3b22..2246d29a5e4e 100644
--- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
+++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
@@ -103,6 +103,10 @@  properties:
     description: supports USB3.0 LPM
     type: boolean
 
+  usb2-lpm-disable:
+    description: disable USB2 HW LPM
+    type: boolean
+
   imod-interval-ns:
     description:
       Interrupt moderation interval value, it is 8 times as much as that