From patchwork Wed Nov 2 15:56:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Georgi Djakov X-Patchwork-Id: 80501 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp203046qge; Wed, 2 Nov 2016 08:57:33 -0700 (PDT) X-Received: by 10.107.16.33 with SMTP id y33mr5002430ioi.25.1478102253350; Wed, 02 Nov 2016 08:57:33 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e7si3119831pas.335.2016.11.02.08.57.33; Wed, 02 Nov 2016 08:57:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756074AbcKBP5N (ORCPT + 7 others); Wed, 2 Nov 2016 11:57:13 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:36125 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756005AbcKBP5N (ORCPT ); Wed, 2 Nov 2016 11:57:13 -0400 Received: by mail-wm0-f52.google.com with SMTP id p190so277710261wmp.1 for ; Wed, 02 Nov 2016 08:57:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=aEpiiifK5Tfbka3iuQQeQZVeJzyD872qoukev6qgfqw=; b=Hq+/uiStspE0tgOSILCjUEKenRJPEYxfhx1wbB5tzgVOsLo2bBaDNLUd4hx/txh4bA Ca0/jC4UUATHmV947lV12KNSoKS4EYr0WfpZ2nQtMoK5J/AAlOty9Y1Fv7vxRya2pbsu WeIK/kFUqJtksgWTX+yk8bDvEaWdqr9OvvFvw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=aEpiiifK5Tfbka3iuQQeQZVeJzyD872qoukev6qgfqw=; b=LwYijY4f2/ZTdiNkUjxtYI9wm09fNoQDYkQo4DEtGbXJAMGzIU1QFblXPhWNPjdhxW O8lAVh1QbAJd7KzLRmCjyDJpSCRCeh6z2TrAbxW1wsMc+T1FI94MRBXxjlhbMF1z1+9T XTy5IJc0ubBsaqK8r50BQi9sXDwYomaP0Bis1x2qRu1aAoZSrsIjOA+punIMtCEqoNp0 /J960X0QMZq2cx637YJbx+C+hyW1/rnhkUTm2lETS8lJRowGg+QhBRnz9K/iSCLCrV6y ujmXlwukL/Lq5CYrOfyv91Bj5sF5dnTE3P7OknNKrJTGyyqP/tiOCw2BW9kTYkb6LahR Hq1A== X-Gm-Message-State: ABUngveI3y0t+GAHR6v5TNSqUP6Y0ACpLOH0QwWqwfvgOxxFxaVcLIVN+K0JLvG75HTFuNvz X-Received: by 10.28.10.207 with SMTP id 198mr2820080wmk.2.1478102226763; Wed, 02 Nov 2016 08:57:06 -0700 (PDT) Received: from mms-0441.wifi.mm-sol.com ([212.45.67.2]) by smtp.googlemail.com with ESMTPSA id m194sm3991864wmg.11.2016.11.02.08.57.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 02 Nov 2016 08:57:05 -0700 (PDT) From: Georgi Djakov To: sboyd@codeaurora.org, mturquette@baylibre.com Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, georgi.djakov@linaro.org Subject: [PATCH v9 3/3] clk: qcom: Always add factor clock for xo clocks Date: Wed, 2 Nov 2016 17:56:58 +0200 Message-Id: <20161102155658.32203-4-georgi.djakov@linaro.org> X-Mailer: git-send-email 2.10.1 In-Reply-To: <20161102155658.32203-1-georgi.djakov@linaro.org> References: <20161102155658.32203-1-georgi.djakov@linaro.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Currently the RPM/RPM-SMD clock drivers do not register the xo clocks, so we should always add factor clock. When we later add xo clocks support into the drivers, we should update this function to skip registration. By doing so we avoid any DT dependencies. Signed-off-by: Georgi Djakov --- drivers/clk/qcom/common.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c index fffcbaf0fba7..27566a0098ca 100644 --- a/drivers/clk/qcom/common.c +++ b/drivers/clk/qcom/common.c @@ -153,15 +153,12 @@ int qcom_cc_register_board_clk(struct device *dev, const char *path, const char *name, unsigned long rate) { bool add_factor = true; - struct device_node *node; - - /* The RPM clock driver will add the factor clock if present */ - if (IS_ENABLED(CONFIG_QCOM_RPMCC)) { - node = of_find_compatible_node(NULL, NULL, "qcom,rpmcc"); - if (of_device_is_available(node)) - add_factor = false; - of_node_put(node); - } + + /* + * TODO: The RPM clock driver currently does not support the xo clock. + * When xo is added to the RPM clock driver, we should change this + * function to skip registration of xo factor clocks. + */ return _qcom_cc_register_board_clk(dev, path, name, rate, add_factor); }