From patchwork Thu May 23 15:01:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 165032 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp2309982ili; Thu, 23 May 2019 08:01:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqwsYL35dv60oiJxgrecN6tBCNHIVbQ16c8hxW7Z4s9mmFwVthfLMKoTQvDspxw4lJvuGEV0 X-Received: by 2002:a63:18e:: with SMTP id 136mr68970705pgb.277.1558623718792; Thu, 23 May 2019 08:01:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558623718; cv=none; d=google.com; s=arc-20160816; b=ex/yGJObpJqTeLdjnNOKOpOzxLXWV3sfqyq0/Rj65+MoRuY8R5Gtn1KU/eC8zwSwR0 mVhB5kto0Cl6mb2CcB7JG20SQKQnTEpGN21XwuBxST+4Q18BI6zAoRMy1nTWRgbGpUY/ gwYhpvDlRFePHKPtR9OrQG0AiXgFx7xRv/G87pj2wLOFVwx9ioErd8AmlsDW4Zsk0nj/ 6NdBYhWKnIgtzIfjZv0QajZLaeqpXfS8iqofZhnXY+yxqehsZwXxUEcrN2dpE5VTBIei SXxNVTP5us29iDs0Pi8lpO3iXGKcJC/DaVC9NzIpp3Bctl1winS2ebo7hNouTk4EQsEW IAgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=9HPbB+/1XsdXIOfekp8uwS00PlsQpqBLPqA5cNuO+gA=; b=ktf/LwOs8kWkQo8lFz3SCO1XCDmJWQ1Z++zPC5qpXZRHJGT+/34ZX80UsC14v+fIii 2WNJ21Ar3qk3REneUE/CgpLbJ4aNe79Geq00wHg4LujxHluiMN3JBZz5R7nhhYL7PlvG n94RXjzioOLIR8xjO3ZZ3TIy6sOq17fqPJAC72ra6aKDEsqFyLLYsOQm7fCHrr7N5C2Z fZXnv8Y7bFSteU/PqJVIMzAcdB/pelrikpybgVuda8pI76pgMcDNx2NUg10O5ukDCukb mgGNwKHv7VL6oUvJhHQSAEkC1n+w5eWWU5Zn8Tpgo6NuJxwFewK6xZwhuQQ/juJA105U /eNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ylu32Xyv; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k2si961267pje.26.2019.05.23.08.01.58; Thu, 23 May 2019 08:01:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ylu32Xyv; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730756AbfEWPB6 (ORCPT + 7 others); Thu, 23 May 2019 11:01:58 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:39403 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730741AbfEWPB5 (ORCPT ); Thu, 23 May 2019 11:01:57 -0400 Received: by mail-pl1-f194.google.com with SMTP id g9so2870181plm.6 for ; Thu, 23 May 2019 08:01:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=9HPbB+/1XsdXIOfekp8uwS00PlsQpqBLPqA5cNuO+gA=; b=ylu32XyvB6DWk0CsJb509nElZsZmOoFdPwMEL7u9OSkrpMlho3jb6QCQxy/15T3wMp BkhEPVUE6VEjBnuopij1rHk8QYCaghvYH8nfxns4iMxmCIThEKBsFr7NIzJeo60nFE+u j6xCj8u/NAAWkIaUwYdcd9Kt6fLrmLFbXPzLInYfEWgAd9vYUSbaXz6Y21iIppxWCiEw fhyvwnbHOdYDua1hNZPpaKxj+en82dkzN3OBIe3f3ehQmxjE/wF1eI+jGQcTWy4jWIaI A/hn1rjsz8tLHDQY/Lwgn4XetVvulMZwBrTFYJ920MSzUw7+NoxvcOic0caAQyyoHKGo JetQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=9HPbB+/1XsdXIOfekp8uwS00PlsQpqBLPqA5cNuO+gA=; b=iBDLWLLtqkLzcV/KWv7fcG81PPpeb5Z65Dbh8xx9aYJGH9hhXuacubrOcBO6YMBNSJ jBXuZ7vc3DpeQieXpuf++Y13M7Sr6KyJzXGOxaMqmT2iyrDP6ZAoZblJe9P/3jWZbJfp 23Feyl+S0lxYkW6388kqffvpPspILKRB7g7ABGsSVziwan27BrYxp3SblpSvA0tbZZ15 1+4imHUMvemMUj8g1raSoV7XH1H2gNqAKTjrPvN/5RTsBagwWPiIYTWCxkMd0VKZHQqx tO80thmmuXmnR5JYiAA+pZNCYKA+y14i+lhDAbytdiDnLAQ7cL/d1SOiIW9zyWaG3VXK E3MQ== X-Gm-Message-State: APjAAAXV4wcHZh9uMDWXSz/nEEbcyztxkuAzKiVIjyNK2+CbEjRVxm52 EodNtHnUTngA95WsgYSXXgh2nw== X-Received: by 2002:a17:902:2de4:: with SMTP id p91mr82211589plb.300.1558623717040; Thu, 23 May 2019 08:01:57 -0700 (PDT) Received: from localhost.localdomain (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id t2sm25418248pfh.166.2019.05.23.08.01.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 May 2019 08:01:56 -0700 (PDT) From: Bjorn Andersson To: Andy Gross , David Brown , Rob Herring , Mark Rutland Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] soc: qcom: apr: Don't use reg for domain id Date: Thu, 23 May 2019 08:01:53 -0700 Message-Id: <20190523150153.13136-1-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.18.0 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The reg property represents the address and size on the bus that a device lives, but for APR the parent is a rpmsg bus, which does not have numerical addresses. Simply defining #address/#size-cells to 1 and 0, respectively, to silence the compiler is not an appropriate solution. Replace the use of "reg" with an APR specific property. Reviewed-by: Srinivas Kandagatla Signed-off-by: Bjorn Andersson --- Changes since v1: - Fixed example to match change Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt | 6 +++--- drivers/soc/qcom/apr.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) -- 2.18.0 Reviewed-by: Rob Herring diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt index bcc612cc7423..db501269f47b 100644 --- a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt @@ -9,7 +9,7 @@ used for audio/voice services on the QDSP. Value type: Definition: must be "qcom,apr-v", example "qcom,apr-v2" -- reg +- qcom,apr-domain Usage: required Value type: Definition: Destination processor ID. @@ -49,9 +49,9 @@ by the individual bindings for the specific service The following example represents a QDSP based sound card on a MSM8996 device which uses apr as communication between Apps and QDSP. - apr@4 { + apr { compatible = "qcom,apr-v2"; - reg = ; + qcom,apr-domain = ; q6core@3 { compatible = "qcom,q6core"; diff --git a/drivers/soc/qcom/apr.c b/drivers/soc/qcom/apr.c index 74f8b9607daa..b83d71b2e0a4 100644 --- a/drivers/soc/qcom/apr.c +++ b/drivers/soc/qcom/apr.c @@ -276,7 +276,7 @@ static int apr_probe(struct rpmsg_device *rpdev) if (!apr) return -ENOMEM; - ret = of_property_read_u32(dev->of_node, "reg", &apr->dest_domain_id); + ret = of_property_read_u32(dev->of_node, "qcom,apr-domain", &apr->dest_domain_id); if (ret) { dev_err(dev, "APR Domain ID not specified in DT\n"); return ret;