From patchwork Fri Sep 13 21:13:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 173791 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ce:0:0:0:0 with SMTP id r14csp657669ilq; Fri, 13 Sep 2019 14:13:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqxq+8gpQmGe5KQiufke1Z7TDFcRHvUW0uCsGBzq0pSgS2ok4Wj4D7WgQtM1E1/OtYVhWKJo X-Received: by 2002:a50:a41c:: with SMTP id u28mr49828682edb.185.1568409232180; Fri, 13 Sep 2019 14:13:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568409232; cv=none; d=google.com; s=arc-20160816; b=0oBSPUDDJ07kB7XDyPZrwSiE6CjwH6O2q4V5TVcte/eh6z27kT5zdorHGZ6GFw1Jxj Mhb3+SRDoz0GCMuThyDLyiA5Ll8WDYT6UBXn7j+7W0MS7KVRXaTGuXpaEkEuh6Sok1gk 7+LUcVe4RRISYnuSU6+SAlxUplzRuno4MRluWtVgP0pdlhI1YAa8KFOuylT+0MfptF3W FOlSpV0+R41qK/NnZBfaDIH5M8yfBFg7O1zP8qbxdL40FMd3KNji7PpYtYZaYxYsavtr B6PrhopJ7N2OcghBYlMO6j/TL4lrXSGzFPcuUdtlTK2bhgrcFibO6RG7dcq7ZKljWLht emNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=JGerZQ1lZMxixYWpuVLCQeykiTnMK0boWr8rN0knwKI=; b=oS0IkRbnrgtsuT40L8tkQQ5YKv5FZq09DM+5w10kMohFtVtrYdJyHwm2HuQCdc5IJj zPHBBu9Jw5wx0agYPwQKvXI1LSkvRYMv/556/ilIY9st0AmauZD6agfAM1qjXtYvy4BK OInkYcKZbsLW99drWU7G3vj1zwOj5Ga5TaxWUNBhmTrO2pNL/OZhXAKbn1aeF/S5wbJ9 2TkGmKJAMusgthyZrKQS8wHO7qGb54j2/qc+NuMzKirFapMaP2jQMoWINReZ0btZlT5N +0HXzMYNYJPKYW21nq9r+jxLr40ft6gJybf99zrJItf6YrfqEOd7mSBrY6VEDOlXP/OO cwRw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z3si15346552ejx.33.2019.09.13.14.13.51; Fri, 13 Sep 2019 14:13:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730847AbfIMVNv (ORCPT + 8 others); Fri, 13 Sep 2019 17:13:51 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:36079 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730023AbfIMVNv (ORCPT ); Fri, 13 Sep 2019 17:13:51 -0400 Received: by mail-ot1-f68.google.com with SMTP id 67so30696307oto.3; Fri, 13 Sep 2019 14:13:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JGerZQ1lZMxixYWpuVLCQeykiTnMK0boWr8rN0knwKI=; b=g/+Lwyv/WVsE1tbESSBQmsYedr1PC6c6BrVWTahePRjDSFZ56tluk8OZWYdEyLuvgT +ri4BOuaFAA8YkDImgVZizkp0V+B97iVq13a4h1Bwr2jP0iYevH6rgBDGB0r9ZX3C7X6 6r2OEDWQHSM3F8zd9EubE2VqqLCQwUTHybTx22I3WX1/rxhtUrykS2eJ8MEZ/4ZqKahd vK3HUuildnhbEpwCyCgf41dlQKHukXQOc9h7esJHv5OsTfmr/KWfUcG94tR5RC247tHL BzMyLYChvdlxMopjphFYaOz53UlLcYIkQDeIfwB7n3f19OPQUh4cKFAxeef6fM/KLwQ9 myLQ== X-Gm-Message-State: APjAAAUunFL0XBNLAD1BatbhSzLva2XsJoaKtW5k0MX3scprYEE+Tnqq 158ieSbUXd+dfcDdRhVe20RmUeQ= X-Received: by 2002:a9d:371:: with SMTP id 104mr42653238otv.253.1568409230044; Fri, 13 Sep 2019 14:13:50 -0700 (PDT) Received: from xps15.herring.priv (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.googlemail.com with ESMTPSA id j23sm3916084otp.67.2019.09.13.14.13.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Sep 2019 14:13:49 -0700 (PDT) From: Rob Herring To: Joe Perches Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Whitcroft Subject: [PATCH] checkpatch: Warn if DT bindings are not in schema format Date: Fri, 13 Sep 2019 16:13:49 -0500 Message-Id: <20190913211349.28245-1-robh@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org DT bindings are moving to using a json-schema based schema format instead of freeform text. Add a checkpatch.pl check to encourage using the schema for new bindings. It's not yet a requirement, but is progressively being required by some maintainers. Cc: Andy Whitcroft Cc: Joe Perches Signed-off-by: Rob Herring --- scripts/checkpatch.pl | 8 ++++++++ 1 file changed, 8 insertions(+) -- 2.20.1 diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 93a7edfe0f05..1cbd85f16e32 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2822,6 +2822,14 @@ sub process { "added, moved or deleted file(s), does MAINTAINERS need updating?\n" . $herecurr); } +# Check for adding new DT bindings not in schema format + if (!$in_commit_log && + ($line =~ /^new file mode\s*\d+\s*$/) && + ($realfile =~ m@^Documentation/devicetree/bindings/.*\.txt$@)) { + WARN("DT_SCHEMA_BINDING_PATCH", + "DT bindings should be in DT schema format. See: Documentation/devicetree/writing-schema.rst\n"); + } + # Check for wrappage within a valid hunk of the file if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) { ERROR("CORRUPTED_PATCH",