From patchwork Fri Feb 21 12:21:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 204473 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A005C35646 for ; Fri, 21 Feb 2020 12:21:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF5ED24670 for ; Fri, 21 Feb 2020 12:21:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727720AbgBUMVo (ORCPT ); Fri, 21 Feb 2020 07:21:44 -0500 Received: from michel.telenet-ops.be ([195.130.137.88]:41530 "EHLO michel.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727683AbgBUMVo (ORCPT ); Fri, 21 Feb 2020 07:21:44 -0500 Received: from ramsan ([84.195.182.253]) by michel.telenet-ops.be with bizsmtp id 5QMi2200C5USYZQ06QMiA0; Fri, 21 Feb 2020 13:21:42 +0100 Received: from rox.of.borg ([192.168.97.57]) by ramsan with esmtp (Exim 4.90_1) (envelope-from ) id 1j57JO-0002E7-6D; Fri, 21 Feb 2020 13:21:42 +0100 Received: from geert by rox.of.borg with local (Exim 4.90_1) (envelope-from ) id 1j57JO-0008LO-4p; Fri, 21 Feb 2020 13:21:42 +0100 From: Geert Uytterhoeven To: Marcus Wolf , Greg Kroah-Hartman , Pantelis Antoniou , Frank Rowand , Rob Herring , Mark Rutland Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH 2/3] staging: pi433: overlay: Fix reg-related warnings Date: Fri, 21 Feb 2020 13:21:32 +0100 Message-Id: <20200221122133.32024-3-geert+renesas@glider.be> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200221122133.32024-1-geert+renesas@glider.be> References: <20200221122133.32024-1-geert+renesas@glider.be> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org When running "scripts/dtc/dtc -@ -I dts -O dtb -o pi433-overlay.dtbo.1 drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts": drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts:13.12-15.6: Warning (unit_address_vs_reg): /fragment@0/__overlay__/spidev@0: node has a unit name, but no reg property drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts:17.12-19.6: Warning (unit_address_vs_reg): /fragment@0/__overlay__/spidev@1: node has a unit name, but no reg property Add the missing "reg" properties to fix this. drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts:14.5-15: Warning (reg_format): /fragment@0/__overlay__/spidev@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts:19.5-15: Warning (reg_format): /fragment@0/__overlay__/spidev@1:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) Add the missing "#{address,size}-cells" to fix this. Signed-off-by: Geert Uytterhoeven --- .../staging/pi433/Documentation/devicetree/pi433-overlay.dts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts b/drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts index dfc9f974ac24ecc1..b584180d78d019aa 100644 --- a/drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts +++ b/drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts @@ -8,13 +8,17 @@ fragment@0 { target = <&spi0>; __overlay__ { + #address-cells = <1>; + #size-cells = <0>; status = "okay"; spidev@0{ + reg = <0>; status = "disabled"; }; spidev@1{ + reg = <1>; status = "disabled"; }; };