From patchwork Wed Oct 21 18:31:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 318876 Delivered-To: patch@linaro.org Received: by 2002:a92:d1d1:0:0:0:0:0 with SMTP id u17csp2420423ilg; Wed, 21 Oct 2020 11:31:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwPcI1TaeNSbKGxVf/1CW0cukLQSPue6Im7tgW9H+IztKHCzx70sYYgADOvkbAWbVhvGiUO X-Received: by 2002:a17:906:16c6:: with SMTP id t6mr4715982ejd.453.1603305080913; Wed, 21 Oct 2020 11:31:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603305080; cv=none; d=google.com; s=arc-20160816; b=MMZ6yzFlP+dWi3m5xk/vFamoPOrnbTV7+zPeOED4iUBG/Krro9f23pcTJi51bsAgut bRrXIgmKv1ACvtWVZRsXG+lBsTXl0Ft6cfcg3ZYc2hX3BmKtDhEM3O8sFxoBu4rObtTP MczGiRNieQP3Frm4QK/4E5G+wm3N3fS7GZNhEyo0AJy1Ufq0bHgpHiONrZyXqev1whWD GCXsIdG1Tr29w+qQsI6XiOxDo+Y//lqM9R3EzBpYLdJQmykFraYyJ4mPm2GpKS545KmU KxnyzPSivhV2zV8KdrOjKMUSxGgzsH972jZh5IMgCzJfcDvC4fjU2FEyUK6XNiveo9xs 44Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=qE8ySXCLR0tBzahyaeGWkpjsQNGk8P+dB35d3VoyIaw=; b=rmgH9iSTTmPKNtycZtj9+ImyNJdHX1kppHZ6rkEOTHWZi2lhU/qXWq9Ty49OnAeHkH dVCfxuoYH/y0vjUWP1GlHrHZLqxynxI3k4w72zAQ+vnE1h2QxfaGLOA45zPGm8jyxkpo Q9WHLuS8Ww8wAHaYj8x5KiMnnHJ5uQqaxIVptcLDIu1GwBTDiENAlm6LzoWU0MLlm9Fr aMKzMALzSg8FdyZ3Y/FVWdv7nnn9zq70V9QZvUcWI+fiRQit3GSBkiNpCSK75jqy7mdH TnCmrPNafaHkq5szAnyh1D0B2KgfqG1N0+uEjtFaPw1SBQpogPSv0mFSiW45pho3+oc5 YEDw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j8si1905500ejt.416.2020.10.21.11.31.20; Wed, 21 Oct 2020 11:31:20 -0700 (PDT) Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504121AbgJUSbU (ORCPT + 6 others); Wed, 21 Oct 2020 14:31:20 -0400 Received: from foss.arm.com ([217.140.110.172]:38642 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2504119AbgJUSbU (ORCPT ); Wed, 21 Oct 2020 14:31:20 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5D61B142F; Wed, 21 Oct 2020 11:31:14 -0700 (PDT) Received: from usa.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 701D93F66B; Wed, 21 Oct 2020 11:31:13 -0700 (PDT) From: Sudeep Holla To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: Sudeep Holla , linux-arm-kernel@lists.infradead.org, Rob Herring , Viresh Kumar Subject: [PATCH v2 2/2] firmware: arm_scmi: Move away from clock devicetree bindings Date: Wed, 21 Oct 2020 19:31:04 +0100 Message-Id: <20201021183104.27949-2-sudeep.holla@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201021183104.27949-1-sudeep.holla@arm.com> References: <20201021183104.27949-1-sudeep.holla@arm.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Commit dd461cd9183f ("opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER") handles -EPROBE_DEFER for the clock/interconnects within _allocate_opp_table() which is called from dev_pm_opp_add and it now propagates the error back to the caller. This breaks SCMI performance domains as we will never succeed to add any OPPs. A quick fix would be to register dummy clocks which is completely ugly and bigger fix which may break with some other change in future. It is better to add separate binding for the same and use it. A separate SCMI performance domain binding is introduced and let us use it here. Signed-off-by: Sudeep Holla --- drivers/firmware/arm_scmi/perf.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.17.1 diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c index 3e1e87012c95..a79c095662a7 100644 --- a/drivers/firmware/arm_scmi/perf.c +++ b/drivers/firmware/arm_scmi/perf.c @@ -629,13 +629,13 @@ static void scmi_perf_domain_init_fc(const struct scmi_handle *handle, /* Device specific ops */ static int scmi_dev_domain_id(struct device *dev) { - struct of_phandle_args clkspec; + struct of_phandle_args spec; - if (of_parse_phandle_with_args(dev->of_node, "clocks", "#clock-cells", - 0, &clkspec)) + if (of_parse_phandle_with_args(dev->of_node, "arm,scmi-perf-domain", + "#arm,scmi-perf-domain-cells", 0, &spec)) return -EINVAL; - return clkspec.args[0]; + return spec.args[0]; } static int scmi_dvfs_device_opps_add(const struct scmi_handle *handle,