diff mbox series

[42/46] dt-bindings:iio:accel:fsl,mma8452: txt to yaml conversion.

Message ID 20201031184854.745828-43-jic23@kernel.org
State New
Headers show
Series dt-bindings:iio: yet more txt to yam conversions | expand

Commit Message

Jonathan Cameron Oct. 31, 2020, 6:48 p.m. UTC
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Simple binding so mostly straight forward to convert.
Original binding was unclear on how many interrupts there are.
The device has two such lines, whilst I believe the driver currently
only uses one at a time.  The binding should allow both to be specified.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Martin Kepplinger <martin.kepplinger@theobroma-systems.com>
---
 .../bindings/iio/accel/fsl,mma8452.yaml       | 62 +++++++++++++++++++
 .../devicetree/bindings/iio/accel/mma8452.txt | 35 -----------
 2 files changed, 62 insertions(+), 35 deletions(-)

Comments

Rob Herring (Arm) Nov. 3, 2020, 4:34 p.m. UTC | #1
On Sat, Oct 31, 2020 at 06:48:50PM +0000, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> 

> Simple binding so mostly straight forward to convert.

> Original binding was unclear on how many interrupts there are.

> The device has two such lines, whilst I believe the driver currently

> only uses one at a time.  The binding should allow both to be specified.

> 

> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> Cc: Martin Kepplinger <martin.kepplinger@theobroma-systems.com>

> ---

>  .../bindings/iio/accel/fsl,mma8452.yaml       | 62 +++++++++++++++++++

>  .../devicetree/bindings/iio/accel/mma8452.txt | 35 -----------

>  2 files changed, 62 insertions(+), 35 deletions(-)

> 

> diff --git a/Documentation/devicetree/bindings/iio/accel/fsl,mma8452.yaml b/Documentation/devicetree/bindings/iio/accel/fsl,mma8452.yaml

> new file mode 100644

> index 000000000000..3b8e5ebdf90c

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/iio/accel/fsl,mma8452.yaml

> @@ -0,0 +1,62 @@

> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)

> +%YAML 1.2

> +---

> +$id: http://devicetree.org/schemas/iio/accel/fsl,mma8452.yaml#

> +$schema: http://devicetree.org/meta-schemas/core.yaml#

> +

> +title:

> +  Freescale MMA8451Q, MMA8452Q, MMA8453Q, MMA8652FC, MMA8653FC or FXLS8471Q

> +  triaxial accelerometer

> +

> +maintainers:

> +  - Martin Kepplinger <martin.kepplinger@theobroma-systems.com>

> +

> +properties:

> +  compatible:

> +    enum:

> +      - fsl,mma8451

> +      - fsl,mma8452

> +      - fsl,mma8453

> +      - fsl,mma8652

> +      - fsl,mma8653

> +      - fsl,fxls8471

> +

> +  reg:

> +    maxItems: 1

> +

> +  interrupts:

> +    description:

> +      2 highly configurable interrupt lines exist.

> +    minItems: 1

> +    maxItems: 2

> +

> +  interrupt-names:

> +    description: Specify which interrupt line is in use.

> +    enum:

> +      - INT1

> +      - INT2


This will default to only 1 item allowed. You need minItems/maxItems.

> +

> +  vdd-supply: true

> +  vddio-supply: true

> +

> +required:

> +  - compatible

> +  - reg

> +

> +additionalProperties: false

> +

> +examples:

> +  - |

> +    i2c {

> +        #address-cells = <1>;

> +        #size-cells = <0>;

> +

> +        accel@1d {

> +            compatible = "fsl,mma8453";

> +            reg = <0x1d>;

> +            interrupt-parent = <&gpio1>;

> +            interrupts = <5 0>;

> +            interrupt-names = "INT2";

> +        };

> +    };

> +...

> diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/Documentation/devicetree/bindings/iio/accel/mma8452.txt

> deleted file mode 100644

> index e132394375a1..000000000000

> --- a/Documentation/devicetree/bindings/iio/accel/mma8452.txt

> +++ /dev/null

> @@ -1,35 +0,0 @@

> -Freescale MMA8451Q, MMA8452Q, MMA8453Q, MMA8652FC, MMA8653FC or FXLS8471Q

> -triaxial accelerometer

> -

> -Required properties:

> -

> -  - compatible: should contain one of

> -    * "fsl,mma8451"

> -    * "fsl,mma8452"

> -    * "fsl,mma8453"

> -    * "fsl,mma8652"

> -    * "fsl,mma8653"

> -    * "fsl,fxls8471"

> -

> -  - reg: the I2C address of the chip

> -

> -Optional properties:

> -

> -  - interrupts: interrupt mapping for GPIO IRQ

> -

> -  - interrupt-names: should contain "INT1" and/or "INT2", the accelerometer's

> -		     interrupt line in use.

> -

> -  - vdd-supply: phandle to the regulator that provides vdd power to the accelerometer.

> -

> -  - vddio-supply: phandle to the regulator that provides vddio power to the accelerometer.

> -

> -Example:

> -

> -	mma8453fc@1d {

> -		compatible = "fsl,mma8453";

> -		reg = <0x1d>;

> -		interrupt-parent = <&gpio1>;

> -		interrupts = <5 0>;

> -		interrupt-names = "INT2";

> -	};

> -- 

> 2.28.0

>
Jonathan Cameron Nov. 22, 2020, 6:50 p.m. UTC | #2
On Tue, 3 Nov 2020 10:34:07 -0600
Rob Herring <robh@kernel.org> wrote:

> On Sat, Oct 31, 2020 at 06:48:50PM +0000, Jonathan Cameron wrote:

> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> > 

> > Simple binding so mostly straight forward to convert.

> > Original binding was unclear on how many interrupts there are.

> > The device has two such lines, whilst I believe the driver currently

> > only uses one at a time.  The binding should allow both to be specified.

> > 

> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> > Cc: Martin Kepplinger <martin.kepplinger@theobroma-systems.com>

> > ---

> >  .../bindings/iio/accel/fsl,mma8452.yaml       | 62 +++++++++++++++++++

> >  .../devicetree/bindings/iio/accel/mma8452.txt | 35 -----------

> >  2 files changed, 62 insertions(+), 35 deletions(-)

> > 

> > diff --git a/Documentation/devicetree/bindings/iio/accel/fsl,mma8452.yaml b/Documentation/devicetree/bindings/iio/accel/fsl,mma8452.yaml

> > new file mode 100644

> > index 000000000000..3b8e5ebdf90c

> > --- /dev/null

> > +++ b/Documentation/devicetree/bindings/iio/accel/fsl,mma8452.yaml

> > @@ -0,0 +1,62 @@

> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)

> > +%YAML 1.2

> > +---

> > +$id: http://devicetree.org/schemas/iio/accel/fsl,mma8452.yaml#

> > +$schema: http://devicetree.org/meta-schemas/core.yaml#

> > +

> > +title:

> > +  Freescale MMA8451Q, MMA8452Q, MMA8453Q, MMA8652FC, MMA8653FC or FXLS8471Q

> > +  triaxial accelerometer

> > +

> > +maintainers:

> > +  - Martin Kepplinger <martin.kepplinger@theobroma-systems.com>

> > +

> > +properties:

> > +  compatible:

> > +    enum:

> > +      - fsl,mma8451

> > +      - fsl,mma8452

> > +      - fsl,mma8453

> > +      - fsl,mma8652

> > +      - fsl,mma8653

> > +      - fsl,fxls8471

> > +

> > +  reg:

> > +    maxItems: 1

> > +

> > +  interrupts:

> > +    description:

> > +      2 highly configurable interrupt lines exist.

> > +    minItems: 1

> > +    maxItems: 2

> > +

> > +  interrupt-names:

> > +    description: Specify which interrupt line is in use.

> > +    enum:

> > +      - INT1

> > +      - INT2  

> 

> This will default to only 1 item allowed. You need minItems/maxItems.

> 

Done, plus stuck the enum under an items: to avoid a build error.

Thanks,

Jonathan

> > +

> > +  vdd-supply: true

> > +  vddio-supply: true

> > +

> > +required:

> > +  - compatible

> > +  - reg

> > +

> > +additionalProperties: false

> > +

> > +examples:

> > +  - |

> > +    i2c {

> > +        #address-cells = <1>;

> > +        #size-cells = <0>;

> > +

> > +        accel@1d {

> > +            compatible = "fsl,mma8453";

> > +            reg = <0x1d>;

> > +            interrupt-parent = <&gpio1>;

> > +            interrupts = <5 0>;

> > +            interrupt-names = "INT2";

> > +        };

> > +    };

> > +...

> > diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/Documentation/devicetree/bindings/iio/accel/mma8452.txt

> > deleted file mode 100644

> > index e132394375a1..000000000000

> > --- a/Documentation/devicetree/bindings/iio/accel/mma8452.txt

> > +++ /dev/null

> > @@ -1,35 +0,0 @@

> > -Freescale MMA8451Q, MMA8452Q, MMA8453Q, MMA8652FC, MMA8653FC or FXLS8471Q

> > -triaxial accelerometer

> > -

> > -Required properties:

> > -

> > -  - compatible: should contain one of

> > -    * "fsl,mma8451"

> > -    * "fsl,mma8452"

> > -    * "fsl,mma8453"

> > -    * "fsl,mma8652"

> > -    * "fsl,mma8653"

> > -    * "fsl,fxls8471"

> > -

> > -  - reg: the I2C address of the chip

> > -

> > -Optional properties:

> > -

> > -  - interrupts: interrupt mapping for GPIO IRQ

> > -

> > -  - interrupt-names: should contain "INT1" and/or "INT2", the accelerometer's

> > -		     interrupt line in use.

> > -

> > -  - vdd-supply: phandle to the regulator that provides vdd power to the accelerometer.

> > -

> > -  - vddio-supply: phandle to the regulator that provides vddio power to the accelerometer.

> > -

> > -Example:

> > -

> > -	mma8453fc@1d {

> > -		compatible = "fsl,mma8453";

> > -		reg = <0x1d>;

> > -		interrupt-parent = <&gpio1>;

> > -		interrupts = <5 0>;

> > -		interrupt-names = "INT2";

> > -	};

> > -- 

> > 2.28.0

> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/accel/fsl,mma8452.yaml b/Documentation/devicetree/bindings/iio/accel/fsl,mma8452.yaml
new file mode 100644
index 000000000000..3b8e5ebdf90c
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/accel/fsl,mma8452.yaml
@@ -0,0 +1,62 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/accel/fsl,mma8452.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title:
+  Freescale MMA8451Q, MMA8452Q, MMA8453Q, MMA8652FC, MMA8653FC or FXLS8471Q
+  triaxial accelerometer
+
+maintainers:
+  - Martin Kepplinger <martin.kepplinger@theobroma-systems.com>
+
+properties:
+  compatible:
+    enum:
+      - fsl,mma8451
+      - fsl,mma8452
+      - fsl,mma8453
+      - fsl,mma8652
+      - fsl,mma8653
+      - fsl,fxls8471
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    description:
+      2 highly configurable interrupt lines exist.
+    minItems: 1
+    maxItems: 2
+
+  interrupt-names:
+    description: Specify which interrupt line is in use.
+    enum:
+      - INT1
+      - INT2
+
+  vdd-supply: true
+  vddio-supply: true
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        accel@1d {
+            compatible = "fsl,mma8453";
+            reg = <0x1d>;
+            interrupt-parent = <&gpio1>;
+            interrupts = <5 0>;
+            interrupt-names = "INT2";
+        };
+    };
+...
diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
deleted file mode 100644
index e132394375a1..000000000000
--- a/Documentation/devicetree/bindings/iio/accel/mma8452.txt
+++ /dev/null
@@ -1,35 +0,0 @@ 
-Freescale MMA8451Q, MMA8452Q, MMA8453Q, MMA8652FC, MMA8653FC or FXLS8471Q
-triaxial accelerometer
-
-Required properties:
-
-  - compatible: should contain one of
-    * "fsl,mma8451"
-    * "fsl,mma8452"
-    * "fsl,mma8453"
-    * "fsl,mma8652"
-    * "fsl,mma8653"
-    * "fsl,fxls8471"
-
-  - reg: the I2C address of the chip
-
-Optional properties:
-
-  - interrupts: interrupt mapping for GPIO IRQ
-
-  - interrupt-names: should contain "INT1" and/or "INT2", the accelerometer's
-		     interrupt line in use.
-
-  - vdd-supply: phandle to the regulator that provides vdd power to the accelerometer.
-
-  - vddio-supply: phandle to the regulator that provides vddio power to the accelerometer.
-
-Example:
-
-	mma8453fc@1d {
-		compatible = "fsl,mma8453";
-		reg = <0x1d>;
-		interrupt-parent = <&gpio1>;
-		interrupts = <5 0>;
-		interrupt-names = "INT2";
-	};