From patchwork Wed Mar 10 15:45:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 396735 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp483356jai; Wed, 10 Mar 2021 07:47:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJwoaaOU26FX7H/WwmuY87GovDfLkJJdhlqOhTLfZIxpsus+UVuDn/SdyY0dSC+2ogXq3ith X-Received: by 2002:a17:906:73d5:: with SMTP id n21mr4498660ejl.8.1615391239298; Wed, 10 Mar 2021 07:47:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615391239; cv=none; d=google.com; s=arc-20160816; b=r7f23/LL3XdAvCJGhnZQ6vdN7adepc7txGxQ3X80RmsKS+YSW66mXbYVAiJ8lBsSkg MK8toja/lrHGDyYQyZLYdm46ChygAM777chiCC6btID791SRudYW8gGFwDKJNM++TI3k Ssi1Tj1sCT/c9/FeQOAWcyHdnyU0X8tlg6PzTpZ3onxV3/NVZeFRtffPkpN4hKMQMs9q U4Q/hf01uaUmRpi1mskd7/GpOVmWHGhUfX1+cY+9dsHk91WNm4ECpU8znrMHZ2EgYmxo 4SB3TvRonXF/9kNCVBXWfcMujuL9Xt2/1fsmt1B+BNtxeiAA44+gyMvfLpuxfq4YCXEk +zow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Fr9ZyGLW31JmJAp0IyWK9eWBsQt1ma4OyJ8An42gTxI=; b=EMcRnat+Bu8xoK0mbZ9Th+MP2F2VgM1z4C41DSUcwf32j6rbIn+/PjW/qKtvdEZOK/ gkAIv6JlbUndxF0JomK+z+NhiKDKUCJsyMk7QB8amqBAikpXWezoyU+s/gJxmT7Xo2Ef w78eIXKYtf8U15HgHTyeKihdJ7GWr59sDTLppcFSYIZxekhOSCvPcSxWHd7tILsA43py cRY4C6u0rFWKTkb5eXPKsZV+DFUB4KBECjg3WRsDNMwzWJWPTel4RjxUi4YUyIS2eBAJ IQq2AFwONFI3sDJ1ZwM5qQlUd95fNQ2S7tyqJTqXsbLZr7cOsyz2Zc3sUqYXwcb8BUaF UWsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=y2PMiwzW; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t3si4576077ejy.142.2021.03.10.07.47.19; Wed, 10 Mar 2021 07:47:19 -0800 (PST) Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=y2PMiwzW; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233257AbhCJPqp (ORCPT + 6 others); Wed, 10 Mar 2021 10:46:45 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:43896 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233232AbhCJPql (ORCPT ); Wed, 10 Mar 2021 10:46:41 -0500 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 12AFka7h117406; Wed, 10 Mar 2021 09:46:36 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1615391196; bh=Fr9ZyGLW31JmJAp0IyWK9eWBsQt1ma4OyJ8An42gTxI=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=y2PMiwzWjSsQKas+utyxD1tTNlJ+/l6LepdDa/RqgMy4dvl/WaE5034Qe2Q5YVqry 2y/PIhXdlPoa/hUQhki9kLnEshpWVV6z73VG/epYHuVgvQwKtWUTzYWtf119dlvfv1 BfFZemAtAYrpOs6U4mD0Siy+s5PdfbxqTm/hrgrA= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 12AFkapM015130 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 10 Mar 2021 09:46:36 -0600 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 10 Mar 2021 09:46:36 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Wed, 10 Mar 2021 09:46:36 -0600 Received: from a0393678-ssd.dhcp.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 12AFk2KY066370; Wed, 10 Mar 2021 09:46:33 -0600 From: Kishon Vijay Abraham I To: Kishon Vijay Abraham I , Vinod Koul , Rob Herring , Philipp Zabel , Swapnil Jakhade CC: , , Lokesh Vutla Subject: [PATCH v6 10/13] phy: cadence: cadence-sierra: Add missing clk_disable_unprepare() in .remove callback Date: Wed, 10 Mar 2021 21:15:55 +0530 Message-ID: <20210310154558.32078-11-kishon@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210310154558.32078-1-kishon@ti.com> References: <20210310154558.32078-1-kishon@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org commit 44d30d622821 ("phy: cadence: Add driver for Sierra PHY") enabled the clock in probe and failed to disable in remove callback. Add missing clk_disable_unprepare() in cdns_sierra_phy_remove(). Fixes: 44d30d622821 ("phy: cadence: Add driver for Sierra PHY") Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/cadence/phy-cadence-sierra.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.17.1 diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c index a45278c30948..ac32b7b0289f 100644 --- a/drivers/phy/cadence/phy-cadence-sierra.c +++ b/drivers/phy/cadence/phy-cadence-sierra.c @@ -689,6 +689,9 @@ static int cdns_sierra_phy_remove(struct platform_device *pdev) reset_control_assert(phy->phys[i].lnk_rst); reset_control_put(phy->phys[i].lnk_rst); } + + clk_disable_unprepare(phy->input_clks[PHY_CLK]); + return 0; }