diff mbox series

[3/4] arm64: dts: realtek: rtd16xx: normalize the node name of the UART devices

Message ID 20210519141914.8044-4-thunder.leizhen@huawei.com
State New
Headers show
Series Clear some dtbs_check warnings detected by snps-dw-apb-uart.yaml | expand

Commit Message

Leizhen (ThunderTown) May 19, 2021, 2:19 p.m. UTC
Change the node name of the UART devices to match
"^serial(@[0-9a-f,]+)*$".

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

---
 arch/arm64/boot/dts/realtek/rtd16xx.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.21.1

Comments

Andreas Färber May 19, 2021, 2:31 p.m. UTC | #1
Hi,

On 19.05.21 16:19, Zhen Lei wrote:
> Change the node name of the UART devices to match

> "^serial(@[0-9a-f,]+)*$".

> 

> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

> ---

>  arch/arm64/boot/dts/realtek/rtd16xx.dtsi | 6 +++---

>  1 file changed, 3 insertions(+), 3 deletions(-)

> 

> diff --git a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi

> index afba5f04c8ec..bf4d9e917925 100644

> --- a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi

> +++ b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi

> @@ -195,7 +195,7 @@

>  };

>  

>  &iso {

> -	uart0: serial0@800 {

> +	uart0: serial@800 {

[snip]

Ouch, shame on me for not catching this in review...

Reviewed-by: Andreas Färber <afaerber@suse.de>


Are you expecting this to go through the four maintainer trees or
centrally somehow?

Thanks,
Andreas

-- 
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
Leizhen (ThunderTown) May 19, 2021, 2:46 p.m. UTC | #2
On 2021/5/19 22:31, Andreas Färber wrote:
> Hi,

> 

> On 19.05.21 16:19, Zhen Lei wrote:

>> Change the node name of the UART devices to match

>> "^serial(@[0-9a-f,]+)*$".

>>

>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

>> ---

>>  arch/arm64/boot/dts/realtek/rtd16xx.dtsi | 6 +++---

>>  1 file changed, 3 insertions(+), 3 deletions(-)

>>

>> diff --git a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi

>> index afba5f04c8ec..bf4d9e917925 100644

>> --- a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi

>> +++ b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi

>> @@ -195,7 +195,7 @@

>>  };

>>  

>>  &iso {

>> -	uart0: serial0@800 {

>> +	uart0: serial@800 {

> [snip]

> 

> Ouch, shame on me for not catching this in review...

> 

> Reviewed-by: Andreas Färber <afaerber@suse.de>

> 

> Are you expecting this to go through the four maintainer trees or

> centrally somehow?


It would be nice for each maintainer to add its own patch to its own tree.
Each patch is independent, I put these four patches together just for the
convenience of describing 0000-cover-letter

> 

> Thanks,

> Andreas

>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
index afba5f04c8ec..bf4d9e917925 100644
--- a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
+++ b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
@@ -195,7 +195,7 @@ 
 };
 
 &iso {
-	uart0: serial0@800 {
+	uart0: serial@800 {
 		compatible = "snps,dw-apb-uart";
 		reg = <0x800 0x400>;
 		reg-shift = <2>;
@@ -207,7 +207,7 @@ 
 };
 
 &misc {
-	uart1: serial1@200 {
+	uart1: serial@200 {
 		compatible = "snps,dw-apb-uart";
 		reg = <0x200 0x400>;
 		reg-shift = <2>;
@@ -217,7 +217,7 @@ 
 		status = "disabled";
 	};
 
-	uart2: serial2@400 {
+	uart2: serial@400 {
 		compatible = "snps,dw-apb-uart";
 		reg = <0x400 0x400>;
 		reg-shift = <2>;