diff mbox series

[2/2] dt-bindings: rtc: add Epson RX-8025 and RX-8035

Message ID 20210707071616.28976-3-matt@traverse.com.au
State Superseded
Headers show
Series Implement EPSON RX-8035 support | expand

Commit Message

Mathew McBride July 7, 2021, 7:16 a.m. UTC 
These are supported by the rtc-rx8025 module. RX-8025
also has support in ds1307 due to compatible time registers.

Signed-off-by: Mathew McBride <matt@traverse.com.au>

---
 Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.30.1

Comments

Nobuhiro Iwamatsu July 7, 2021, 9:46 p.m. UTC | #1 
Hi,

2021年7月7日(水) 16:17 Mathew McBride <matt@traverse.com.au>:
>

> These are supported by the rtc-rx8025 module. RX-8025

> also has support in ds1307 due to compatible time registers.

>

> Signed-off-by: Mathew McBride <matt@traverse.com.au>

> ---

>  Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 3 +++

>  1 file changed, 3 insertions(+)

>

> diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml

> index 7548d8714871..13925bb78ec7 100644

> --- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml

> +++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml

> @@ -32,6 +32,9 @@ properties:

>        - dallas,ds3232

>        # I2C-BUS INTERFACE REAL TIME CLOCK MODULE

>        - epson,rx8010

> +      # I2C-BUS INTERFACE REAL TIME CLOCK MODULE

> +      - epson,rx8025

> +      - epson,rx8035


'epson,rx8035' is unnsecessary.
This lists compatible string, so we don't list compatible that doesn't exist.

>        # I2C-BUS INTERFACE REAL TIME CLOCK MODULE with Battery Backed RAM

>        - epson,rx8571

>        # I2C-BUS INTERFACE REAL TIME CLOCK MODULE

> --

> 2.30.1

>


Best regards,
  Nobuhiro


--
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org / kernel.org}
   GPG ID: 40AD1FA6
Alexandre Belloni July 7, 2021, 9:52 p.m. UTC | #2 
On 08/07/2021 06:46:31+0900, Nobuhiro Iwamatsu wrote:
> Hi,

> 

> 2021年7月7日(水) 16:17 Mathew McBride <matt@traverse.com.au>:

> >

> > These are supported by the rtc-rx8025 module. RX-8025

> > also has support in ds1307 due to compatible time registers.

> >

> > Signed-off-by: Mathew McBride <matt@traverse.com.au>

> > ---

> >  Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 3 +++

> >  1 file changed, 3 insertions(+)

> >

> > diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml

> > index 7548d8714871..13925bb78ec7 100644

> > --- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml

> > +++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml

> > @@ -32,6 +32,9 @@ properties:

> >        - dallas,ds3232

> >        # I2C-BUS INTERFACE REAL TIME CLOCK MODULE

> >        - epson,rx8010

> > +      # I2C-BUS INTERFACE REAL TIME CLOCK MODULE

> > +      - epson,rx8025

> > +      - epson,rx8035

> 

> 'epson,rx8035' is unnsecessary.

> This lists compatible string, so we don't list compatible that doesn't exist.

> 


Well, the previous patch adds it.


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Nobuhiro Iwamatsu July 9, 2021, 7:19 a.m. UTC | #3 
Hi,

2021年7月8日(木) 6:52 Alexandre Belloni <alexandre.belloni@bootlin.com>:
>

> On 08/07/2021 06:46:31+0900, Nobuhiro Iwamatsu wrote:

> > Hi,

> >

> > 2021年7月7日(水) 16:17 Mathew McBride <matt@traverse.com.au>:

> > >

> > > These are supported by the rtc-rx8025 module. RX-8025

> > > also has support in ds1307 due to compatible time registers.

> > >

> > > Signed-off-by: Mathew McBride <matt@traverse.com.au>

> > > ---

> > >  Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 3 +++

> > >  1 file changed, 3 insertions(+)

> > >

> > > diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml

> > > index 7548d8714871..13925bb78ec7 100644

> > > --- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml

> > > +++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml

> > > @@ -32,6 +32,9 @@ properties:

> > >        - dallas,ds3232

> > >        # I2C-BUS INTERFACE REAL TIME CLOCK MODULE

> > >        - epson,rx8010

> > > +      # I2C-BUS INTERFACE REAL TIME CLOCK MODULE

> > > +      - epson,rx8025

> > > +      - epson,rx8035

> >

> > 'epson,rx8035' is unnsecessary.

> > This lists compatible string, so we don't list compatible that doesn't exist.

> >

>

> Well, the previous patch adds it.

>


I couldn't find anything to add "epson,rx8035" as device tree compatible in
previous patch(rtc: rx8025: implement RX-8035 support)....
I think that i2c_device_id was added and it is not device tree compatible.
Can you tell me if my understanding is wrong?

Best regards,
  Nobuhiro
--
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6
Alexandre Belloni July 10, 2021, 12:40 a.m. UTC | #4 
Hello,

On 09/07/2021 16:19:49+0900, Nobuhiro Iwamatsu wrote:
> Hi,

> 

> 2021年7月8日(木) 6:52 Alexandre Belloni <alexandre.belloni@bootlin.com>:

> >

> > On 08/07/2021 06:46:31+0900, Nobuhiro Iwamatsu wrote:

> > > Hi,

> > >

> > > 2021年7月7日(水) 16:17 Mathew McBride <matt@traverse.com.au>:

> > > >

> > > > These are supported by the rtc-rx8025 module. RX-8025

> > > > also has support in ds1307 due to compatible time registers.

> > > >

> > > > Signed-off-by: Mathew McBride <matt@traverse.com.au>

> > > > ---

> > > >  Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 3 +++

> > > >  1 file changed, 3 insertions(+)

> > > >

> > > > diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml

> > > > index 7548d8714871..13925bb78ec7 100644

> > > > --- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml

> > > > +++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml

> > > > @@ -32,6 +32,9 @@ properties:

> > > >        - dallas,ds3232

> > > >        # I2C-BUS INTERFACE REAL TIME CLOCK MODULE

> > > >        - epson,rx8010

> > > > +      # I2C-BUS INTERFACE REAL TIME CLOCK MODULE

> > > > +      - epson,rx8025

> > > > +      - epson,rx8035

> > >

> > > 'epson,rx8035' is unnsecessary.

> > > This lists compatible string, so we don't list compatible that doesn't exist.

> > >

> >

> > Well, the previous patch adds it.

> >

> 

> I couldn't find anything to add "epson,rx8035" as device tree compatible in

> previous patch(rtc: rx8025: implement RX-8035 support)....

> I think that i2c_device_id was added and it is not device tree compatible.

> Can you tell me if my understanding is wrong?


Having "rx8035" in the struct i2c_device_id array is enough to have the
driver probed using DT. IIRC, it is a side effect of
i2c_of_match_device_sysfs()

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Nobuhiro Iwamatsu July 12, 2021, 12:02 a.m. UTC | #5 
Hi,

2021年7月10日(土) 9:41 Alexandre Belloni <alexandre.belloni@bootlin.com>:
>
> Hello,
>
> On 09/07/2021 16:19:49+0900, Nobuhiro Iwamatsu wrote:
> > Hi,
> >
> > 2021年7月8日(木) 6:52 Alexandre Belloni <alexandre.belloni@bootlin.com>:
> > >
> > > On 08/07/2021 06:46:31+0900, Nobuhiro Iwamatsu wrote:
> > > > Hi,
> > > >
> > > > 2021年7月7日(水) 16:17 Mathew McBride <matt@traverse.com.au>:
> > > > >
> > > > > These are supported by the rtc-rx8025 module. RX-8025
> > > > > also has support in ds1307 due to compatible time registers.
> > > > >
> > > > > Signed-off-by: Mathew McBride <matt@traverse.com.au>
> > > > > ---
> > > > >  Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 3 +++
> > > > >  1 file changed, 3 insertions(+)
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> > > > > index 7548d8714871..13925bb78ec7 100644
> > > > > --- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> > > > > +++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> > > > > @@ -32,6 +32,9 @@ properties:
> > > > >        - dallas,ds3232
> > > > >        # I2C-BUS INTERFACE REAL TIME CLOCK MODULE
> > > > >        - epson,rx8010
> > > > > +      # I2C-BUS INTERFACE REAL TIME CLOCK MODULE
> > > > > +      - epson,rx8025
> > > > > +      - epson,rx8035
> > > >
> > > > 'epson,rx8035' is unnsecessary.
> > > > This lists compatible string, so we don't list compatible that doesn't exist.
> > > >
> > >
> > > Well, the previous patch adds it.
> > >
> >
> > I couldn't find anything to add "epson,rx8035" as device tree compatible in
> > previous patch(rtc: rx8025: implement RX-8035 support)....
> > I think that i2c_device_id was added and it is not device tree compatible.
> > Can you tell me if my understanding is wrong?
>
> Having "rx8035" in the struct i2c_device_id array is enough to have the
> driver probed using DT. IIRC, it is a side effect of
> i2c_of_match_device_sysfs()

I understood. Thanks for the explanation.

Best regards,
  Nobuhiro
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
index 7548d8714871..13925bb78ec7 100644
--- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
@@ -32,6 +32,9 @@  properties:
       - dallas,ds3232
       # I2C-BUS INTERFACE REAL TIME CLOCK MODULE
       - epson,rx8010
+      # I2C-BUS INTERFACE REAL TIME CLOCK MODULE
+      - epson,rx8025
+      - epson,rx8035
       # I2C-BUS INTERFACE REAL TIME CLOCK MODULE with Battery Backed RAM
       - epson,rx8571
       # I2C-BUS INTERFACE REAL TIME CLOCK MODULE