[v7,05/10] pwm: dwc: use devm_pwmchip_add

Message ID	20221223153820.404565-6-ben.dooks@sifive.com
State	Accepted
Commit	cf70d01a62c712ee715df1f7892b58c77474bcfb
Headers	show Return-Path: <devicetree-owner@vger.kernel.org> From: Ben Dooks <ben.dooks@sifive.com> To: linux-pwm@vger.kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>, u.kleine-koenig@pengutronix.de, Thierry Reding <thierry.reding@gmail.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Greentime Hu <greentime.hu@sifive.com>, jarkko.nikula@linux.intel.com, William Salmon <william.salmon@sifive.com>, Jude Onyenegecha <jude.onyenegecha@sifive.com>, Ben Dooks <ben.dooks@sifive.com> Subject: [PATCH v7 05/10] pwm: dwc: use devm_pwmchip_add Date: Fri, 23 Dec 2022 15:38:15 +0000 Message-Id: <20221223153820.404565-6-ben.dooks@sifive.com> In-Reply-To: <20221223153820.404565-1-ben.dooks@sifive.com> References: <20221223153820.404565-1-ben.dooks@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	Designware PWM driver updates for OF \| expand [v7,00/10] Designware PWM driver updates for OF [v7,01/10] dt-bindings: pwm: Document Synopsys DesignWare snps,pwm-dw-apb-timers-pwm2 [v7,02/10] pwm: dwc: allow driver to be built with COMPILE_TEST [v7,03/10] pwm: dwc: change &pci->dev to dev in probe [v7,04/10] pwm: dwc: move memory alloc to own function [v7,05/10] pwm: dwc: use devm_pwmchip_add [v7,06/10] pwm: dwc: split pci out of core driver [v7,07/10] pwm: dwc: make timer clock configurable [v7,08/10] pwm: dwc: add of/platform support [v7,09/10] pwm: dwc: add PWM bit unset in get_state call [v7,10/10] pwm: dwc: use clock rate in hz to avoid rounding issues

Message ID

20221223153820.404565-6-ben.dooks@sifive.com

State

Accepted

Commit

cf70d01a62c712ee715df1f7892b58c77474bcfb

Headers

From: Ben Dooks <ben.dooks@sifive.com>
To: linux-pwm@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Lee Jones <lee.jones@linaro.org>,
        u.kleine-koenig@pengutronix.de,
        Thierry Reding <thierry.reding@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Greentime Hu <greentime.hu@sifive.com>,
        jarkko.nikula@linux.intel.com,
        William Salmon <william.salmon@sifive.com>,
        Jude Onyenegecha <jude.onyenegecha@sifive.com>,
        Ben Dooks <ben.dooks@sifive.com>
Subject: [PATCH v7 05/10] pwm: dwc: use devm_pwmchip_add
Date: Fri, 23 Dec 2022 15:38:15 +0000
Message-Id: <20221223153820.404565-6-ben.dooks@sifive.com>
In-Reply-To: <20221223153820.404565-1-ben.dooks@sifive.com>
References: <20221223153820.404565-1-ben.dooks@sifive.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

Designware PWM driver updates for OF | expand

Commit Message

Ben Dooks Dec. 23, 2022, 3:38 p.m. UTC

Use devm_pwmchip_add() to add the pwm chip to avoid having to manually
remove it (useful for the next patch which adds the platform-device
support).

Signed-off-by: Ben Dooks <ben.dooks@sifive.com>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/pwm/pwm-dwc.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/pwm/pwm-dwc.c b/drivers/pwm/pwm-dwc.c
index 61f11e0a9319..56cde9da2c0e 100644
--- a/drivers/pwm/pwm-dwc.c
+++ b/drivers/pwm/pwm-dwc.c
@@ -242,7 +242,7 @@  static int dwc_pwm_probe(struct pci_dev *pci, const struct pci_device_id *id)
 		return -ENOMEM;
 	}
 
-	ret = pwmchip_add(&dwc->chip);
+	ret = devm_pwmchip_add(dev, &dwc->chip);
 	if (ret)
 		return ret;
 
@@ -254,12 +254,8 @@  static int dwc_pwm_probe(struct pci_dev *pci, const struct pci_device_id *id)
 
 static void dwc_pwm_remove(struct pci_dev *pci)
 {
-	struct dwc_pwm *dwc = pci_get_drvdata(pci);
-
 	pm_runtime_forbid(&pci->dev);
 	pm_runtime_get_noresume(&pci->dev);
-
-	pwmchip_remove(&dwc->chip);
 }
 
 #ifdef CONFIG_PM_SLEEP

[v7,05/10] pwm: dwc: use devm_pwmchip_add

Commit Message

Patch