From patchwork Tue Mar 14 22:16:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andi Shyti X-Patchwork-Id: 663123 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 407CAC6FD1F for ; Tue, 14 Mar 2023 22:18:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229545AbjCNWSU (ORCPT ); Tue, 14 Mar 2023 18:18:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229794AbjCNWST (ORCPT ); Tue, 14 Mar 2023 18:18:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4D7F1B2FD; Tue, 14 Mar 2023 15:17:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4495961A10; Tue, 14 Mar 2023 22:16:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A679C433EF; Tue, 14 Mar 2023 22:16:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678832185; bh=k6ND9M97R7Y6FDO6pJHrq7idbQ0eBx7iEsqSwSpZ06c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=s2uXLj6lU0F32CIEEKAZl94GLY+fRaVfgi0h2/xRCFmluhqdjPz1qEYgtcbtMg3vS rJa4eQVOKrtR1lGlUJXWdt85OLb4SRgqgIOznjTeCM44hH+uzoUO12NqrySwOGcm8P pvk8bdUwCNOLKp1ixITaGPdW69b/cCK6TOM6evpidXTQ/0vNTZnFa58zTAAJjnVA1T Zv9UywpHGyvHSlL2454Chu8kFFUBLv1FrYE09m8d24CUWpy+9HAc8ZHjDNYIorAHC0 lwbwO6S+IkHbNQhCO0QsGIoz+tZUYS9l6ZIx3E/KD2APyRirsJ/LUvFwK4TaaWRL8L jTm/oAyYsOmTg== From: Andi Shyti To: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Wolfram Sang , Rob Herring , Krzysztof Kozlowski , Chris Packham , Ryan Chen , Andi Shyti Subject: [PATCH v5 3/3] i2c: mpc: Use i2c-scl-clk-low-timeout-us i2c property Date: Tue, 14 Mar 2023 23:16:14 +0100 Message-Id: <20230314221614.24205-1-andi.shyti@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230314215612.23741-4-andi.shyti@kernel.org> References: <20230314215612.23741-4-andi.shyti@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org "fsl,timeout" is marked as deprecated and replaced by the "i2c-scl-clk-low-timeout-us" i2c property. Use this latter and, in case it is missing, for back compatibility, check whether we still have "fsl,timeout" defined. Signed-off-by: Andi Shyti Reviewed-by: Chris Packham Tested-by: Chris Packham --- Hi, this should be the only patch where I forgot an 'ms'. It should be fixed now. Thanks, Chris. V4 -> v5 - replace /ms/us/ in the commit subject and in the comment. drivers/i2c/busses/i2c-mpc.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c index 87e5c1725750f..aec3ac387c579 100644 --- a/drivers/i2c/busses/i2c-mpc.c +++ b/drivers/i2c/busses/i2c-mpc.c @@ -843,8 +843,18 @@ static int fsl_i2c_probe(struct platform_device *op) mpc_i2c_setup_8xxx(op->dev.of_node, i2c, clock); } + /* + * "fsl,timeout" has been marked as deprecated and, to maintain + * backward compatibility, we will only look for it if + * "i2c-scl-clk-low-timeout-us" is not present. + */ result = of_property_read_u32(op->dev.of_node, - "fsl,timeout", &mpc_ops.timeout); + "i2c-scl-clk-low-timeout-us", + &mpc_ops.timeout); + if (result == -EINVAL) + result = of_property_read_u32(op->dev.of_node, + "fsl,timeout", &mpc_ops.timeout); + if (!result) { mpc_ops.timeout *= HZ / 1000000; if (mpc_ops.timeout < 5)