From patchwork Mon Jun 12 20:34:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 691772 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CE10C7EE43 for ; Mon, 12 Jun 2023 20:35:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234811AbjFLUfO (ORCPT ); Mon, 12 Jun 2023 16:35:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231935AbjFLUfE (ORCPT ); Mon, 12 Jun 2023 16:35:04 -0400 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2082.outbound.protection.outlook.com [40.107.8.82]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1848E56; Mon, 12 Jun 2023 13:35:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fAq2kT+GSd4AV/OoOrGMSyqSLcdztV0PytzVYhGHtCEZhMcKdiGA2pzviaE0DINkjdDtsNc/E1CaIQMDgrGfvJMJPdYH3+uGLRq9Yd9/e+CsfM6XNbb8vuB54SkcwuU3KJg9HZoPJIiNOgTrEllLBS/v8VjuMLzFOXaDSWFZBHdX+y2eUo4xEghY3P3TWdq6RHFgvcCeJw2ny/MkLe5TQdpSFakM3CkxGYmuYcCYivX7dfXvEAWp2CaNLK83aWUQxaUwOmR1IjT54sJzPbuPw5OELpKVzoCRWCU2FdrHE2Ot62uZgQkG1X2FlVBdRijxyoxZ0gOtUo1JnhZ9eY5jUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q3jlBv0SLDnSXx5LFjozJINPkoX9ob6AsqXt6WuD2a0=; b=Vticdgo8uN20oYU1gCZXFbXyBqBiM63KacFBqoMNVgG0874c5L4WMDieJ76UXTsJRXE+88eJGmY25ctxW1RrU7o1Q8uGlSZBDu10OmG3einwbZ2w7DRGxRineXnVIRCZmDjWDfDcVRdSCUB2ttWLc8teCLlyEKk637fOne6VLOfm+UTQSfP8KS0kfeQh0ZBAcrDm3Hy6GWSjn+SLDDRXcvcOAOZLZqB1hQlOHheJq0xFOir9ku7KyeumUY/JymRzOf3bAgHSUVp3c6LgWVHSpRjSn0DO27buzIM3iLdafBjRSfi6ozxIZr/o5sYGr/joQNin/FI243pgRZbd+u0UNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q3jlBv0SLDnSXx5LFjozJINPkoX9ob6AsqXt6WuD2a0=; b=Of71S04DEZnXTCVP/lt1+CAIwbSc3YpnjvejPOxYns6pm3xg+2NMQpxWfuII8xqqYdi9OSmbArpJdCTmMUxh5QG1mUlgCeI0EFNMzxPnmTnF3FF6P90TEE4q0GuG1CKkkxEWB9BjR5+1znl+Au1zrAetkw2LeqEIbUrF0eaaxK8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB4845.eurprd04.prod.outlook.com (2603:10a6:803:51::30) by AS8PR04MB7975.eurprd04.prod.outlook.com (2603:10a6:20b:2a4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.36; Mon, 12 Jun 2023 20:35:01 +0000 Received: from VI1PR04MB4845.eurprd04.prod.outlook.com ([fe80::602f:42ad:882a:5ca7]) by VI1PR04MB4845.eurprd04.prod.outlook.com ([fe80::602f:42ad:882a:5ca7%3]) with mapi id 15.20.6455.045; Mon, 12 Jun 2023 20:35:01 +0000 From: Frank Li To: vkoul@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, peng.fan@nxp.com, joy.zou@nxp.com, shenwei.wang@nxp.com, imx@lists.linux.dev Subject: [PATCH v4 08/12] dmaengine: fsl-edma: move clearing of register interrupt into setup_irq function Date: Mon, 12 Jun 2023 16:34:14 -0400 Message-Id: <20230612203418.2017769-9-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230612203418.2017769-1-Frank.Li@nxp.com> References: <20230612203418.2017769-1-Frank.Li@nxp.com> X-ClientProxiedBy: SJ2PR07CA0016.namprd07.prod.outlook.com (2603:10b6:a03:505::16) To VI1PR04MB4845.eurprd04.prod.outlook.com (2603:10a6:803:51::30) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR04MB4845:EE_|AS8PR04MB7975:EE_ X-MS-Office365-Filtering-Correlation-Id: 9730f1b7-34e1-4e17-dbae-08db6b847ee7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j2n94GRwifVvmgtAXrYHKA8lYKLvuYF+h6URXNLZIfTOLIcyOk1DjjmqMTX160OEKOMkIlXQPs+6seKEg92uDrpQUF+UH27184FbJ3i3/9yfuya5CKj1/qezvYDU3B5g6hQAipvIBNQnKV5ItRoeg+KB1HaK3VqIrMs1Z5BRUjtu0sMisLLQnzQtvjluVRX8C7IXepHstfRqD0lCbzP1rDEqdqPfDSmLw69b1W5M5cM1c9TTGUOmykmwi3pN9kEL1FueEI3eGkVTTpEYePul/PLM13V04etJmtVr0jHub7Zk4eUhzKMsfoRsafb/RAZ4245i7bwE6YLUCfYLi9rfaOX3vTkQlKY0gxDVvNJaYVAewcQ7aYWiiH+6DwhryYfca8f3wk38UPE9AxNKom4ulgpjKdX5ZaSzYOOOktfsLegnc3zPdrvNAunZIywvc9puQ6BVYSAlDHW/mZ6/fL6ANOVp22Hcqzd46SkhzuGKGm2wA1Ic53CLyf8XeDGgdRNvvExpEBl9BhwoZcO2LZtIy58QrNyX5Kea1gc7V1CJty76/dBZwPOLjUQ7CMWbjZsXcQjmTTUUl2sUsQo6CGk0hcxwCNNYntM51ADvrAUCmMd/OhKZP+M8Inry7AUW07DAMHuNh7H+Itp1iBBNmpsvmA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB4845.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(376002)(366004)(136003)(346002)(396003)(451199021)(36756003)(1076003)(26005)(6512007)(186003)(5660300002)(41300700001)(6506007)(478600001)(8676002)(2616005)(66556008)(66946007)(83380400001)(66476007)(6666004)(8936002)(2906002)(6486002)(38350700002)(38100700002)(316002)(86362001)(52116002)(921005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: veJVLMIAQm4hJYu9ZrsX/npx8JJ27QU8E1ohpGCLi1QHAEpJIBEclgiU3K46KdeJL6ZMjOSGo+nTRI3g/Ze8xGLVx8CZT64/D0rY+jkVXwBxRT7HCXjEd865ZaR/LxvNH5mfZHZ9A3xnPI/6JEN6RN9PyICbv4T/Ffb2HKGdTtXp21fFBei/0N3pqp+8xFIDXz5vZPYMt3uHdf5fs6fxzY3JnmaPTP9HhiEh2HFPFBFiPkdOLgiJS7fGddw0kjJnqsugIng16VEHL1zx/mNjDRXTNDd+p6ABzPb85dh+H+X0rbDSwmXHkQiORIDRVZQIeiFfPX/UyUhMhsNsIq74+qRMNvpgLbA9glILG24nRoJQbBtaLcuuozV7F/zLTfRyVpeCLaYLDViPCAafRtCccT8ku5QZNJh0IJOp7aUopji3U29uSuHG5R+j386x56xbZE8Z4sGs6+FoN1njgjtZjxWvxZH/y2QA/mY6uLmGqn/5sGJKXikzpPP5mONJRYBa9g7CCE8K/06ua/TXlQwT7mZSy9H7V0a1w99i8RREP4INpD37k5FchHDAAEY0H4AeWvBa700l32qNzwvEuN9nDIc/d4fP6KszMPccCsPnOfHxphljtDfqR6fXrXtv5jn2RiaxaunuOJBAIznTnKnzKCcLgc4yXWz/tmj6SRrpL+ZkTgVWuVWhC5f/L5rErdllzdaZnH0wMX3vKmo4K0qy6Fxt8AAMsXGcUdCJGZcWeMw425pn4xEH464JGMjThtNwR9pL6FRtvDAWI8KceyUzzlHW3uvfRceHAUdC6SYvhgyUDYmeDimmSHaAf2kHq/tCB/SMmOV1gOxx7REpq3hB3EWJGQr4+XU7+EOi+nPLNdJ79WTUUTbh4KuxC+Qdzv4sdYf/L6gFG4m+wB5LW1pSUHRy9TwSuftym3vUrKqR24fgoPItR60t1N0+ToESBkjxZBs3lYDqIAw1O15X7e7oH0utmsKiqNErf81fOSWmFeoJ5j9H61TPHRnZgG9pE7ty3H3V6CoxpmF3cBvQfBZqb8i6elrhCW2CKGX3mRqLSXA0QSstNXyGrmUD+m9DYTNQII1vLspLCz2tSQuoLCM0DDKUFZ/ewWeP9q53xqcvQW9edYl8YGkWPy3OW06GFwv8oeaN6jxDjWEz2DminTscBBvi5ILVtEyqsNcpt73/TIK+uP4jGqGk9wWmC7+4nYpDgqwib6IlnQALHHOBaVi3aKZ+3i7dWOB3bOxlp0kteuaARDQcRX3cHeTZL61PqIhSNkAJVvdapqMmSKDZXQyczlON60P2ybr38IxhXGQhKEEUFHRcU6L35h5WYoD300CTaRKAQa2uuF29kgaMIrUuuuojqAujIrvAx8R7sQx9sVlroNA1xR3vLNWy1O9uv6QcgWHiojMJqT8STqkhwsr2+IpxVXHb69DBznKlpmbJz3Gk9DBIY1H31ciimZ039p2mbk+3LGC/fFFBXUsJ5Yexvz1fUgCq54UnNVflTLGiMZ3v7USlYUtEXAwHcNMDU+WQ0Fof+uLJNuYAMWXBqVEPWD7DoVVvvzbm12VfappzFZAq/mtlMm3zuoKqSM1ydFPR X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9730f1b7-34e1-4e17-dbae-08db6b847ee7 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4845.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 20:35:01.5237 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oopAH/xFhAAQw8JfDmk1piPQbNKITP6Ttm+2NxoH7wFZig9GYhvalpPotSBSFwrUC2IZlBcqp0PAhOPk4l/i3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7975 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org This accommodates differences in the register layout of EDMA v3 by moving the clearing of register interrupts into the platform-specific set_irq function. This should ensure better compatibility with EDMA v3. Signed-off-by: Frank Li --- drivers/dma/fsl-edma-main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c index 503e5ad5a8dd..e67aec3f76b5 100644 --- a/drivers/dma/fsl-edma-main.c +++ b/drivers/dma/fsl-edma-main.c @@ -113,6 +113,8 @@ fsl_edma_irq_init(struct platform_device *pdev, struct fsl_edma_engine *fsl_edma { int ret; + edma_writel(fsl_edma, ~0, fsl_edma->regs.intl); + fsl_edma->txirq = platform_get_irq_byname(pdev, "edma-tx"); if (fsl_edma->txirq < 0) return fsl_edma->txirq; @@ -154,6 +156,8 @@ fsl_edma2_irq_init(struct platform_device *pdev, int i, ret, irq; int count; + edma_writel(fsl_edma, ~0, fsl_edma->regs.intl); + count = platform_irq_count(pdev); dev_dbg(&pdev->dev, "%s Found %d interrupts\r\n", __func__, count); if (count <= 2) { @@ -311,7 +315,6 @@ static int fsl_edma_probe(struct platform_device *pdev) fsl_edma_chan_mux(fsl_chan, 0, false); } - edma_writel(fsl_edma, ~0, regs->intl); ret = fsl_edma->drvdata->setup_irq(pdev, fsl_edma); if (ret) return ret;