From patchwork Tue Sep 24 10:52:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shengjiu Wang X-Patchwork-Id: 174259 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp3973946ill; Tue, 24 Sep 2019 03:54:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqzqkSbsWc56rvAQ9AaCJ+oSbF3dLkekPl0aARrycfJ4hfurRVZgPqcxgj1Yrq/ZzaRb+C1M X-Received: by 2002:a50:e79b:: with SMTP id b27mr1988176edn.186.1569322462914; Tue, 24 Sep 2019 03:54:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569322462; cv=none; d=google.com; s=arc-20160816; b=Fg3FPSlfVcadJxVC9HwZDU2laOQ5WvGolWxnnWCc1AnabzeSAH16vIBm0Te2j3KbRp 1Y2bZ2hdlEMSE9Yaw9u6KwoUvPMeNMaukU9xwHWUsH+srsjeFElhJmxNXY/qbFPtc1Bt MHy2FCLU01y+orbMjqNvOS9wyPo3Q6PBD8AMuMwA4Lypj1Xt/S3WCndvub5rZbmnU1kE 6Ddg++JRSsh/FEyHG3c6weLyOFTVOv7OsXxIjEO2/6JgSHPZLSM8MCqc+fv9FuTnSD9u VyMYCzcJ54RcKlJHHjDmcY+7hanFVmqMdF0CqoNi+o6QyYn4p5i2OgUmhiGiImaU6u/5 i7bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:to:from; bh=n3VsU1aBN2cfEJJpHMaELkGxoJWaJdn9iiz7yJFQ1jc=; b=XHixVZFNoAMMaX2FPmOvJIKBLO7huLkUsD+oJ/6gQR9yxkf4A1/wkG84lf+D7un2rx UCOyljt9HFWC1nEb3aCQRutxkN9OtV7FXAt3JEp3MMknPS0dlUNFh9VXNcg2xrjmk9rg ze0Fsp0uYKGfHI8jJqZb6kqs+8CUgTrvo0nLAmKhvVRI3dyfrOOYMtYVH6wM6QS2BXAU 8KfyTE5Bs9JqT6SUUWhWYX6Udacmg4bd2R30P0jf7535F4zCaOr7dTc3XMZ4Tym9SNYE 11ut8pC04lCMLy1UsIEMEfVTVYiTDY0s98ji7XXMgv4rSl6zsIWd3v4n5vN0m9HYqhsD Vd5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ns21si659228ejb.167.2019.09.24.03.54.22; Tue, 24 Sep 2019 03:54:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440770AbfIXKyW (ORCPT + 8 others); Tue, 24 Sep 2019 06:54:22 -0400 Received: from inva020.nxp.com ([92.121.34.13]:41538 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393006AbfIXKyV (ORCPT ); Tue, 24 Sep 2019 06:54:21 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 710091A03C3; Tue, 24 Sep 2019 12:54:19 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id DA4D21A00E7; Tue, 24 Sep 2019 12:54:12 +0200 (CEST) Received: from localhost.localdomain (shlinux2.ap.freescale.net [10.192.224.44]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 9AB2C40324; Tue, 24 Sep 2019 18:54:04 +0800 (SGT) From: Shengjiu Wang To: timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, lars@metafoo.de Subject: [PATCH V4 2/4] ASoC: fsl_asrc: update supported sample format Date: Tue, 24 Sep 2019 18:52:33 +0800 Message-Id: <45a7c383f43cc1dd9d0934846447aee653278c03.1569296075.git.shengjiu.wang@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: X-Virus-Scanned: ClamAV using ClamSMTP Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The ASRC support 24bit/16bit/8bit input width, which is data width, not slot width. For the S20_3LE format, the data with is 20bit, slot width is 24bit, if we set ASRMCR1n.IWD to be 24bits, the result is the volume is lower than expected, it likes 24bit data right shift 4 bits So replace S20_3LE with S24_3LE in supported list and add S8 format in TX supported list Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen --- sound/soc/fsl/fsl_asrc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.21.0 diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c index 4d3804a1ea55..584badf956d2 100644 --- a/sound/soc/fsl/fsl_asrc.c +++ b/sound/soc/fsl/fsl_asrc.c @@ -624,7 +624,7 @@ static int fsl_asrc_dai_probe(struct snd_soc_dai *dai) #define FSL_ASRC_FORMATS (SNDRV_PCM_FMTBIT_S24_LE | \ SNDRV_PCM_FMTBIT_S16_LE | \ - SNDRV_PCM_FMTBIT_S20_3LE) + SNDRV_PCM_FMTBIT_S24_3LE) static struct snd_soc_dai_driver fsl_asrc_dai = { .probe = fsl_asrc_dai_probe, @@ -635,7 +635,8 @@ static struct snd_soc_dai_driver fsl_asrc_dai = { .rate_min = 5512, .rate_max = 192000, .rates = SNDRV_PCM_RATE_KNOT, - .formats = FSL_ASRC_FORMATS, + .formats = FSL_ASRC_FORMATS | + SNDRV_PCM_FMTBIT_S8, }, .capture = { .stream_name = "ASRC-Capture",