From patchwork Fri May 25 10:31:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 136830 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp3396947lji; Fri, 25 May 2018 03:32:57 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoSY2NoqtPOVu5KEOYNuPNj0EcrO73i6/qEJUciG207D2aMO+cibsUFTs1aEM+ACO7aLyNW X-Received: by 2002:a63:b307:: with SMTP id i7-v6mr1529205pgf.448.1527244377001; Fri, 25 May 2018 03:32:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527244376; cv=none; d=google.com; s=arc-20160816; b=KyglIJ6TWIRZRJ5PXDcGZ8or707aZNtYPx8U0oVwWj5GdB4XILtFKcH2OqmocNC9iM SruUzcrYB4JuzX+NnLFs8+D6w8AfTLyyxx7LbLsGGfV9a7ozXb9QexHpJdOT2KCUFoM/ GjXYYF4xHySPTPxCxxm+9UpCqzSaG8+ZuLoeoRBgpaDmfxiwhppxOI++Z0oYWasFXAzX fvcuR/WNHlpJzPmhZEZqhkXpgJy3C8JZH3jcmhkTdsAcli+Z3vKrDm72I94RwEv8r9cZ bbIYei3vZW93VAXN/Vpp4madcaW3waxvkZpjuelYIblpJChy0+nP9cf00IUwGNgrWKAl cnMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=BcMhW39DXdd7618odPw1HbTRHsk0odBojz6QjaQBpDo=; b=ZSl9Yd00IZ/BjM85K5EfnnmRIrryTOl3Lobjtt6Xg7n7zQuYKFc/haRRDTlLZFkE2x I+iWdkiJwHdf5Q56RZTqDGv3rmggPs591gh5LaO7gaZLsWmGG3euMFjYV6mJrKsLfF5b v/oW+kzuy79KSsczPYDEP5fGaoo/mXWQAyjuwg52uI4jX7UAoIvitzHnBdGqWh1MmIi1 qQ4D/xLXSUKIrZFW18U2Zb0KvhmDA1TGOr6I5F/q0iYcOLOT5WjArYB/byx0L2n/J+3N 8cnRgpWu46YtaGH+NmQe5eIHhHpOgSs015tICmxE/ErkQOdkktVb02WazyfrAj22MTVN yLew== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=b9F9FOac; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b3-v6si23630336pld.215.2018.05.25.03.32.56; Fri, 25 May 2018 03:32:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=b9F9FOac; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966303AbeEYKcy (ORCPT + 5 others); Fri, 25 May 2018 06:32:54 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:40863 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965647AbeEYKcv (ORCPT ); Fri, 25 May 2018 06:32:51 -0400 Received: by mail-pg0-f65.google.com with SMTP id l2-v6so2128728pgc.7 for ; Fri, 25 May 2018 03:32:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=oI2cROa+PxL2Hh479zrubLMWd0VS3zfe+ruyZ1msXaY=; b=b9F9FOacHQ112XFsBoUG9iw0JX93Pfsn1kp1pm3OipwS/pMcZKKPnhYfXL9yLE2lLC 2pga+BOZnCHBf9ssymqiu6Gvj98ZNpqB5Uk5NbR+nrWv2PI/CNXfDWQ/lGtnno+Kj7lv fh4OOCJDt4qfRkCc2b31DMGulkxzbK6Sr3dnQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=oI2cROa+PxL2Hh479zrubLMWd0VS3zfe+ruyZ1msXaY=; b=W5rHXKq1r73YNO7xeX8uDu8rc4CwPB52FSh5V3zgE+uheR/v8ERjICIoRpzVO22Odl SRHaWub6WPvDt37NbGOM4ow7y9hwv25x7b7Js2FeWiVi9BwHvYqnMq5Hu1f/UfmCBHRd anUTc8y3DV5GaHfq0MJA3eKd9ODAkXR6tYTsWGRY+VlmpWcvtSX5SJSbNjwwZ5HhCQqR TqZ1UQONiPBt9dpuJXdxSU36/7zVn30N4MJgBfvg5KzKS/g28B5iLkwZrApCh9d3GpvG KOwIXACLAtfRgtEJpwWzXcj7QqJlZE5xvM78tsejQ/Gt4iGT7OJNn5QoyvDoJyL8RrqT XseQ== X-Gm-Message-State: ALKqPwco/hmwLgcG/3q7EMm0QO3VN/GDgwjHH9pRXShKMzFsbzVHlwc9 Z0lZXKXit3Di3lzRUlR4vRt+0A== X-Received: by 2002:a62:6883:: with SMTP id d125-v6mr2001382pfc.26.1527244371016; Fri, 25 May 2018 03:32:51 -0700 (PDT) Received: from localhost ([122.172.112.176]) by smtp.gmail.com with ESMTPSA id p71-v6sm58522698pfl.170.2018.05.25.03.32.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 May 2018 03:32:50 -0700 (PDT) From: Viresh Kumar To: arm@kernel.org, Jisheng Zhang , Sebastian Hesselbarth , Rob Herring , Mark Rutland Cc: Viresh Kumar , Vincent Guittot , ionela.voinescu@arm.com, Daniel Lezcano , chris.redpath@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/15] arm: dts: berlin: Add missing OPP properties for CPUs Date: Fri, 25 May 2018 16:01:57 +0530 Message-Id: X-Mailer: git-send-email 2.15.0.194.g9af6a3dea062 In-Reply-To: References: In-Reply-To: References: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The OPP properties, like "operating-points", should either be present for all the CPUs of a cluster or none. If these are present only for a subset of CPUs of a cluster then things will start falling apart as soon as the CPUs are brought online in a different order. For example, this will happen because the operating system looks for such properties in the CPU node it is trying to bring up, so that it can create an OPP table. Add such missing properties. Fix other missing properties (clocks, clock latency) as well to make it all work. Signed-off-by: Viresh Kumar --- arch/arm/boot/dts/berlin2.dtsi | 10 ++++++++++ arch/arm/boot/dts/berlin2q.dtsi | 33 +++++++++++++++++++++++++++++++++ 2 files changed, 43 insertions(+) -- 2.15.0.194.g9af6a3dea062 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/boot/dts/berlin2.dtsi b/arch/arm/boot/dts/berlin2.dtsi index d575823c5750..487e9de53244 100644 --- a/arch/arm/boot/dts/berlin2.dtsi +++ b/arch/arm/boot/dts/berlin2.dtsi @@ -81,6 +81,16 @@ device_type = "cpu"; next-level-cache = <&l2>; reg = <1>; + + clocks = <&chip_clk CLKID_CPU>; + clock-latency = <100000>; + operating-points = < + /* kHz uV */ + 1200000 1200000 + 1000000 1200000 + 800000 1200000 + 600000 1200000 + >; }; }; diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi index bf3a6c9a1d34..9cd00ab53f2d 100644 --- a/arch/arm/boot/dts/berlin2q.dtsi +++ b/arch/arm/boot/dts/berlin2q.dtsi @@ -76,6 +76,17 @@ device_type = "cpu"; next-level-cache = <&l2>; reg = <1>; + + clocks = <&chip_clk CLKID_CPU>; + clock-latency = <100000>; + /* Can be modified by the bootloader */ + operating-points = < + /* kHz uV */ + 1200000 1200000 + 1000000 1200000 + 800000 1200000 + 600000 1200000 + >; }; cpu@2 { @@ -83,6 +94,17 @@ device_type = "cpu"; next-level-cache = <&l2>; reg = <2>; + + clocks = <&chip_clk CLKID_CPU>; + clock-latency = <100000>; + /* Can be modified by the bootloader */ + operating-points = < + /* kHz uV */ + 1200000 1200000 + 1000000 1200000 + 800000 1200000 + 600000 1200000 + >; }; cpu@3 { @@ -90,6 +112,17 @@ device_type = "cpu"; next-level-cache = <&l2>; reg = <3>; + + clocks = <&chip_clk CLKID_CPU>; + clock-latency = <100000>; + /* Can be modified by the bootloader */ + operating-points = < + /* kHz uV */ + 1200000 1200000 + 1000000 1200000 + 800000 1200000 + 600000 1200000 + >; }; };