| Message ID | 20210305093958.187358-1-ardb@kernel.org |
|---|---|
| Headers | show |
| Series | use RT_PROPERTIES table to implement efi=novamap | expand |
On Fri, Mar 05, 2021 at 10:39:58AM +0100, Ard Biesheuvel wrote: > The EFI_RT_PROPERTIES_TABLE contains a mask of runtime services that are > available after ExitBootServices(). This mostly does not concern the EFI > stub at all, given that it runs before that. However, there is one call > that is made at runtime, which is the call to SetVirtualAddressMap() > (which is not even callable at boot time to begin with) > > So add the missing handling of the RT_PROP table to ensure that we only > call SetVirtualAddressMap() if it is not being advertised as unsupported > by the firmware. > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org> On Lenovo Yoga C630 laptop: Tested-by: Shawn Guo <shawn.guo@linaro.org> It's a great help to dropping 'efi=novamap' kernel cmdline, which is a very nice thing for distros to support Snapdragon laptops. Thanks much, Ard! Shawn
On Fri, Mar 05, 2021 at 10:39:57AM +0100, Ard Biesheuvel wrote: > This patch addresses an oversight on my part when I implemented Linux > side support for the EFI RT properties table: SetVirtualAddressMap() is > itself a runtime service which is only callable at runtime to begin with, > and so the EFI stub should only call it if it is not marked as unsupported. > > This may be useful for the Snapdragon EFI based laptops, which already rely > on a special EFI driver to expose the correct DT based on metadata exposed > by EFI. These systems ship with a broken implementation of SetVirtualAddressMap, > which is currently being worked around by passing efi=novamap on the kernel. > command line. > > After applying this patch (which I intend to propose for backporting to 5.10), > the same can be achieved by exposing a RT_PROP table that marks SetVAMap() as > unsupported. And while at it, better mark the variable services as unsupported > as well, since they don't work under Linux either. > > I'm open to extending this with a Linux specific override value kept in a > EFI variable, so that platforms that cannot support DtbLoader are able to > implement something similar. Yes, that will be much appreciated! IMHO, this is definitely an useful addition, as DtbLoader shouldn't be mandated. In some cases, people may choose to load DTB with other means, or DTB is not required at all. Yeah, ACPI kernel is already useful for these laptops, not only for running installer but also as a console based native arm64 machine. Looking forward to something for testing :) Shawn
This patch addresses an oversight on my part when I implemented Linux side support for the EFI RT properties table: SetVirtualAddressMap() is itself a runtime service which is only callable at runtime to begin with, and so the EFI stub should only call it if it is not marked as unsupported. This may be useful for the Snapdragon EFI based laptops, which already rely on a special EFI driver to expose the correct DT based on metadata exposed by EFI. These systems ship with a broken implementation of SetVirtualAddressMap, which is currently being worked around by passing efi=novamap on the kernel. command line. After applying this patch (which I intend to propose for backporting to 5.10), the same can be achieved by exposing a RT_PROP table that marks SetVAMap() as unsupported. And while at it, better mark the variable services as unsupported as well, since they don't work under Linux either. I'm open to extending this with a Linux specific override value kept in a EFI variable, so that platforms that cannot support DtbLoader are able to implement something similar. Cc: Jeffrey Hugo <jhugo@codeaurora.org>, Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Shawn Guo <shawn.guo@linaro.org> Cc: Rob Clark <robdclark@gmail.com> Cc: Leif Lindholm <leif@nuviainc.com> Cc: linux-arm-msm@vger.kernel.org Ard Biesheuvel (1): efi: stub: omit SetVirtualAddressMap() if marked unsupported in RT_PROP table drivers/firmware/efi/libstub/efi-stub.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)