@@ -109,6 +109,14 @@ static inline bool is_hest_type_generic_v2(struct ghes *ghes)
bool ghes_disable;
module_param_named(disable, ghes_disable, bool, 0);
+/*
+ * "ghes.edac_force_load" forcibly loads ghes_edac and skips the platform
+ * check.
+ */
+bool ghes_edac_force_load;
+module_param_named(edac_force_load, ghes_edac_force_load, bool, 0);
+EXPORT_SYMBOL(ghes_edac_force_load);
+
/*
* All error sources notified with HED (Hardware Error Device) share a
* single notifier callback, so they need to be linked and checked one
@@ -1483,6 +1491,9 @@ void __init acpi_ghes_init(void)
return;
}
+ if (!IS_ENABLED(CONFIG_X86))
+ ghes_edac_force_load = true;
+
ghes_nmi_init_cxt();
rc = platform_driver_register(&ghes_platform_driver);
@@ -54,10 +54,6 @@ static DEFINE_MUTEX(ghes_reg_mutex);
*/
static DEFINE_SPINLOCK(ghes_lock);
-/* "ghes_edac.force_load=1" skips the platform check */
-static bool __read_mostly force_load;
-module_param(force_load, bool, 0);
-
static bool system_scanned;
/* Memory Device - Type 17 of SMBIOS spec */
@@ -408,10 +404,10 @@ int ghes_edac_register(struct ghes *ghes, struct device *dev)
if (IS_ENABLED(CONFIG_X86)) {
/* Check if safe to enable on this system */
idx = acpi_match_platform_list(plat_list);
- if (!force_load && idx < 0)
+ if (!ghes_edac_force_load && idx < 0)
return -ENODEV;
} else {
- force_load = true;
+ ghes_edac_force_load = true;
idx = 0;
}
@@ -535,7 +531,7 @@ void ghes_edac_unregister(struct ghes *ghes)
struct mem_ctl_info *mci;
unsigned long flags;
- if (!force_load)
+ if (!ghes_edac_force_load)
return;
mutex_lock(&ghes_reg_mutex);
@@ -27,9 +27,11 @@ extern int hest_disable;
extern int erst_disable;
#ifdef CONFIG_ACPI_APEI_GHES
extern bool ghes_disable;
+extern bool ghes_edac_force_load;
void __init acpi_ghes_init(void);
#else
#define ghes_disable 1
+#define ghes_edac_force_load 0
static inline void acpi_ghes_init(void) { }
#endif
ghes_edac_init() is too late to set this module flag ghes_edac.force_load. Also, other edac drivers should not be able to control this flag. Move this flag to the module parameter in ghes instead. Suggested-by: Toshi Kani <toshi.kani@hpe.com> Signed-off-by: Jia He <justin.he@arm.com> --- drivers/acpi/apei/ghes.c | 11 +++++++++++ drivers/edac/ghes_edac.c | 10 +++------- include/acpi/apei.h | 2 ++ 3 files changed, 16 insertions(+), 7 deletions(-)