| Message ID | 20231101172017.3872242-1-thierry.reding@gmail.com |
|---|---|
| Headers | show |
| Series | fbdev/simplefb: Add missing simple-framebuffer features | expand |
Hi, On 11/1/23 18:20, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > Hi, > > This contains two patches that bring simplefb up to feature parity with > simpledrm. The patches add support for the "memory-region" property that > provides an alternative to the "reg" property to describe the memory > used for the framebuffer and allow attaching the simple-framebuffer > device to one or more generic power domains to make sure they aren't > turned off during the boot process and take down the display > configuration. > > Changes in v2: > - remove unnecessary call to simplefb_detach_genpds() since that's > already done automatically by devres > - fix crash if power-domains property is missing in DT Thanks, the new version looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> for the series. Helge, will you pick these 2 up, or shall I push them to drm-misc-fixes? Regards, Hans > Thierry Reding (2): > fbdev/simplefb: Support memory-region property > fbdev/simplefb: Add support for generic power-domains > > drivers/video/fbdev/simplefb.c | 128 +++++++++++++++++++++++++++++++-- > 1 file changed, 123 insertions(+), 5 deletions(-) >
Hi, On 11/1/23 18:54, Hans de Goede wrote: > Hi, > > On 11/1/23 18:20, Thierry Reding wrote: >> From: Thierry Reding <treding@nvidia.com> >> >> Hi, >> >> This contains two patches that bring simplefb up to feature parity with >> simpledrm. The patches add support for the "memory-region" property that >> provides an alternative to the "reg" property to describe the memory >> used for the framebuffer and allow attaching the simple-framebuffer >> device to one or more generic power domains to make sure they aren't >> turned off during the boot process and take down the display >> configuration. >> >> Changes in v2: >> - remove unnecessary call to simplefb_detach_genpds() since that's >> already done automatically by devres >> - fix crash if power-domains property is missing in DT > > Thanks, the new version looks good to me: > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > > for the series. > > Helge, will you pick these 2 up, or shall I push them to drm-misc-fixes? I have pushed this to drm-misc-next now. I now I said drm-misc-fixes at first, but on a second look these really are not fixes, so getting them in mainline will have to wait to the next merge-window. Regards, Hans
From: Thierry Reding <treding@nvidia.com> Hi, This contains two patches that bring simplefb up to feature parity with simpledrm. The patches add support for the "memory-region" property that provides an alternative to the "reg" property to describe the memory used for the framebuffer and allow attaching the simple-framebuffer device to one or more generic power domains to make sure they aren't turned off during the boot process and take down the display configuration. Changes in v2: - remove unnecessary call to simplefb_detach_genpds() since that's already done automatically by devres - fix crash if power-domains property is missing in DT Thanks, Thierry Thierry Reding (2): fbdev/simplefb: Support memory-region property fbdev/simplefb: Add support for generic power-domains drivers/video/fbdev/simplefb.c | 128 +++++++++++++++++++++++++++++++-- 1 file changed, 123 insertions(+), 5 deletions(-)