| Message ID | 20231120214624.9378-1-hkallweit1@gmail.com |
|---|---|
| Headers | show |
| Series | remove I2C_CLASS_DDC support | expand |
On Mon, 20 Nov 2023, Heiner Kallweit <hkallweit1@gmail.com> wrote: > v4: > - more ack and review tags Please do not send new versions just to record the acks and reviews. They should be added while applying the patches. Thanks, Jani.
On 21.11.2023 09:58, Jani Nikula wrote: > On Mon, 20 Nov 2023, Heiner Kallweit <hkallweit1@gmail.com> wrote: >> v4: >> - more ack and review tags > > Please do not send new versions just to record the acks and > reviews. They should be added while applying the patches. > Right, typically also patchwork interprets and shows A-b and R-b when sent as a reply to a patch of the series. I sent a new version because an A-b covered multiple patches and was sent as reply to the cover letter. > Thanks, > Jani. > Heiner
Hi Am 20.11.23 um 22:46 schrieb Heiner Kallweit: > After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in > olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. > Class-based device auto-detection is a legacy mechanism and shouldn't > be used in new code. So we can remove this class completely now. > > Preferably this series should be applied via the i2c tree. > > v2: > - change tag in commit subject of patch 03 > - add ack tags > v3: > - fix a compile error in patch 5 > v4: > - more ack and review tags > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Acked-by: Thomas Zimmermann <tzimmermann@suse.de> for the patches that don't already have my r-b. Best regards Thomas > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 - > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - > drivers/gpu/drm/ast/ast_i2c.c | 1 - > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 - > drivers/gpu/drm/display/drm_dp_helper.c | 1 - > drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 - > drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 - > drivers/gpu/drm/gma500/intel_gmbus.c | 1 - > drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 - > drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 - > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 - > drivers/gpu/drm/i915/display/intel_gmbus.c | 1 - > drivers/gpu/drm/i915/display/intel_sdvo.c | 1 - > drivers/gpu/drm/loongson/lsdc_i2c.c | 1 - > drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 - > drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 - > drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 - > drivers/gpu/drm/radeon/radeon_i2c.c | 1 - > drivers/gpu/drm/rockchip/inno_hdmi.c | 1 - > drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 - > drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 - > drivers/video/fbdev/core/fb_ddc.c | 1 - > drivers/video/fbdev/cyber2000fb.c | 1 - > drivers/video/fbdev/i740fb.c | 1 - > drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++---------- > drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++-------- > drivers/video/fbdev/s3fb.c | 1 - > drivers/video/fbdev/tdfxfb.c | 1 - > drivers/video/fbdev/tridentfb.c | 1 - > drivers/video/fbdev/via/via_i2c.c | 1 - > include/linux/i2c.h | 1 - > 31 files changed, 9 insertions(+), 47 deletions(-)
On 23.11.2023 07:56, Thomas Zimmermann wrote: > Hi > > Am 20.11.23 um 22:46 schrieb Heiner Kallweit: >> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in >> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. >> Class-based device auto-detection is a legacy mechanism and shouldn't >> be used in new code. So we can remove this class completely now. >> >> Preferably this series should be applied via the i2c tree. >> >> v2: >> - change tag in commit subject of patch 03 >> - add ack tags >> v3: >> - fix a compile error in patch 5 >> v4: >> - more ack and review tags >> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > > Acked-by: Thomas Zimmermann <tzimmermann@suse.de> > > for the patches that don't already have my r-b. > This refers to which patches of the series? Patches 8, 16, 18 are the remaining ones w/o A-b or R-b. > Best regards > Thomas > Thanks, Heiner >> >> --- >> >> drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 - >> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - >> drivers/gpu/drm/ast/ast_i2c.c | 1 - >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 - >> drivers/gpu/drm/display/drm_dp_helper.c | 1 - >> drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 - >> drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 - >> drivers/gpu/drm/gma500/intel_gmbus.c | 1 - >> drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 - >> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 - >> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 - >> drivers/gpu/drm/i915/display/intel_gmbus.c | 1 - >> drivers/gpu/drm/i915/display/intel_sdvo.c | 1 - >> drivers/gpu/drm/loongson/lsdc_i2c.c | 1 - >> drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 - >> drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 - >> drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 - >> drivers/gpu/drm/radeon/radeon_i2c.c | 1 - >> drivers/gpu/drm/rockchip/inno_hdmi.c | 1 - >> drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 - >> drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 - >> drivers/video/fbdev/core/fb_ddc.c | 1 - >> drivers/video/fbdev/cyber2000fb.c | 1 - >> drivers/video/fbdev/i740fb.c | 1 - >> drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++---------- >> drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++-------- >> drivers/video/fbdev/s3fb.c | 1 - >> drivers/video/fbdev/tdfxfb.c | 1 - >> drivers/video/fbdev/tridentfb.c | 1 - >> drivers/video/fbdev/via/via_i2c.c | 1 - >> include/linux/i2c.h | 1 - >> 31 files changed, 9 insertions(+), 47 deletions(-) >
Hi Am 23.11.23 um 08:16 schrieb Heiner Kallweit: > On 23.11.2023 07:56, Thomas Zimmermann wrote: >> Hi >> >> Am 20.11.23 um 22:46 schrieb Heiner Kallweit: >>> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in >>> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. >>> Class-based device auto-detection is a legacy mechanism and shouldn't >>> be used in new code. So we can remove this class completely now. >>> >>> Preferably this series should be applied via the i2c tree. >>> >>> v2: >>> - change tag in commit subject of patch 03 >>> - add ack tags >>> v3: >>> - fix a compile error in patch 5 >>> v4: >>> - more ack and review tags >>> >>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> >> >> Acked-by: Thomas Zimmermann <tzimmermann@suse.de> >> >> for the patches that don't already have my r-b. >> > This refers to which patches of the series? > Patches 8, 16, 18 are the remaining ones w/o A-b or R-b. I've looked through the patchset. Feel free to add my a-b to patches 1 to 19; except for 2 and 17, which already have my r-b. BTW I only received 19 patches. is there a patch 20/20? Best regards Thomas > >> Best regards >> Thomas >> > Thanks, Heiner > >>> >>> --- >>> >>> drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 - >>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - >>> drivers/gpu/drm/ast/ast_i2c.c | 1 - >>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 - >>> drivers/gpu/drm/display/drm_dp_helper.c | 1 - >>> drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 - >>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 - >>> drivers/gpu/drm/gma500/intel_gmbus.c | 1 - >>> drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 - >>> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 - >>> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 - >>> drivers/gpu/drm/i915/display/intel_gmbus.c | 1 - >>> drivers/gpu/drm/i915/display/intel_sdvo.c | 1 - >>> drivers/gpu/drm/loongson/lsdc_i2c.c | 1 - >>> drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 - >>> drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 - >>> drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 - >>> drivers/gpu/drm/radeon/radeon_i2c.c | 1 - >>> drivers/gpu/drm/rockchip/inno_hdmi.c | 1 - >>> drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 - >>> drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 - >>> drivers/video/fbdev/core/fb_ddc.c | 1 - >>> drivers/video/fbdev/cyber2000fb.c | 1 - >>> drivers/video/fbdev/i740fb.c | 1 - >>> drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++---------- >>> drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++-------- >>> drivers/video/fbdev/s3fb.c | 1 - >>> drivers/video/fbdev/tdfxfb.c | 1 - >>> drivers/video/fbdev/tridentfb.c | 1 - >>> drivers/video/fbdev/via/via_i2c.c | 1 - >>> include/linux/i2c.h | 1 - >>> 31 files changed, 9 insertions(+), 47 deletions(-) >> >
On 23.11.2023 09:19, Thomas Zimmermann wrote: > Hi > > Am 23.11.23 um 08:16 schrieb Heiner Kallweit: >> On 23.11.2023 07:56, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 20.11.23 um 22:46 schrieb Heiner Kallweit: >>>> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in >>>> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. >>>> Class-based device auto-detection is a legacy mechanism and shouldn't >>>> be used in new code. So we can remove this class completely now. >>>> >>>> Preferably this series should be applied via the i2c tree. >>>> >>>> v2: >>>> - change tag in commit subject of patch 03 >>>> - add ack tags >>>> v3: >>>> - fix a compile error in patch 5 >>>> v4: >>>> - more ack and review tags >>>> >>>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> >>> >>> Acked-by: Thomas Zimmermann <tzimmermann@suse.de> >>> >>> for the patches that don't already have my r-b. >>> >> This refers to which patches of the series? >> Patches 8, 16, 18 are the remaining ones w/o A-b or R-b. > > I've looked through the patchset. Feel free to add my a-b to patches 1 to 19; except for 2 and 17, which already have my r-b. > > BTW I only received 19 patches. is there a patch 20/20? > Yes, see here: https://patchwork.ozlabs.org/project/linux-i2c/patch/20231120214624.9378-21-hkallweit1@gmail.com/ If you're subscribed to linux-i2c or linux-kernel list you should have received it. > Best regards > Thomas > >> >>> Best regards >>> Thomas >>> >> Thanks, Heiner >> >>>> >>>> --- >>>> >>>> drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 - >>>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - >>>> drivers/gpu/drm/ast/ast_i2c.c | 1 - >>>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 - >>>> drivers/gpu/drm/display/drm_dp_helper.c | 1 - >>>> drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 - >>>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 - >>>> drivers/gpu/drm/gma500/intel_gmbus.c | 1 - >>>> drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 - >>>> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 - >>>> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 - >>>> drivers/gpu/drm/i915/display/intel_gmbus.c | 1 - >>>> drivers/gpu/drm/i915/display/intel_sdvo.c | 1 - >>>> drivers/gpu/drm/loongson/lsdc_i2c.c | 1 - >>>> drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 - >>>> drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 - >>>> drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 - >>>> drivers/gpu/drm/radeon/radeon_i2c.c | 1 - >>>> drivers/gpu/drm/rockchip/inno_hdmi.c | 1 - >>>> drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 - >>>> drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 - >>>> drivers/video/fbdev/core/fb_ddc.c | 1 - >>>> drivers/video/fbdev/cyber2000fb.c | 1 - >>>> drivers/video/fbdev/i740fb.c | 1 - >>>> drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++---------- >>>> drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++-------- >>>> drivers/video/fbdev/s3fb.c | 1 - >>>> drivers/video/fbdev/tdfxfb.c | 1 - >>>> drivers/video/fbdev/tridentfb.c | 1 - >>>> drivers/video/fbdev/via/via_i2c.c | 1 - >>>> include/linux/i2c.h | 1 - >>>> 31 files changed, 9 insertions(+), 47 deletions(-) >>> >> >
Hi Am 23.11.23 um 09:34 schrieb Heiner Kallweit: > On 23.11.2023 09:19, Thomas Zimmermann wrote: >> Hi >> >> Am 23.11.23 um 08:16 schrieb Heiner Kallweit: >>> On 23.11.2023 07:56, Thomas Zimmermann wrote: >>>> Hi >>>> >>>> Am 20.11.23 um 22:46 schrieb Heiner Kallweit: >>>>> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in >>>>> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. >>>>> Class-based device auto-detection is a legacy mechanism and shouldn't >>>>> be used in new code. So we can remove this class completely now. >>>>> >>>>> Preferably this series should be applied via the i2c tree. >>>>> >>>>> v2: >>>>> - change tag in commit subject of patch 03 >>>>> - add ack tags >>>>> v3: >>>>> - fix a compile error in patch 5 >>>>> v4: >>>>> - more ack and review tags >>>>> >>>>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> >>>> >>>> Acked-by: Thomas Zimmermann <tzimmermann@suse.de> >>>> >>>> for the patches that don't already have my r-b. >>>> >>> This refers to which patches of the series? >>> Patches 8, 16, 18 are the remaining ones w/o A-b or R-b. >> >> I've looked through the patchset. Feel free to add my a-b to patches 1 to 19; except for 2 and 17, which already have my r-b. >> >> BTW I only received 19 patches. is there a patch 20/20? >> > Yes, see here: > https://patchwork.ozlabs.org/project/linux-i2c/patch/20231120214624.9378-21-hkallweit1@gmail.com/ > If you're subscribed to linux-i2c or linux-kernel list you should have received it. I see, I'm not on these lists. I don't have the authority to ack that final patch, but let me know if you want to merge anything through the DRM trees. Best regards Thomas > >> Best regards >> Thomas >> >>> >>>> Best regards >>>> Thomas >>>> >>> Thanks, Heiner >>> >>>>> >>>>> --- >>>>> >>>>> drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 - >>>>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - >>>>> drivers/gpu/drm/ast/ast_i2c.c | 1 - >>>>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 - >>>>> drivers/gpu/drm/display/drm_dp_helper.c | 1 - >>>>> drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 - >>>>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 - >>>>> drivers/gpu/drm/gma500/intel_gmbus.c | 1 - >>>>> drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 - >>>>> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 - >>>>> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 - >>>>> drivers/gpu/drm/i915/display/intel_gmbus.c | 1 - >>>>> drivers/gpu/drm/i915/display/intel_sdvo.c | 1 - >>>>> drivers/gpu/drm/loongson/lsdc_i2c.c | 1 - >>>>> drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 - >>>>> drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 - >>>>> drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 - >>>>> drivers/gpu/drm/radeon/radeon_i2c.c | 1 - >>>>> drivers/gpu/drm/rockchip/inno_hdmi.c | 1 - >>>>> drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 - >>>>> drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 - >>>>> drivers/video/fbdev/core/fb_ddc.c | 1 - >>>>> drivers/video/fbdev/cyber2000fb.c | 1 - >>>>> drivers/video/fbdev/i740fb.c | 1 - >>>>> drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++---------- >>>>> drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++-------- >>>>> drivers/video/fbdev/s3fb.c | 1 - >>>>> drivers/video/fbdev/tdfxfb.c | 1 - >>>>> drivers/video/fbdev/tridentfb.c | 1 - >>>>> drivers/video/fbdev/via/via_i2c.c | 1 - >>>>> include/linux/i2c.h | 1 - >>>>> 31 files changed, 9 insertions(+), 47 deletions(-) >>>> >>> >> >
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. v2: - change tag in commit subject of patch 03 - add ack tags v3: - fix a compile error in patch 5 v4: - more ack and review tags Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 - drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - drivers/gpu/drm/ast/ast_i2c.c | 1 - drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 - drivers/gpu/drm/display/drm_dp_helper.c | 1 - drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 - drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 - drivers/gpu/drm/gma500/intel_gmbus.c | 1 - drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 - drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 - drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 - drivers/gpu/drm/i915/display/intel_gmbus.c | 1 - drivers/gpu/drm/i915/display/intel_sdvo.c | 1 - drivers/gpu/drm/loongson/lsdc_i2c.c | 1 - drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 - drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 - drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 - drivers/gpu/drm/radeon/radeon_i2c.c | 1 - drivers/gpu/drm/rockchip/inno_hdmi.c | 1 - drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 - drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 - drivers/video/fbdev/core/fb_ddc.c | 1 - drivers/video/fbdev/cyber2000fb.c | 1 - drivers/video/fbdev/i740fb.c | 1 - drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++---------- drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++-------- drivers/video/fbdev/s3fb.c | 1 - drivers/video/fbdev/tdfxfb.c | 1 - drivers/video/fbdev/tridentfb.c | 1 - drivers/video/fbdev/via/via_i2c.c | 1 - include/linux/i2c.h | 1 - 31 files changed, 9 insertions(+), 47 deletions(-)