| Message ID | 20240304-backlight-probe-v1-0-e5f57d0df6e6@linaro.org |
|---|---|
| Headers | show |
| Series | backlight: Simplify probe in few drivers | expand |
On Mon, Mar 04, 2024 at 11:11:40AM +0100, Krzysztof Kozlowski wrote: > Don't pollute dmesg on deferred probe and simplify the code with > dev_err_probe(). > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Daniel.
On Mon, Mar 04, 2024 at 11:11:42AM +0100, Krzysztof Kozlowski wrote: > Don't pollute dmesg on deferred probe and simplify the code with > dev_err_probe(). > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Daniel.
On Mon, Mar 04, 2024 at 11:11:44AM +0100, Krzysztof Kozlowski wrote: > Core code already prints detailed information about failure of memory > allocation. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Daniel.
On 04/03/2024 11:40, Daniel Thompson wrote: > On Mon, Mar 04, 2024 at 11:11:38AM +0100, Krzysztof Kozlowski wrote: >> Common pattern of handling deferred probe can be simplified with >> dev_err_probe(). Less code and also it prints the error value. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> drivers/video/backlight/gpio_backlight.c | 10 +++------- >> 1 file changed, 3 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c >> index d28c30b2a35d..9f960f853b6e 100644 >> --- a/drivers/video/backlight/gpio_backlight.c >> +++ b/drivers/video/backlight/gpio_backlight.c >> @@ -64,13 +64,9 @@ static int gpio_backlight_probe(struct platform_device *pdev) >> def_value = device_property_read_bool(dev, "default-on"); >> >> gbl->gpiod = devm_gpiod_get(dev, NULL, GPIOD_ASIS); >> - if (IS_ERR(gbl->gpiod)) { >> - ret = PTR_ERR(gbl->gpiod); >> - if (ret != -EPROBE_DEFER) >> - dev_err(dev, >> - "Error: The gpios parameter is missing or invalid.\n"); >> - return ret; >> - } >> + if (IS_ERR(gbl->gpiod)) >> + return dev_err_probe(dev, PTR_ERR(gbl->gpiod), >> + "Error: The gpios parameter is missing or invalid.\n"); > > The "Error: " should be removed from the string. dev_err_probe() already prints > that. Sure. Best regards, Krzysztof
Hi, Simplify old code in few backlight drivers. Best regards, Krzysztof --- Krzysztof Kozlowski (7): backlight: gpio: Simplify with dev_err_probe() backlight: l4f00242t03: Simplify with dev_err_probe() backlight: bd6107: Handle deferred probe backlight: as3711_bl: Handle deferred probe backlight: lm3630a_bl: Handle deferred probe backlight: lm3630a_bl: Simplify probe return on gpio request error backlight: pandora_bl: Drop unneeded ENOMEM error message drivers/video/backlight/as3711_bl.c | 6 ++---- drivers/video/backlight/bd6107.c | 9 +++------ drivers/video/backlight/gpio_backlight.c | 10 +++------- drivers/video/backlight/l4f00242t03.c | 34 +++++++++++++------------------- drivers/video/backlight/lm3630a_bl.c | 13 +++++------- drivers/video/backlight/pandora_bl.c | 4 +--- 6 files changed, 28 insertions(+), 48 deletions(-) --- base-commit: 1870cdc0e8dee32e3c221704a2977898ba4c10e8 change-id: 20240304-backlight-probe-31dee1efe662 Best regards,